Message-ID: <2d983050-f844-6c5e-8ae9-9f87ac68dfdd@tuxedocomputers.com>
Date:   Tue, 14 Feb 2023 13:31:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx
To:     andy.shevchenko@gmail.com
Cc:     mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com,
        linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230210164636.628462-1-wse@tuxedocomputers.com>
 <Y+qyEVxMh4VRIsy3@surfacebook>
Content-Language: en-US
From:   Werner Sembach <wse@tuxedocomputers.com>
In-Reply-To: <Y+qyEVxMh4VRIsy3@surfacebook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 13.02.23 um 22:56 schrieb andy.shevchenko@gmail.com:
> Fri, Feb 10, 2023 at 05:46:36PM +0100, Werner Sembach kirjoitti:
>> commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
>> changed the policy such that I2C touchpads may be able to wake up the
>> system by default if the system is configured as such.
>>
>> However on Clevo NH5xAx/TUXEDO XA15 Gen10 there is a mistake in the ACPI
>> tables that the TP_ATTN# signal connected to GPIO 10 is configured as
>> ActiveLow and level triggered but connected to a pull up. As soon as the
>> system suspends the touchpad loses power and then the system wakes up.
>>
>> To avoid this problem, introduce a quirk for this model that will prevent
>> the wakeup capability for being set for GPIO 10.
> Please, update the commit message and send v2.
>
> We would like to have this fix nevertheless, because users will suffer w/o it.
>
OK I'm on it.