Message-ID: <aac2b313-e4af-dc93-f177-0d0be9620e1b@quicinc.com>
Date:   Tue, 14 Feb 2023 18:04:22 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info
 region
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>,
        Alex Elder <elder@linaro.org>
CC:     Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1675443891-31709-1-git-send-email-quic_mojha@quicinc.com>
 <1675443891-31709-2-git-send-email-quic_mojha@quicinc.com>
 <cc30f686-dec7-db85-cf0d-c6c685a623ce@linaro.org>
 <d1dc0c9b-eab2-0287-d0a2-ead44ecee5ce@quicinc.com>
 <20230206210455.xgrvtvknkor4nllx@ripper>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230206210455.xgrvtvknkor4nllx@ripper>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

+@alex,

Please comment.

-Mukesh

On 2/7/2023 2:34 AM, Bjorn Andersson wrote:
> On Mon, Feb 06, 2023 at 08:06:13PM +0530, Mukesh Ojha wrote:
>>
>>
>> On 2/4/2023 3:07 AM, Konrad Dybcio wrote:
>>>
>>>
>>> On 3.02.2023 18:04, Mukesh Ojha wrote:
>>>> Add a simple-mfd representing IMEM on SM8450 and define the PIL
>>>> relocation info region, so that post mortem tools will be able
>>>> to locate the loaded remoteprocs.
>>>>
>>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>>> ---
>>>   From XBL:
>>>
>>> 0x14680000, 0x0002A000, "IMEM Base"
>>>
>>> Is there anything in that wider address range that would interest
>>> us? I recall Alex once dug into that when diving into IPA, but
>>> I can not recall the conclusion..
>> Spec-wise, yes IPA do own these 0x146A8000 - 0x146AA000 .
>> But, not sure what they use it for.
>>
> 
> The DT should not reflect the organization structure. Let's see if Alex
> have any input on this.
> 
> Thanks,
> Bjorn
> 
>> -Mukesh
>>>
>>> Konrad
>>>>    arch/arm64/boot/dts/qcom/sm8450.dtsi | 15 +++++++++++++++
>>>>    1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> index 5704750..474ea1b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> @@ -3536,6 +3536,21 @@
>>>>    			};
>>>>    		};
>>>> +		sram@146aa000 {
>>>> +			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
>>>> +			reg = <0 0x146aa000 0 0x1000>;
>>>> +
>>>> +			#address-cells = <1>;
>>>> +			#size-cells = <1>;
>>>> +
>>>> +			ranges = <0 0 0x146aa000 0x1000>;
>>>> +
>>>> +			pil-reloc@94c {
>>>> +				compatible = "qcom,pil-reloc-info";
>>>> +				reg = <0x94c 0xc8>;
>>>> +			};
>>>> +		};
>>>> +
>>>>    		apps_rsc: rsc@17a00000 {
>>>>    			label = "apps_rsc";
>>>>    			compatible = "qcom,rpmh-rsc";