From:   "Wu, Wentong" <wentong.wu@intel.com>
To:     Hillf Danton <hdanton@sina.com>
CC:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule
Thread-Topic: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule
Thread-Index: AQHZP1HqpZLwLlRt00ml9e7fRXtKOq7MO6AAgAG4EjCAACxFgIAAM1Hw
Date:   Tue, 14 Feb 2023 12:40:12 +0000
Message-ID: <DM6PR11MB43169E925577B4054D664FA28DA29@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20230213022347.2480307-1-wentong.wu@intel.com>
 <20230213034202.2926-1-hdanton@sina.com>
 <20230214083533.3410-1-hdanton@sina.com>
In-Reply-To: <20230214083533.3410-1-hdanton@sina.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SFQ60MRg5jWr3GIGjs4jP9gyPCpSX9i7qPNrsXIqzJkwdgz46AWNhSys3IH/?=
 =?us-ascii?Q?NLWaZDUMuF5wQGyGfEtaDjiPVRG93NW1jqdMm6R90TzPSXZqp0D3QmIVpnjs?=
 =?us-ascii?Q?4VTv+N15cnVoDN/zHkBJHlaSGZ6ZSZ9h34bK4mpxTQGbIzpJclZY1Ya0Ao3E?=
 =?us-ascii?Q?li3QtPdGPBXknT8q27mAwZg8SgaQfc/2f2McJ67hYoj/jopEIuH9SPC07kZN?=
 =?us-ascii?Q?bMMKd5H47849g8PVfoZ+fpKeRgRgHdapdvhbaSgUW07b8Q+huKArU9pHCjYF?=
 =?us-ascii?Q?t2/Sg8Wz2DSYrp0jHYo1Qk1iIWcw/6I1gfI7LfPL7wttkq4Hfqr5lstfFoUZ?=
 =?us-ascii?Q?CP1eygy67W8Rqv2MQbvF+3UtocFrAv7GlIuAMOPJapz5lbeB56ubg/86oOge?=
 =?us-ascii?Q?mmeKidy6/r1tirjAqYsNuctjRIwoIHfbTgmnqF9VBXfdFsc+KEFTkFM3aipH?=
 =?us-ascii?Q?ei5VvDs0Z1WFIjFLaucolve+R6kHY257J2yNvGTynxbsbOZnBhAr9nSqUZPP?=
 =?us-ascii?Q?ohBT5HWojsLIKwHR38TwPbs2+2sQo7YCZXQx06ALxY1HH+AXWPTesgP0BLPo?=
 =?us-ascii?Q?lx1/J7jZ4wRCCI98GqmwJSdzihU63iJ+aWGm05CSAByLoi0XbQ0u71inZSHe?=
 =?us-ascii?Q?sq+fJGuH3ES3hL98g9021xXVyNfGWxGiOUFGu13zqrlu6hPjCVAtF/RK3A3Y?=
 =?us-ascii?Q?zr2J7ypC9SNPYZgZSCgtozpiUhf7MatN9MmYr7VrvYrWS+vQLPFnRRpndrhn?=
 =?us-ascii?Q?ITmAtM55IFpRDsn2EBH+HekP2tFvKnM37dFqwHFvcdloNzDsCAEYyY8RjNkt?=
 =?us-ascii?Q?3dP/cgTf91c/+jHppTBhOCScfeLVmQkD96Kd9DHdyXOVCOvd9aiNNs5wa8xc?=
 =?us-ascii?Q?lDyz3xOXU1Ytkl7qb8BfcDk7V9m0zSJUCy3Gsn950QHX4oa5eJajt7M7UsjC?=
 =?us-ascii?Q?YEy8WLyRLgLgh2/5JX7HvIGPVZcy0MZMF6FTc93klv8fzROcCKMaK0chhxWe?=
 =?us-ascii?Q?LpsxuIkrbsMGLc8sYbyLHkyOW7Nd+ROLgdAuUfBu4jza8eZyUF5uvaBpiXsq?=
 =?us-ascii?Q?ejcP5Rjo0f3gc2Q3w5Z7xDIrVMFKbr5/DE1LXfHBcO0IvAjn30WOu8PjtNZt?=
 =?us-ascii?Q?2AlJUDaBizXUxxsZAF6uCcPwVMRp85lIbBJ+ailgKjBUrBfw7jww9XBuyGWp?=
 =?us-ascii?Q?X7hc+zosHr8ZrrDGfjnYOr5b6tMXTl2Xg/EBHgntEs4BBMy2Haq1x7YJUn2j?=
 =?us-ascii?Q?WAvdjJMPXWtYQDhwH+0++xN5/DvnhS0F5/po3ycIaLXdQOfQTsk7hPsGROD7?=
 =?us-ascii?Q?P4uwexiJC+dCCL4JYY+Xekwqw+reMJq30bXzW8+yqyIA1VCt/GQz/QLoiiWL?=
 =?us-ascii?Q?zoH/JGacd3O/CD/Z/L4atUXlCt2zNLL2+VlYmTjDIKA24NGi0yD87zOrgIuW?=
 =?us-ascii?Q?u81Cw2N2VBFysLpZZxed8HTL6W3fBmyE2UVR3fw5Zy5DKnDdswHVDf5NLwyA?=
 =?us-ascii?Q?SEUo6bSZqmpX9S5xUuiyCdROcJWJjlXKkQnOiuD/B0f26Qo9gLAcwzoFfw+K?=
 =?us-ascii?Q?ZMQLYtUDIqkxyR922EhK/DUr6WFOBHEePZSeF0E1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37b7a6da-999d-4657-3dbd-08db0e889da9
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 12:40:12.6356
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CAIgrJakfLmI+3BA6QsKp8QAPp8TB86fd38It+BGepS/UV9rQ/TSMEiovIVIZYM2NIs1Dy6O4nZU4hl+FMDz4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6478
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Hillf Danton <hdanton@sina.com>
> Sent: Tuesday, February 14, 2023 4:36 PM
>=20
> On Tue, 14 Feb 2023 06:25:35 +0000 Wentong Wu <wentong.wu@intel.com>
> >
> > This allows new command(e.g. 'get status' command to check current
> > firmware=3D
> >  status) to be downloaded to firmware for debugging purpose in case no
> > resp=3D onse for current command though I have never saw this happen.
> > =3D20
>=20
> Thanks for your specification.
>=20
> Another question, is it likely for the wakeup to come after reinit becaus=
e of for
> instance timeout on the waiter side?

Thanks, first I want to clarify why we have timeout here, in case firmware =
stuck somehow or IVSC device is removed suddenly, calling thread can't be w=
akeup if wait forever here.

And firmware gets high priority to handle command and response, also there =
is timeout mechanism inside firmware, I think there will be some problem wi=
th firmware if driver gets command response after 5s which will be captured=
 by driver code(if (csi->cmd_response.cmd_id !=3D cmd->cmd_id)) but I have =
never saw this happen.

BR,
Wentong