Date:   Tue, 14 Feb 2023 13:07:21 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        Douglas Anderson <dianders@chromium.org>,
        Judy Hsiao <judyhsiao@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SoC: rt5682s: Disable jack detection interrupt during
 suspend
Message-ID: <Y+uHiZ1D5rmFc2L3@sirena.org.uk>
References: <20230209012002.1.Ib4d6481f1d38a6e7b8c9e04913c02ca88c216cf6@changeid>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ETlhmiRcEav6CrZn"
Content-Disposition: inline
In-Reply-To: <20230209012002.1.Ib4d6481f1d38a6e7b8c9e04913c02ca88c216cf6@changeid>
Precedence: bulk


--ETlhmiRcEav6CrZn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 09, 2023 at 01:20:23AM +0000, Matthias Kaehlcke wrote:
> The rt5682s driver switches its regmap to cache-only when the
> device suspends and back to regular mode on resume. When the
> jack detect interrupt fires rt5682s_irq() schedules the jack
> detect work. This can result in invalid reads from the regmap
> in cache-only mode if the work runs before the device has
> resumed:

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--ETlhmiRcEav6CrZn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPrh4gACgkQJNaLcl1U
h9CtFwf/cETeyaTBqREWV1P0f3zFV9nLL3Hh1QF3i6dqz7TwD0wWHQHOOqUWZRWN
B2Tv1YwBEi9pfwbO5tv38mtzz3W1P2xphzbiJF/mP3kk0/bzLeoYCwhDtFsMBmFj
agRsU3GBFhkAuy3/iYuhDh8PSytgoAqTinNxVQU1CiWtk77JEmomm2Q+clxJpQrv
jcIkoKxq6BJNq8zP+TCMTi99h3BzywNhpL3reO31HVulZGxvfArQafPv03O1O3i8
ErpWtrNLq7sr6OhGApZjvCKEinQ4f22VGXbLEMj7fjpYgWM2UXRZeIyCC6/8jzxl
l5G6DJTuk3RflJq/nUqZj5NPL33ZPg==
=5BVe
-----END PGP SIGNATURE-----

--ETlhmiRcEav6CrZn--