Date:   Tue, 14 Feb 2023 08:15:07 -0600
From:   Andrew Halaney <ahalaney@redhat.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     devicetree@vger.kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com,
        alexandre.torgue@foss.st.com, peppe.cavallaro@st.com,
        joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio
Message-ID: <20230214141507.ibj42ejowhvrdoyb@halaney-x13s>
References: <20230213213104.78443-1-ahalaney@redhat.com>
 <20230213213104.78443-2-ahalaney@redhat.com>
 <e4c33665-179b-8bf4-f7eb-38f86dceda56@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4c33665-179b-8bf4-f7eb-38f86dceda56@linaro.org>
Precedence: bulk

On Tue, Feb 14, 2023 at 09:12:36AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 22:31, Andrew Halaney wrote:
> > The property is named snps,reset-gpio. Update the name accordingly so
> > the corresponding phy is reset.
> > 
> > Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board")
> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > index 1bcf228a22b8..b6d7c2526131 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
> > @@ -121,7 +121,7 @@ &eqos {
> >  	phy-handle = <&ethphy0>;
> >  	nvmem-cells = <&fec_mac1>;
> >  	nvmem-cell-names = "mac-address";
> > -	snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> > +	snps,reset-gpio = <&pca6416_1 2 GPIO_ACTIVE_LOW>;
> 
> I don't think it's correct change. This property is deprecated. Also
> uses old, deprecated suffix gpio.
> 

I mentally grandfathered this in, but after your comment realized it
shouldn't be. I'll post a v2 with the reset handled in the phy
node directly. Thanks!