Message-ID: <a5a43d44-277a-1222-a700-ddade69d6243@intel.com>
Date:   Tue, 14 Feb 2023 15:56:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net-next v1 1/3] vxlan: Expose helper vxlan_build_gbp_hdr
Content-Language: en-US
To:     Gavin Li <gavinl@nvidia.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
        <eng.alaamohamedsoliman.am@gmail.com>, <bigeasy@linutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Roi Dayan <roid@nvidia.com>, Maor Dickman <maord@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
References: <20230214134137.225999-1-gavinl@nvidia.com>
 <20230214134137.225999-2-gavinl@nvidia.com>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <20230214134137.225999-2-gavinl@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUthNGVhRHowTVJrbjZtTS8wWWFBUjNMcnNGUi9MajZvSjRaQnlEY3RseWJS?=
 =?utf-8?B?L1lLSkVDemsxRERBOGZ0NmR6bE9mUVFGYkdRYWhJN3NZaE9rWlZST2daNW1R?=
 =?utf-8?B?UTJnK2xkaG92SG5PSmdTRTU5MHRMSEh5c0lEMUNhL3BoZEtpd1kxbjZiZ3Fu?=
 =?utf-8?B?cEtyZGVoM1ZjR0VUelN3R2lRSitIRFArTjUxUDhnR1hjOTJWd2VmSHVxSXlB?=
 =?utf-8?B?cFdROFBVU0RoaDFtaElBNE9UdHQxME5ZZmZQQlhaQ1ZIMGdJOFRnTCtZT0pp?=
 =?utf-8?B?aEZycTY0T1gzdGttQmFhMkFuaXEzRkxXc3luNHZmVzNyeHh2SmNLZTJqSnFR?=
 =?utf-8?B?aGtpWkJZRm9tU3JlQnVGak9kcU9ZUng1YkhWSGRPTWJ5QWlRTGRYUW50OFJp?=
 =?utf-8?B?a0FxYm5UTTNvVmh5NjMwQ1A2b0hXd0dDeFhaaXRlRm92UTJ1ajVKcmN6T2Z3?=
 =?utf-8?B?Z2FaaGpYNXVjelg5Q0hBYkJJS0NNKzRobm5kekM2QzZJVi9rWWdzcFZQdSsx?=
 =?utf-8?B?RkloMkE3S3ZqMUQ1bG9ibnJqOEZCaGlQK2FzVmJiMzBGcVdkMVZrSGJBZkpi?=
 =?utf-8?B?bVZDWFQwclMyTVJ1QWdNbU1QSHltdXhOV3Q5Ym5BUUtKUTAxQ2RIOG0vSFR0?=
 =?utf-8?B?WTVXVkt2NFYzencwOGRmYmdRUm9FZEhOdlhEeE5wNWY0RTM4cXYrOFh1MW1R?=
 =?utf-8?B?R1Q1aWxVbnE2Zk1uV3d0eVlJcTJmSDM2cllBT3dyYThRVTBnYmVKaWhieThw?=
 =?utf-8?B?S2g3QnR5TWdhKy91N3h5TWFRSFdoWmpDeDBUMXRnU1NxSy9KdE9haEJIZGFn?=
 =?utf-8?B?TWpOenIvbDBNQTkwUE5jYkJ4R1RTNDVkUkxPTUljK1dsZXdZZzJnWnBOTVpZ?=
 =?utf-8?B?VCtVYXFVWFE2SVJScHNWd01kOTZqSlVheCtsMGpiZDIzVW1rdmROWWJvS1lw?=
 =?utf-8?B?aHNvdGFLZWFQQjg2cFdQdjhZNUhQK0llZ1Z0YUc0bkZwMWJOZlk5N2FUNWpY?=
 =?utf-8?B?VmFMVXl1OUFyd1FzaFd4OUdHa0FwSnVXeHpHV3hhbDFJemhZc3NJelYwc2x4?=
 =?utf-8?B?dGVJYXgvMU1oYWt1bUFFaW04U2lxYmZueHhZaG0rSjJjY1p5L0RkUHN2UnFT?=
 =?utf-8?B?NDBUcUpKQytPVTFUS2hHWGpnRnAvRGcra21URXAwamhka0M4VlplaXFtVnNs?=
 =?utf-8?B?ME5oeEdIbVBUR01WWWI1YStnNkJxNEFKS2Z4SG4xTXdmSlVwWjJSc2ZMOWVs?=
 =?utf-8?B?NElSWjlWVk1FcHV0SFhuWGNwbzY0QVVHRFRUZkhpeVBYdTBEZnYxTUdES2dB?=
 =?utf-8?B?SWVlalFyY1FKVkZrVUVvU21LUTVnZzZzdGVXa1VOK3BFMmFhMFBDei9pR1ZM?=
 =?utf-8?B?RlQvaXNvaEZTRkZBUVNiVDFmKy9QV3JhWlNiM3ZpWnRWendvQlZSdkNwNERh?=
 =?utf-8?B?bHZzOU1KMGs1K0xGN0JpL29kcUtpMHFLSWRXbDlMRkkwSWJaNnpZWlVsb3l6?=
 =?utf-8?B?Vlo1alFDbTRxTHcxQTUxV0ttRkRRcVVJOFRYRzMvQ2g3bFAvOW5rTkh2T3VL?=
 =?utf-8?B?ZnVzSThRMm82NlZyb09OSWVINWtLLzJRRDQyUEVNbUprekZ3VU9aRGtZeEUy?=
 =?utf-8?B?K1RpWlFkY1ZIQTh6ZlhZeU1nT1gxbTc0eFkwTUVrcDlmZHU5ZUhoZUNiVHdu?=
 =?utf-8?B?MVNJUUpSQXdhallmb0xMb2k0OUI3N29HM2ZTalprSHRyTlhlOCthdTIvMFdD?=
 =?utf-8?B?aXF6VW94TkNua3k3V0ljbEJBSjFsMGtJZGZNc1RidG5zSDN4NUNjME9Xak5C?=
 =?utf-8?B?OC9ZMlBaU01lV1ltNzJ2MW8wK1Z0eVM1WXh2TXpLMHkyRmU4YjdDdHVJbHpX?=
 =?utf-8?B?M0dpOEJqSUw5MlkrSW8zWEtFZzFaaEkxNFl3Q3BTUU1JWjJyQXdxQk1GNFdo?=
 =?utf-8?B?c2Y0aUpxNGtlZDl0UHdYRHJ0OXRacmdnMytxRmcxUS9OT0JPOSthZ21rNVpw?=
 =?utf-8?B?ZGFtV3FzeWdWTG1JNkFMNysxN0lkaTZEdE5QRlNIRzRsR3JnWW84TmFHQlpB?=
 =?utf-8?B?TkJ4RzI1TEdzWU80V0M4ekdKS3NVRjdZeFIyVXBpYktRaEtvSytjSSsxUUVk?=
 =?utf-8?B?T2hGazNiQ1V1TmV5RXNrRGRDSFF1a252SzJweVZuK3BoLzN4ZzFlVkFXaTU0?=
 =?utf-8?B?V0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f258f2cd-a9df-43c4-65d9-08db0e9bdd62
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 14:58:00.1552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7uazZxuOzcA//xbrqZhiEaZhnjxHjfXH2TRtbq+eiW0zL4yk8oetJbb1BwdLT40VhDIuyjz+uTOoNadlbPe0kfpz9NChjuNkQXtDWP3EHME=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5034
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gavin Li <gavinl@nvidia.com>
Date: Tue, 14 Feb 2023 15:41:35 +0200

> vxlan_build_gbp_hdr will be used by other modules to build gbp option in
> vxlan header according to gbp flags.

(not sure if it's okay to write abbreviations with non-capital)

> 
> Change-Id: I10d8dd31d6048e1fcd08cd76ee3bcd3029053552
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> Reviewed-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Maor Dickman <maord@nvidia.com>
> Acked-by: Saeed Mahameed <saeedm@nvidia.com>

Besides the nit above:

Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>

> ---
>  drivers/net/vxlan/vxlan_core.c | 20 --------------------
>  include/net/vxlan.h            | 20 ++++++++++++++++++++
>  2 files changed, 20 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index b1b179effe2a..bd44467a5a39 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -2140,26 +2140,6 @@ static bool route_shortcircuit(struct net_device *dev, struct sk_buff *skb)
>  	return false;
>  }
>  
> -static void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
> -				struct vxlan_metadata *md)
> -{
> -	struct vxlanhdr_gbp *gbp;
> -
> -	if (!md->gbp)
> -		return;
> -
> -	gbp = (struct vxlanhdr_gbp *)vxh;
> -	vxh->vx_flags |= VXLAN_HF_GBP;
> -
> -	if (md->gbp & VXLAN_GBP_DONT_LEARN)
> -		gbp->dont_learn = 1;
> -
> -	if (md->gbp & VXLAN_GBP_POLICY_APPLIED)
> -		gbp->policy_applied = 1;
> -
> -	gbp->policy_id = htons(md->gbp & VXLAN_GBP_ID_MASK);
> -}
> -
>  static int vxlan_build_gpe_hdr(struct vxlanhdr *vxh, u32 vxflags,
>  			       __be16 protocol)
>  {
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index bca5b01af247..08bc762a7e94 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -566,4 +566,24 @@ static inline bool vxlan_fdb_nh_path_select(struct nexthop *nh,
>  	return true;
>  }
>  
> +static inline void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
> +				       struct vxlan_metadata *md)
> +{
> +	struct vxlanhdr_gbp *gbp;
> +
> +	if (!md->gbp)
> +		return;
> +
> +	gbp = (struct vxlanhdr_gbp *)vxh;
> +	vxh->vx_flags |= VXLAN_HF_GBP;
> +
> +	if (md->gbp & VXLAN_GBP_DONT_LEARN)
> +		gbp->dont_learn = 1;
> +
> +	if (md->gbp & VXLAN_GBP_POLICY_APPLIED)
> +		gbp->policy_applied = 1;
> +
> +	gbp->policy_id = htons(md->gbp & VXLAN_GBP_ID_MASK);
> +}
> +
>  #endif

Thanks,
Olek