Date:   Tue, 14 Feb 2023 15:04:35 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Borislav Petkov <bp@alien8.de>, Tom Rix <trix@redhat.com>,
        tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
        rric@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized
 clang false positive
Message-ID: <Y+ujA+Kr05Adky1l@yaz-fattaah>
References: <20230213191510.2237360-1-trix@redhat.com>
 <Y+qZthCMRL1m0p4B@yaz-fattaah>
 <Y+qcU2M5gchfzbky@zn.tnic>
 <Y+qdVHidnrrKvxiD@dev-arch.thelio-3990X>
 <03b91ce8-c6d0-63e7-561c-8cada0ece2fe@redhat.com>
 <Y+q1mhrAKTobp3fa@yaz-fattaah>
 <Y+q2pXYI02qAje8N@dev-arch.thelio-3990X>
 <Y+tapzerW7h9vMvp@zn.tnic>
 <Y+ubhHlWFv4ifmGn@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+ubhHlWFv4ifmGn@dev-arch.thelio-3990X>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8nDUepJ1XQbDBx95UzeVcZsKq7PDtTQxA0eD9QSnmWJ+wpSjHvnBqtVT/Oob?=
 =?us-ascii?Q?zTK41SqQLmliUtPxTQqr+WoJOKcranVKqeKnNA8S3ujOUEk8n/BlPwmJcfJj?=
 =?us-ascii?Q?0u9HZ6V90h/40++utkZHFhvCFttpE8XMZ2S0k84bgKOPyM/tF36mGbp4idVo?=
 =?us-ascii?Q?0FGIdenKKpQd+ZhHgqGg8UkeLMrp1v1zyY0ds1LFMo/Z2nJx3+MeyiYIN71u?=
 =?us-ascii?Q?nK6fJUC2GQsOuf4705uPWEDIGFLthccms14W92GCcaWvEeUVH2lCIfA/zsz3?=
 =?us-ascii?Q?SEYgq8LifI837n16NmTyKNqp/piDM9OlNdreipfQILbCIJhRsvqzs42XsjRT?=
 =?us-ascii?Q?R3xZMDujm5cloc42BQwy3SHWQtygvPZTyELGF9qogsQtXDjbkUtE4eUgs+Zw?=
 =?us-ascii?Q?VDnaJIJrxLB4QROgrOpEqSkHn1tOU3SK/iNbRuqiHlD9M8tmjqrR15dULBJp?=
 =?us-ascii?Q?yahuIW8QO1i25BWCSbJa3JY7+6HEoB7hQwBVyGaKUog8ylVcuYMdA88MWmnV?=
 =?us-ascii?Q?P4jxoTjgZ/HWnNg22SEQd+79w8KoScE9ZT3tmCTFHUxEj2x0oUsDBOPSrTV+?=
 =?us-ascii?Q?caboTRQ9+eu1ULbQ/Ghu76F7q40s0VqAITZ4MfJvluUy7chZFxDkrS1nkBH8?=
 =?us-ascii?Q?Qf/sA/A8vKFzPlONZtOTaSzn8GVvDQ7n+aP836JY7eXm/C2diAqb0hcbBSWl?=
 =?us-ascii?Q?I8iy1RbI5/gk3SRpIw1+v7ahptUFCbWr8IzyGjXFLvh9oHYVr8m8MZQ9b1Xn?=
 =?us-ascii?Q?Bmg3o5BT5Df6aPeGruxuo0ZTPeZOm1yecc4qpvG7sSlwXn/u/GvjOae3oNsM?=
 =?us-ascii?Q?ppJS4fGEGRt9x6xx1bQrY4/yGG+7xZ6/hBWuS7lbu07rPLlMN3Ymk70VYm5q?=
 =?us-ascii?Q?CBntbhbFz7kAiWDoyjAEq+r+BDExj/Ir4BPDjnih6Iehg+u5nS83udt+cnWU?=
 =?us-ascii?Q?vJ0cU1GFJiEAqYjtJ+qWhAS2LxxuzCcGspYAlrfEqSWN/dsPKGCm5x9x9dPx?=
 =?us-ascii?Q?SPnH190Wh+fgw+fg7FHOiN+zRKBmPVRNE0clw0cAZqyxwyJdlxuZb2BX8VHA?=
 =?us-ascii?Q?DMMk+72FScD7fTlDlZcKrZlHF+xUWjppS/9VUzRH8Ce/Hn3PvJRdv8nsIylA?=
 =?us-ascii?Q?A2SUXVJLiZLCaN5xxQmCCa2tVuOfb6msgH5Kh9rSZ9fy7A2lWSZZ0WlQvEoH?=
 =?us-ascii?Q?WUcO8doVw0vT4vno/8BzSmLoD/vJ0cS8pWcmDzsR8d7lEy/P5ejyLM4qQ9qF?=
 =?us-ascii?Q?ydEuniH/rg3s9AHi8Vo7V9lVMksm0JJpHYqcKd4IGxo55pg64v8fPLQIio/Q?=
 =?us-ascii?Q?akFSTqi3OjheczQNsaE5Xegl1uEJxNG+kMxWgHEXZJyheHDUEqxFX/h/iW2C?=
 =?us-ascii?Q?mxYRW1yPgX97DMgob7Bh4mpcbJ3I2RBykTdYQ332OSMm5U3y4xFO9aGUVaQE?=
 =?us-ascii?Q?vn2SrNO/IiDfdDsiIRZYvXGe6RO/ORqymJHtPdvotHqAyj7iJhFE40KkXNHg?=
 =?us-ascii?Q?c15O3Bjxpl77MqpjP2H3sB/jIM+JID35oFwtqKpYMwbsTdEe+r4CeM33sT1L?=
 =?us-ascii?Q?EYcFEfW7vtEsoU4JMFkJakO7YD+XUzu4UQjTIKKw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13236e67-14bf-4e03-9555-08db0e9ccd43
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 15:04:42.5908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JoHIDUrSXtW7rk5j2wRYx6bH1/P/1EAexeSsu2MZD/IRjOpt8p9z7x50EfF0Igl7qh9p9Mvxrer9Z9axyyumww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6265
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 14, 2023 at 07:32:36AM -0700, Nathan Chancellor wrote:
> On Tue, Feb 14, 2023 at 10:55:51AM +0100, Borislav Petkov wrote:
> > From: Yazen Ghannam <yazen.ghannam@amd.com>
> > 
> > Yeah, the code's fine even without this.
> > 
> > What this is fixing is a compiler which is overeager to report false
> > positives which then get automatically enabled in -Wall builds and when
> > CONFIG_WERROR is set in allmodconfig builds, the build fails.
> > 
> > It doesn't happen with gcc.
> > 
> > Maybe clang should be more conservative when enabling such warnings
> > under -Wall as, apparently, this has an impact beyond just noisy output.
> 
> For the record, this is the first false positive that I have seen from
> this warning in quite some time. You can flip through our issue tracker
> and see how many instances of the uninitialized warnings there have been
> and the vast majority of the ones in 2022 at least are all true
> positives:
> 
> https://github.com/ClangBuiltLinux/linux/issues?q=label%3A-Wsometimes-uninitialized%2C-Wuninitialized
> 
> So I disagree with the characterization that clang is "overeager to
> report false positives" and I think the opinionated parts of the commit
> message could be replaced with some of the technical analysis that Tom
> and I did to show why this is a false positive but not one clang can
> reason about with the way the code is structured (since the warning does
> not perform interprocedural analysis). However, not my circus, not my
> monkeys, so feel free to ignore all this :)
> 
> Regardless, my review still stands and thank you again for the fix.
>

Thanks Nathan for the feedback and thanks Boris for the patch.

Nathan,
I see there's a ClangBuiltLinux/continuous-integration2 project on github.
Is this something developers should try to leverage? Maybe just fork it and
update the action/workflows to use test branches?

Thanks,
Yazen