From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dan Carpenter <error27@gmail.com>,
        Colin Ian King <colin.i.king@gmail.com>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] nfsd: remove redundant assignment to pointer dentry
Thread-Topic: [PATCH][next] nfsd: remove redundant assignment to pointer
 dentry
Thread-Index: AQHZQH6rVnUd5+nphU2O0AMSQaxqqq7Oh8uAgAAFv4A=
Date:   Tue, 14 Feb 2023 15:16:10 +0000
Message-ID: <A0A239FB-249E-4C50-8276-D6DED71D8C3A@oracle.com>
References: <20230214141428.301121-1-colin.i.king@gmail.com>
 <Y+ug53kWXe5tqZbw@kadam>
In-Reply-To: <Y+ug53kWXe5tqZbw@kadam>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l7lujFxSABhOVl2uVhtyito7AAb8WCldiCbGXOkjTN0hZ6FDxsQ50u1/iM+q?=
 =?us-ascii?Q?+Fh/Gp59C7VxSf3KccIvV/aUUZXC6Cocto2Qia4qrsXEwYryypMgLPkg26BV?=
 =?us-ascii?Q?0EqDeccZMFn45o80WY/CUOQIybwVBOx9YimgEH8k1mr8asvYu+p8CMfCISi3?=
 =?us-ascii?Q?AqE1RjDf8DalwxLL/9pBuvqcMO5aVuI0fgDGM5+ESWFa3HJHkfh7Plo1yStM?=
 =?us-ascii?Q?8za1x3QQMNsz7CXUTQAKvBuXqlFr4mrV57Bej54T76uQwnbesNPnppRoxfO4?=
 =?us-ascii?Q?KTSIPnLihYg0f7TQiW9PY4YgQeV8ZJFq2PCrfOnYUeGtBxaIczijc9/7v9JQ?=
 =?us-ascii?Q?v/l4snosDe4wfKS4qYt+/qwD5tyLLKCB0qpmHtnSVVYF3gdaxIU7VR2jtLmO?=
 =?us-ascii?Q?MqQGshxrkYc9CbyTkF4V9Ia16em92VH7jLlv5czagvfgMkKjJDY+9kYKChUy?=
 =?us-ascii?Q?9vrO044Qg2t7wpqSkG5YNxfSc13c8Yj1KzgS/ykAl2mfEceeWZCSbk3Fyu0I?=
 =?us-ascii?Q?fd08z/E5VVKbXs2wEOd0aqLJfM0YCHQk4n/h7kmYrOaEg2vvwmmjfC4Wd7YA?=
 =?us-ascii?Q?zczOjIuL2IMiwePLjJAWIiMGAz5jLEuSba55VUNHEb0Tg5N5L/nFXN9DB9E8?=
 =?us-ascii?Q?9+DNFVRrlc8Ww8zUvoLjG3lUbwHbMb7XjbM8F7clZAKwK3YMHYAoIcm6IawO?=
 =?us-ascii?Q?2jB43W8M0EsIgh3mdVeWSTXy4kGUzmr7+6/u2RS77tAnJfz232F6+VIPzi3O?=
 =?us-ascii?Q?Fmnt9bO2CyfcXMbvHYazZLBjAZv+JcvhnpKGqWrhZ/DjRuczcxNVoa6UyRRV?=
 =?us-ascii?Q?zYnhF3rDe91h6aKv0KbxOlLYg41s7fuNxDLLhLdRorOOGSXZsTlIfKZol2rf?=
 =?us-ascii?Q?Z2vHKRFDZSlb/i0V0GP+a4nd1DbIZMEYFIvGyf+/Xqlh7w0sXTz5q3S0N0N1?=
 =?us-ascii?Q?WBra93zptwX3d3pSAXzh/sHLWi2xZqTv6mAAsg4U8TeltTJHrNcz80nCqWSp?=
 =?us-ascii?Q?N3tJVV8x/2lG4BoeuWb/QRowLZ5pVxIXd/b48AH2iV6x9qf2SJQ2JoZFQIoG?=
 =?us-ascii?Q?c+TwsHfzNpkNVSuxRGk2NFIR+JWTU0GgES81nXR15ocHRYCz9VvveH8ITtUV?=
 =?us-ascii?Q?b7HKPn/xn6zS884ovWleePECpEZIS9LhMx8+83kyipYksXGSbHwaEtdGWVVM?=
 =?us-ascii?Q?MdPQM5I9CKuCYN8dC05Dw8pSszEh5rFgrkDu7rsPn6CUS+cHU2mOBTqQIvm4?=
 =?us-ascii?Q?olEC4Npn4IcCIOO3lpWtYkYplHxEmz8Ysl8J7SM9focTiAE8RJj6jhlMKg/n?=
 =?us-ascii?Q?sHzgZSfx6/LX7sB1N0gSe14h4+YY/xjMf+veBxfnEmOnXZ6VuXreHGAooyCn?=
 =?us-ascii?Q?5vNoYY+Jpihe+JnT667vb8sQ7Iw3s09iAnHfIAtonDfGvwEdjbeWlyGaUFCU?=
 =?us-ascii?Q?vlAz/PC7qeA0IBRgqw61ROW2w5RnrWqIH5SC0bk6T4curntwZbHZcfLdcawE?=
 =?us-ascii?Q?DQFPrd1YbluKSQii0WprvQU+4p8KnzyStAaXjHiLUBlHP7k4oUBEv3otAyMc?=
 =?us-ascii?Q?IywSZscW9eUE1YwcFAGVKl22o5NHWWW0WeW9RD8xWL6Wl7SPFSG00JWS5J5k?=
 =?us-ascii?Q?dw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <615A10DD7EF97B4F8FF91A5D7BC7E93E@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: J9DZF/BIQ1AxLeboX7PJbHmiNLRC5voGrcTRpEfFnZtVq/4AWyqikfGVvPOm4Wq9CxPHXdVBC7HHL72ZD+IOsJ0Ggb2uDp3ymXnoaeTzSvEX2crx2Tji1zE8IqJZgZzjFYrg6KTPgT6RS3zv7fqCkaVjmW7AvzXxyzmLWoLPcnnFNC6HXnvfHqDyHX1MpxvSt7+x3xeS+DHtVTvaprhGFTW6/7UH+CtVfjq46bmZgndzfZbwnBAr8Fuk3luYaVlya3N0qXEJQc2JNunzs39EcxnknpXND9fCJxaSze2kyLb/8hTHSyZ0TMN0tkuUkBBDxS9ij26/U+A0b8MSHqKooN75AqyiBUOOr4qoXpvmALDuCDPchvZaAm6em3NgrVLSX04R8aN1In4XU+79zBxmd3s/ofe46BvXTO21c0jbmGGvglqZN0knMfUgE4KdpwGP/3hUN5ZNivYyXR/a5psglICdlk88m9bJeEdX47+5QgyAfiq6wyy+lNRndGqFGP2tlOzKExnXuNwmy8wXe/920vn4lpdLovYlnXG8iqmvOdgiwV/Snn+MmOdqaL1UWBHFs+B0yH7BnsJiXgTp7zsZcW+wZWE5zOa9FFd5ny5A9NIxBZBDd5bwrkO1Qj7oWWpUCXKxTRjTgvbMOwa1chISxz8dz8E+5pqReBKmucgLJG69+0M2kPQhjQAtiB472LUGykSbIr+t1ejn08xcoT/Bk5Mak4z77slKebHTvm1mKvsYjTsF+Y/zo0hlaEoaQOGuZb+Vxzb0Vr8IONMUmp1yyoPsZmh7j31BnYqDuQHAh0p3bo1iUsMkt6SFs1uTtdc8
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba4a8bd0-1082-4639-11ab-08db0e9e6747
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2023 15:16:10.3077
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4BYNoX64td3poYnaGKbWoM/LdYCTdLEHBsXOq8te1zvUMUil96PYl3vScr+0LV1yenHalGvNH41N2ojNuu5A0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5175
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-14_10,2023-02-14_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=732 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302140131
X-Proofpoint-GUID: ec6yX5V8dipmM2gk0ZAXA4BPfLQwfyYV
X-Proofpoint-ORIG-GUID: ec6yX5V8dipmM2gk0ZAXA4BPfLQwfyYV
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 14, 2023, at 9:55 AM, Dan Carpenter <error27@gmail.com> wrote:
>=20
> On Tue, Feb 14, 2023 at 02:14:28PM +0000, Colin Ian King wrote:
>> The pointer dentry is assigned a value that is never read, the
>> assignment is redundant and can be removed.
>>=20
>> Cleans up clang-scan warning:
>> fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is
>> never read [deadcode.DeadStores]
>>        dentry =3D ERR_PTR(ret);
>>=20
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>=20
> No need to initalized "int ret =3D -ENOMEM;" either.

Thanks for the report.

Both came in when I copied nfsd_mkdir. I'll clean them up.


--
Chuck Lever