Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
From:   Rob Herring <robh@kernel.org>
To:     Shradha Todi <shradha.t@samsung.com>
Cc:     pankaj.dubey@samsung.com, linux-pci@vger.kernel.org,
        jingoohan1@gmail.com, jh80.chung@samsung.co,
        linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, hongxing.zhu@nxp.com,
        alim.akhtar@samsung.com, bhelgaas@google.com,
        krzysztof.kozlowski+dt@linaro.org, m.szyprowski@samsung.com,
        kw@linux.com, devicetree@vger.kernel.org,
        Sergey.Semin@baikalelectronics.ru,
        linux-samsung-soc@vger.kernel.org, lukas.bulwahn@gmail.com,
        lpieralisi@kernel.org
In-Reply-To: <20230214121333.1837-11-shradha.t@samsung.com>
References: <20230214121333.1837-1-shradha.t@samsung.com>
 <CGME20230214121444epcas5p16c5f7665fc9dee78cd427d976114e4f1@epcas5p1.samsung.com>
 <20230214121333.1837-11-shradha.t@samsung.com>
Message-Id: <167638945319.3745.5262086066044660323.robh@kernel.org>
Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required
 property
Date:   Tue, 14 Feb 2023 10:12:34 -0600
Precedence: bulk


On Tue, 14 Feb 2023 17:43:27 +0530, Shradha Todi wrote:
> To replace devm_of_phy_get with devm_phy_get to get the
> PHY pointer using non DT version, we need to add phy-names
> property in DT and make it a required property with const
> value.
> 
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> ---
>  Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.example.dtb: pcie@15700000: 'phy-names' is a required property
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/samsung,exynos-pcie.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230214121333.1837-11-shradha.t@samsung.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.