Message-ID: <faaecb6c-4710-d26d-b992-388ae29907f7@quicinc.com>
Date:   Tue, 14 Feb 2023 21:49:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH V2] clk: qcom: ipq5332: mark GPLL4 as critical temporarily
To:     Stephen Boyd <sboyd@kernel.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <mturquette@baylibre.com>
CC:     <quic_varada@quicinc.com>, <quic_srichara@quicinc.com>
References: <20230206073101.14796-1-quic_kathirav@quicinc.com>
 <6fa247b53740ca760a608e1446f95c95.sboyd@kernel.org>
Content-Language: en-US
From:   Kathiravan T <quic_kathirav@quicinc.com>
In-Reply-To: <6fa247b53740ca760a608e1446f95c95.sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/11/2023 3:44 AM, Stephen Boyd wrote:
> Quoting Kathiravan T (2023-02-05 23:31:01)
>> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
>> index c8a5fa1bafca..2e043d2d0598 100644
>> --- a/drivers/clk/qcom/gcc-ipq5332.c
>> +++ b/drivers/clk/qcom/gcc-ipq5332.c
>> @@ -127,6 +127,16 @@ static struct clk_alpha_pll gpll4_main = {
>>                          .parent_data = &gcc_parent_data_xo,
>>                          .num_parents = 1,
>>                          .ops = &clk_alpha_pll_stromer_ops,
>> +                       /*
>> +                        * There are no consumers for this GPLL in kernel yet,
>> +                        * (will be added soon), so the clock framework
>> +                        * disables this source. But some of the clocks
>> +                        * initialized by boot loaders uses this source. So we
>> +                        * need to keep this clock ON. Add the CRITICAL flag
>> +                        * so the clock will not be disabled. Once the consumer
>> +                        * in kernel is added, we can get rid off this flag.
> s/off/of/
>
> Does CLK_IGNORE_UNUSED work the same? It doesn't sound like a critical
> clk from the description of the comment.


Sorry, somehow I missed this response. Will update to CLK_IGNORE_UNUSED 
in V3.


>> +                        */
>> +                       .flags = CLK_IS_CRITICAL,
>>                  },
>>          },