Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D05C6379F for ; Tue, 14 Feb 2023 16:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjBNQhY (ORCPT ); Tue, 14 Feb 2023 11:37:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbjBNQhT (ORCPT ); Tue, 14 Feb 2023 11:37:19 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62B9D2BF2A for ; Tue, 14 Feb 2023 08:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676392582; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KFACX1G5R1lrRlAY7oUxw5aaMyGQvkT6aAKErJogHLY=; b=Ch0tRaPY4NU8gwMGPeEruPfeD9vdfrXlpUnOau0AqLno9JfC4jFL3Aww84yO1m/bYq4qeg 8knGx12rg+1f47D2vS4/HtpaoFKMij1w5IseIhWOBmIW1KdpzcdkrVsE88T5J0hvxJx9pQ fzIaBaju0yiqY8BAb6VQuEqMoqfLmdo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-279-apJ7pUDiNeqQKMI599MErA-1; Tue, 14 Feb 2023 11:36:19 -0500 X-MC-Unique: apJ7pUDiNeqQKMI599MErA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B11052806064; Tue, 14 Feb 2023 16:36:17 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 732D82026D68; Tue, 14 Feb 2023 16:36:13 +0000 (UTC) Date: Tue, 14 Feb 2023 16:36:10 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, "Jason A. Donenfeld" , x86@kernel.org, linux-kernel@vger.kernel.org, Dov Murik , Tom Lendacky , Gerd Hoffmann , Paolo Bonzini , Richard Henderson , "H . Peter Anvin" , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Nathan Chancellor , Borislav Petkov , Eric Biggers , Sergio Lopez , Marcel Apfelbaum , Eduardo Habkost Subject: Re: [PATCH RFC 1/7] Revert "x86: don't let decompressed kernel image clobber setup_data" Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20230208211212.41951-1-mst@redhat.com> <20230208211212.41951-2-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230208211212.41951-2-mst@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2023 at 04:12:27PM -0500, Michael S. Tsirkin wrote: > This reverts commit eac7a7791bb6d719233deed750034042318ffd56. > > Fixes: eac7a7791b ("x86: don't let decompressed kernel image clobber setup_data") > Signed-off-by: Michael S. Tsirkin > --- > include/hw/i386/microvm.h | 5 ++-- > include/hw/nvram/fw_cfg.h | 9 ------- > hw/i386/microvm.c | 15 ++++------- > hw/i386/x86.c | 52 ++++++++++++++++++--------------------- > hw/nvram/fw_cfg.c | 9 ------- > 5 files changed, 31 insertions(+), 59 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|