Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E57C05027 for ; Tue, 14 Feb 2023 16:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232443AbjBNQj5 (ORCPT ); Tue, 14 Feb 2023 11:39:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbjBNQja (ORCPT ); Tue, 14 Feb 2023 11:39:30 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 540B02C67E; Tue, 14 Feb 2023 08:38:57 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id ACED71EC072E; Tue, 14 Feb 2023 17:38:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1676392735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=jN+gT+FJIz779Sj865bJgIneG1lAlFolCGrR66aWtEk=; b=NL2wkTCtLcfwDipURL4tDYqN5u+XawepQ8kgZ3RzxFPFJI4U3JkhBUdm0o77ppAXKNeL4f vb/K/2iNIyxAyWzgLfT3zQ4qu9Iotetq/xqmU3S5lopqoqhW042FR/OrLE8JNynN8057qj fYhAUDdGnSLR4tBsfdSKjn/MmKiK0JE= Date: Tue, 14 Feb 2023 17:38:51 +0100 From: Borislav Petkov To: Nathan Chancellor Cc: Yazen Ghannam , Tom Rix , tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] EDAC/amd64: Shut up an -Werror,-Wsometimes-uninitialized clang false positive Message-ID: References: <20230213191510.2237360-1-trix@redhat.com> <03b91ce8-c6d0-63e7-561c-8cada0ece2fe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2023 at 07:32:36AM -0700, Nathan Chancellor wrote: > So I disagree with the characterization that clang is "overeager to > report false positives" and I think the opinionated parts of the commit > message could be replaced with some of the technical analysis that Tom > and I did to show why this is a false positive but not one clang can > reason about with the way the code is structured (since the warning does > not perform interprocedural analysis). I'm sure you can create all kinds of cases like this one if interprocedural analysis or aggressive inlining doesn't happen. So I'm rather surprised that this is the first false positive to happen. But whateva. And since we're disagreeing with things: I don't mind if this is a false positive - I don't care. What I don't agree with is having -Werror fail the build because of it and forcing us to "wag the dog", so to speak. And you can imagine that this has been happening for a while now. And it can explain my reaction to yet another compiler fix. But ok, we've wasted enough time on this, lemme tone down the commit message and commit it. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette