Date:   Tue, 14 Feb 2023 11:41:56 -0500
From:   Stefan Hajnoczi <stefanha@redhat.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Zheng Wang <zyytlz.wz@163.com>, hackerzheng666@gmail.com,
        jasowang@redhat.com, pbonzini@redhat.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com,
        virtualization@lists.linux-foundation.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        security@kernel.org, alex000young@gmail.com
Subject: Re: [PATCH v2] scsi: virtio_scsi: Fix poential NULL pointer
 dereference in  virtscsi_rescan_hotunplug
Message-ID: <Y+u51GN1uf3i0A4+@fedora>
References: <20230202064124.22277-1-zyytlz.wz@163.com>
 <20230213070906-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="8UxNTXH0/J1RCIqe"
Content-Disposition: inline
In-Reply-To: <20230213070906-mutt-send-email-mst@kernel.org>
Precedence: bulk


--8UxNTXH0/J1RCIqe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 13, 2023 at 07:09:50AM -0500, Michael S. Tsirkin wrote:
> On Thu, Feb 02, 2023 at 02:41:24PM +0800, Zheng Wang wrote:
> > There is no check about the return value of kmalloc in
> > virtscsi_rescan_hotunplug. Add the check to avoid use
> > of null pointer 'inq_result' in case of the failure
> > of kmalloc.
> >=20
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> > ---
>=20
> I fixed a typo in subject and tweaked the patch a bit

Thanks for picking this patch up.
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?h=3Dl=
inux-next&id=3D4a8fc6e3ac68ce4c355d1f4473ef1d8468b23bdc

Stefan

--8UxNTXH0/J1RCIqe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmPrudQACgkQnKSrs4Gr
c8gR5QgAyX3SyeEgLJ/OpK4aeXYNWXfpZcmtdCK3YtTy7c7C16RA7vFll5zv1CpI
z2+qqNf1KeDsrntla046kqeNVgASEKEorQJm9chEw1emaLFyOvzLBCXNd7wvfso3
ix4l6Ua7dM9nm5Rrf6j6zBs9PcdEGtb/llC5m8RR0GFX8iO+izOk1hVG3DmPDOsQ
rK3ZETdRiLAE51MVYNHT+XKR545IK5R9JMhRUzhKEqdR0cMePk0ZPoNKtU2wAzlf
9tiJGw2oiebN9ZHbnpXrulA74v9VQmhKqH/KGv20WkXRL9/QutViOECSBHJGuACf
MFd+kMz4hzdbv50rWM4ksYjDFz45zw==
=SFCg
-----END PGP SIGNATURE-----

--8UxNTXH0/J1RCIqe--