Message-ID: <f8f3e8df-f707-28f3-ab0f-eec21686c940@infradead.org>
Date:   Tue, 14 Feb 2023 08:44:02 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] fixed typos on selftests/bpf
Content-Language: en-US
To:     Taichi Nishimura <awkrail01@gmail.com>, shuah@kernel.org,
        andrii@kernel.org, mykolal@fb.com, ast@kernel.org,
        daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        davem@davemloft.net, kuba@kernel.org, hawk@kernel.org,
        nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com,
        ytcoode@gmail.com, deso@posteo.net, joannelkoong@gmail.com
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, llvm@lists.linux.dev
References: <20230214152850.389392-1-awkrail01@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230214152850.389392-1-awkrail01@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 2/14/23 07:28, Taichi Nishimura wrote:
> I run spell checker and found typos in selftest/bpf/ files.
> Fixed all of the detected typos.
> 
> This patch is an extra credit for kselftest task
> in the Linux kernel bug fixing spring unpaid 2023.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c    | 2 +-
>  tools/testing/selftests/bpf/prog_tests/trampoline_count.c     | 2 +-
>  tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
>  tools/testing/selftests/bpf/progs/dynptr_fail.c               | 2 +-
>  tools/testing/selftests/bpf/progs/strobemeta.h                | 2 +-
>  tools/testing/selftests/bpf/progs/test_cls_redirect.c         | 4 ++--
>  tools/testing/selftests/bpf/progs/test_subprogs.c             | 2 +-
>  tools/testing/selftests/bpf/progs/test_xdp_vlan.c             | 2 +-
>  tools/testing/selftests/bpf/test_cpp.cpp                      | 2 +-
>  tools/testing/selftests/bpf/veristat.c                        | 4 ++--
>  10 files changed, 12 insertions(+), 12 deletions(-)
> 

Issues here:

> @@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>   *
>   *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>   *
> - * clang will substitue a costant for sizeof, which allows the verifier
> + * clang will substitute a costant for sizeof, which allows the verifier

                              constant

>   * to track it's value. Based on this, it can figure out the constant

               its value.

>   * return value, and calling code works while still being "generic" to
>   * IPv4 and IPv6.

The other changes look good. Thanks.

After fixing the issues above:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>


-- 
~Randy