MIME-Version: 1.0
References: <20230214125949.3462396-1-alexander.stein@ew.tq-group.com> <CAHp75Vf0u_F4bFs-1hyckG7h-7r3XqxdZc_6EjuWxTxbfMPMjQ@mail.gmail.com>
In-Reply-To: <CAHp75Vf0u_F4bFs-1hyckG7h-7r3XqxdZc_6EjuWxTxbfMPMjQ@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 14 Feb 2023 18:48:11 +0200
Message-ID: <CAHp75VdLuDmaBRr0X_==zKxAN5mkxDZV4MMywo7bETaFCvmASg@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] gpio: vf610: make irq_chip immutable
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 14, 2023 at 6:45 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Feb 14, 2023 at 2:59 PM Alexander Stein
> <alexander.stein@ew.tq-group.com> wrote:

...

> >         void __iomem *pcr_base = port->base + PORT_PCR(d->hwirq);
>
> Now you can use gpio_num here...
>
> > +       irq_hw_number_t gpio_num = irqd_to_hwirq(d);

...

> >  static void vf610_gpio_irq_unmask(struct irq_data *d)
> >  {
> > -       struct vf610_gpio_port *port =
> > -               gpiochip_get_data(irq_data_get_irq_chip_data(d));
> > +       struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
> > +       struct vf610_gpio_port *port = gpiochip_get_data(gc);
> >         void __iomem *pcr_base = port->base + PORT_PCR(d->hwirq);

And here.

> > +       irq_hw_number_t gpio_num = irqd_to_hwirq(d);
> >
> > +       gpiochip_enable_irq(gc, gpio_num);
> >         vf610_gpio_writel(port->irqc[d->hwirq] << PORT_PCR_IRQC_OFFSET,
>
> ...and here.
>
> >                           pcr_base);
> >  }

-- 
With Best Regards,
Andy Shevchenko