Message-ID: <2e17b8f6-0c2d-e705-63b9-47077b442d68@infradead.org>
Date:   Tue, 14 Feb 2023 08:52:04 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory
Content-Language: en-US
To:     =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>,
        linux-kernel@vger.kernel.org
Cc:     Song Liu <song@kernel.org>, Luis Chamberlain <mcgrof@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org
References: <20230214005400.17137-1-rdunlap@infradead.org>
 <59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/13/23 23:22, Philippe Mathieu-Daudé wrote:
> Hi Randy,
> 
> On 14/2/23 01:54, Randy Dunlap wrote:
>> Correct the struct's field/member name from mod_mem to mem.
>>
>> Fixes this build error:
>> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
>> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
>>    643 |         v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>>
>> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
> 
> On which tree is your patch based?

linux-next-20230213.

> fatal: ambiguous argument '2ece476a2346': unknown revision or path not in the working tree.
> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Song Liu <song@kernel.org>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
>> Cc: linux-mips@vger.kernel.org
>> ---
>> Has this already been fixed?
>>
>>   arch/mips/kernel/vpe.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
>> --- a/arch/mips/kernel/vpe.c
>> +++ b/arch/mips/kernel/vpe.c
>> @@ -640,7 +640,7 @@ static int vpe_elfload(struct vpe *v)
>>           layout_sections(&mod, hdr, sechdrs, secstrings);
>>       }
>>   -    v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
>> +    v->load_addr = alloc_progmem(mod.mem[MOD_TEXT].size);
>>       if (!v->load_addr)
>>           return -ENOMEM;
>>   
> 

-- 
~Randy