Message-ID: <14087d49-1d21-afa7-601f-f43a90665052@intel.com>
Date:   Tue, 14 Feb 2023 09:01:36 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH 2/4] selftests/resctrl: Don't hard code divisor in MBM
 results
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20230208094026.22529-1-ilpo.jarvinen@linux.intel.com>
 <20230208094026.22529-3-ilpo.jarvinen@linux.intel.com>
 <8ed0dcbd-86af-2658-95de-fdccffba7728@intel.com>
 <346283c6-b5a5-ad35-7a90-fd17858be46f@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <346283c6-b5a5-ad35-7a90-fd17858be46f@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dis1ZWhHTzBSQTJCQmllak1nSkxseW9YMUtQNUVJdEFqYWQ5a2NRbzBPNXF6?=
 =?utf-8?B?WHhjeHgwWklxdSszaGRka1NueUVRVHU4ZlpTNHQ2OXMzeVc3dktPUGc0UUJz?=
 =?utf-8?B?eDMvTGdIbGNvK1FoTFZqc2VPNkxtV2lvNlNEUWgzTjdJbEdVSTNUc3V3bzho?=
 =?utf-8?B?SnE2TG5sOVFXTkpuakpaSEpTSG0wMGhKMzVXVFVPclA4S284WE9vRHpzM0ZT?=
 =?utf-8?B?NFkzRGNuRmpDVWE3M3dYKzkySzJ1Sm05dmtyd0p0TUV4c2pVSFVPSHBzYmw3?=
 =?utf-8?B?ZVIrY1J4K1JaNGlXOG1uYVlKUllIT0V2WnJaSGVTZ3ErZFJQdDM5bTVsWCsx?=
 =?utf-8?B?c3laaTVvZE9FMkhyOUR6NjNPUHI5UHdlUHQ2RFNidU1TendhMjBFajd4UkJ4?=
 =?utf-8?B?QkE2akt4NFhiNXI4U090UHp6d1I2SFJ5VjZ3a0tIWHdCa0VBeXNqQkxhTVlq?=
 =?utf-8?B?MnF0UGM2aEZMaENBWjYvSURWeVM0V2cwWnhDUFBVQWZzblJlUXlyRjVhLy9w?=
 =?utf-8?B?SVdXRlR0VVowbElRbFZ3dzdIL0RPV3ovKzVwZGZWa0l4b3NJZWo2aFc3U0hZ?=
 =?utf-8?B?Y2o3NnB1S25TK3d3UmpuTHhMSWFNMzNsMnU2RU5oK25JQy9WSGRXQm5VSDJZ?=
 =?utf-8?B?cStFN3lGZ1A0VU93UG95cmY4aUd5dStlWDNTb2hjYUo0cXNBNHNkMkwvZzBn?=
 =?utf-8?B?SExUMlhONWdwTURsdWFFTkVReGI5SnNFUVMvYmYyemVpeGRmV212a1QzaVgv?=
 =?utf-8?B?K1JuS3NvcWVUTnArNXRHcmd5UDVEZUhpaFVpOXNaNlo5a0JOWnN5L2wxRmlT?=
 =?utf-8?B?M0l1Z1JqSkJac1YzVFJoL3g5cndoZFk4NXJocW5zNkdCYWtxb01nT0t2Rndv?=
 =?utf-8?B?REZodGI5VVM5TFdXYkhyT0RlNEphaU1iNWNML3A1eGNraDdXOVFiTU9mVjhz?=
 =?utf-8?B?UTBSdjNHQWMvOXg0R25WM2FHZjVYMWVsQXhSbGl1cFRKUXNFK3ZMUC83ZEtm?=
 =?utf-8?B?RkdBRlhwL05qdlh0RCt6ZzBCblVyelQ2aWJxMGtJR29XSEtjUHVxbUE1cWM5?=
 =?utf-8?B?QjVSKzJvL2c5U0puQnk5ZDBvZUVYdWd4Ynd3VmpyUFMzZ2VZRXM4SVNFeVJX?=
 =?utf-8?B?c282ZmxzRDgrMHBiYzB2RXpXRVJOSTErSUpJbGZ4U09LZVlSYU4rdmVjYTVH?=
 =?utf-8?B?UEJla1VRZnpBcW1nRnVoS3hWRFU3amozYTlML2JrQjFCckdVa2k0NU45SFZH?=
 =?utf-8?B?dm1SWDIzYkI2SEJMcTR2V2hZeGJNSzRuSy9YcDJoSUI4QjBJanMvRmNadDRN?=
 =?utf-8?B?cEovQXZ1L1kxcWxXTTU2OWdTRFVRUWVWZFNIQzRDMnV5U2ZsSkxta1JqS3pv?=
 =?utf-8?B?ZTJ4dGgzcmM0bmxQUFlOMUw4a2lPZDE0OTVvNjdVUEEwMmlPUVYwWlcyYWJ6?=
 =?utf-8?B?MVRwRlZzMVJDTVN3UU5VejJMYktmbTVJdmdCb2Y1MXV0YlpYK3hjaWlndGhq?=
 =?utf-8?B?Zlg2b2FvbWRRSUd3UHZuZ2lFS1ZwV3ZTWTk0eW5IUXNvbDNVb0hsdnNRT0N4?=
 =?utf-8?B?TzdMbnBQN2dlYjV4Mmp4bktKTG02U212RXFmRk8yL3R4V0wrQllicVRmS0pk?=
 =?utf-8?B?K283K1JIYkEzbHZzS2E4dUJ5dDRZM1ZuUWdmZUFyNjFpTkZIT0tlV2xoUUtK?=
 =?utf-8?B?Rzh6dGp1U2Z1cnZEelgyMlcrMkxHeGE1YlRWRmZSM0NpSE01cW5RSS9HQzc0?=
 =?utf-8?B?OWMzL2FLTk95cnFMY3JITllWTnE0ekN6VVpBemdvQWY5NzFoQml0b3dxbXZF?=
 =?utf-8?B?Q2VzbU00dUhFV0xkSkpPMmQreldwclVkZjI0bFlyWDdjbkhvMk1OT3Y0UzVt?=
 =?utf-8?B?R0xQbDE1YnhPWHVwbi96QURqMmYycGYyZkR4M2x1RjdBYnRPUzdhZE5IWnFo?=
 =?utf-8?B?K0pWVUNEWEZ1alR1MytPSkFqaVVseWJWYmNXTk9MZWNuaFJhY2NaeTA0OTl6?=
 =?utf-8?B?bFRDZ08reWZQOVg4eklIZ2tRYlpCQ3NPQmhaR0xtMWhEVUZjd1E0QW0zeUYv?=
 =?utf-8?B?OEZVRW9mYm1ZSnFhTFUydHM4RlQ3YXpFaTZPci9EajliWm9UUHFvR1lRZStT?=
 =?utf-8?B?MDkwNzBVL2Y3VWNPREpwMElHbDkxTXRmdlZ2L0xVSUh0anFmTVMwbDVod2R1?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c0099b4-434c-4a73-0b34-08db0ead230f
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:01:38.5564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UOBpbCKYhVnQDpVupT1rnWUeCo9aYovSlrbpSTX6k8IIg30QcBPW5L9CAEWKDXeTXPSiBg/mSDAyn7YOlEzqQ/6Kq6OuwAipRC1uBFOa/+E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6914
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/14/2023 2:00 AM, Ilpo Järvinen wrote:
> On Mon, 13 Feb 2023, Reinette Chatre wrote:
>> On 2/8/2023 1:40 AM, Ilpo Järvinen wrote:
>>> From: Fenghua Yu <fenghua.yu@intel.com>
>>>
>>> Presently, while calculating MBM results, the divisor is hard coded as 4.
>>
>> "Presently" can be removed. Here and in the rest of the series the usage of
>> "presently" and "currently" can usually be removed to improve clarity.
>>
>>> It's hard coded to 4 because "NUM_OF_RUNS" is defined as 5 and the test
>>> does not count first result and hence 4. So, instead of hard coding the
>>> value to 4, change it to NUM_OF_RUNS - 1.
>>
>> Are there any plans surrounding using struct resctrl_val_param::num_of_runs
>> instead?
> 
> Actually no.
> 
> What I'd want to do is that the functions which call these result 
> calculator functions would specify the number of tests they passed
> into the result calculator. It seems safer because the results are read 

Would it not simplify things to pass the test parameters (struct resctrl_val_param)
to the result calculator? That contains the number of tests run and would
reign in the hard coding.

> back from a file which could have changed (or got deleted due to an 
> ipc bug prematurely cleaning up the file) and would better take account 
> those cases where the first value is skipped when reading the results.
> 

This sounds good. Thank you.

Reinette