Message-ID: <cbb2d9ab-861c-12ad-3a57-74fb59d08037@intel.com>
Date:   Tue, 14 Feb 2023 09:01:58 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.1
Subject: Re: [PATCH 1/4] selftests/resctrl: Return error if memory is not
 allocated
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>, Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
References: <20230208093016.20670-1-ilpo.jarvinen@linux.intel.com>
 <20230208093016.20670-2-ilpo.jarvinen@linux.intel.com>
 <88a819d7-b236-aed5-7cb8-6659e3f9f405@intel.com>
 <a4b44d-23f8-6df1-e494-908fbd43b732@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <a4b44d-23f8-6df1-e494-908fbd43b732@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anR1Qlc3UmZDaVdjTWFndm1jUG91cUlReTZYZlZPMk9mM1dOTlF2NC9SdUQw?=
 =?utf-8?B?T0RtNmhTY21WVlhheVdDcFFHNGY5Y3dTaE13MFY2ZGpvZWZUQnNJNUVEL1Ru?=
 =?utf-8?B?bmd6dVdWREQwTHp2UEdjcE1zaWViK2ZXblN4OHY2VmtsclNJV0JNK25wK0xq?=
 =?utf-8?B?SGl6b0xnNWJCL0k5U1ZOVW9BN2xsM2w5djJ1TmRPUnBvdUhWLy93K2Z3VHFP?=
 =?utf-8?B?cEdvdmFHZXU2dFN0SmVXdk8wUi9ZaldweUJWYitJNVpHWkt4TGdlTGdUTTdK?=
 =?utf-8?B?NUthcWZ5OW51Mm80ckUvMUozaDVkWVlLeTlFRWxuVWNCMUNkTnNIbThJSXNO?=
 =?utf-8?B?SHprYVBRa09Jb0lWM0FUSWlJWnBUUmNhT093ekJHMWF6bzU1TkszZiszU2Ey?=
 =?utf-8?B?SE5ndjVYUEtWTG1jSFFhbDhPY01JRlhRK0o5dGFUZTlOL3lyRk52dHdqMnBz?=
 =?utf-8?B?YnRZM2xpNnZHb0gwb3hjWnFHalNUSXRkWWpvdVJ6Um9lWXB6MTJMSWZZZXV2?=
 =?utf-8?B?YXR2NjNESW5xMlVWMmhlR0l1WE14RGpyWjgwTkcxN253bkxjTjJScmRRMGtF?=
 =?utf-8?B?c0krcW5ZVnpLRSsrSlVBa0grWVliS2EweUJ0TTRWSUtHaUNUbzVGcE5nV3Jx?=
 =?utf-8?B?Yi9CdlZMWm1DUHBDMTVUb0Z4NDBTeVdBQm51TkNYRm5seVQwV3JkcVZQUW5z?=
 =?utf-8?B?WXZXVzMwdzF5ZXJ4SjQrYUVySk9ZeVVkREhzMlB0VE1FcEdvaUgwekNBRVY4?=
 =?utf-8?B?bTN1eXhKK3VjYXhWT1dlMGRiMHV6MnMxcTRGaE1odEhHcEk0Q0NlLzNxbE1B?=
 =?utf-8?B?VjlIMEVWWjZYaHpiY3h5UmVvcHV3bXd5SWtPTWVPeWwxanlFeFFvTG5OK3J3?=
 =?utf-8?B?WFN4Z1NkMHFVT21QNXlzK1FhenE3QU1KRDVlZm5YdURjSWE5VXVlTW1WTWls?=
 =?utf-8?B?dXphTE1tTjZSYnIrakJJaGcxNnRrTktYcDc1ZW9mTmg5NGN0Undpbk1nZjVF?=
 =?utf-8?B?WlB6YVRLNVBMd1lVNTNwNFJMZktVd1h5cTlBRCtmSndTdVJ1T05JOGRKbXVY?=
 =?utf-8?B?RytvVCtYSUdaSkpMZVpPbHRqSDdySWRrZXl5N08xd2lLTWRQRjlXWVNUVGZy?=
 =?utf-8?B?TkRvcGlVNStkdXcvZWN3N1hMMkUvaWVabGEzSzE1bVhzVFJJZ214TG9SUU9E?=
 =?utf-8?B?cnlGaVZ6Unk0aFFXRW1YU284TzNUalQ3UnFYbndML1V1cXM4NjN3cCtJS3dT?=
 =?utf-8?B?Y1NpcjNNc21iWDdqUkpGSHlaakpENTNYWllRdEpDRnJHVlJzR2tCbnlZZmZw?=
 =?utf-8?B?aU1vV3hKc2RWWlVQNDlGTC9OS0FYaVdlN1FFdXFRREVVRmtUMlpnaTBKdlZp?=
 =?utf-8?B?UkZnZUVZb3NMTWNjR2VRK2ZoTlN4MHNaRmFsS3psc1VKOXluOWtxa2YvUCtM?=
 =?utf-8?B?c1dnZlpvVlBnNEc4ejRRVXJpODFTWk1RN24zVUlFMEUwZ2YrRnBNb1JBSTBi?=
 =?utf-8?B?bG9aamtGSFFBd3BkUjJjREQyZm9WOGNsUnpiR1FxNUdnMzdFTG5DdlJWSEZG?=
 =?utf-8?B?VkxwVjM4VXUxYmZaa0toVEU0L0M4QnNacVo5eFZmTVlNUEd5N0t5REZJNExh?=
 =?utf-8?B?YklsVWZmVG5EcW9vK2xzMWlpRGZCMUpaTzhHNkFUNXJVQjBxYjBCbmRQcnZK?=
 =?utf-8?B?UzVHNFhoZmhTOXRiRzZUT044YlJFUUxwZmpBTXg5anpDalF6TXdOdUxWS0do?=
 =?utf-8?B?OWc3TU80UmNkaU5pRVBVSkFQQnovTGNwam92NnkvVFg5bUJtRXZ6UjU2eTJT?=
 =?utf-8?B?TCthVS9LbUhmdFMzVjFVZit5blpMd09mOE12dk1pbVVqZDJOTk9TMFVvMmkz?=
 =?utf-8?B?QW9PMmlXWVNtVXdVQmx5Q2JYRUFhRUdqc0YwZ1ZrVVY2Qi94TU1oMUIreCsx?=
 =?utf-8?B?cnZtTVFpUVhvRndQRWM3K2JDRnEyc2hzUitmamNNNTd0Y3NpcVBhMXRZeDZz?=
 =?utf-8?B?MzNUZWg3L2VwaEluNnVoVm5VR1UrdWhaQUh3bkQ2c1ExV1F0MFUrTS9iaUU3?=
 =?utf-8?B?ODlFZElMRUpmSGNnb3Jmd2M2amJkbmMveHMvVFBzd2E0ZUVDZGZZT0lNYWE3?=
 =?utf-8?B?ejFmbHBoODhpaU1UczZoUzBuTURtaGtQaWhZUTROS1VGcW84aWFlTndaMnVo?=
 =?utf-8?B?WkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5267e4ab-84af-4010-81ac-08db0ead3081
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:02:01.0856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sfqPyd7MGQR+HEH1wjhw9DeLOqLwQKpv7ygoCxozIfs3qFUbxb29hKXJ3IsUvsrKbl4F0kYjPyXkmJtHYGa1gOJj1UWW7o82NkGTNzrVQDI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6914
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 2/14/2023 1:32 AM, Ilpo Järvinen wrote:
> On Mon, 13 Feb 2023, Reinette Chatre wrote:

>> Missing your Signed-off-by?
> 
> These were intentionally. When I didn't modify the original patch at 
> all during forward porting it, I just kept the original From and SoB as 
> is. But from the doc you pointed me to, I see now x86 wants also handlers 
> sobs.

I do not think this is x86 specific. 
Documentation/process/submitting-patches.rst states:
"Any further SoBs (Signed-off-by:'s) following the author's SoB are from
people handling and transporting the patch, but were not involved in its
development. SoB chains should reflect the **real** route a patch took
as it was propagated to the maintainers and ultimately to Linus, with
the first SoB entry signalling primary authorship of a single author."


> 
>>> ---
>>>  tools/testing/selftests/resctrl/fill_buf.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
>>> index 56ccbeae0638..f4880c962ec4 100644
>>> --- a/tools/testing/selftests/resctrl/fill_buf.c
>>> +++ b/tools/testing/selftests/resctrl/fill_buf.c
>>> @@ -68,6 +68,8 @@ static void *malloc_and_init_memory(size_t s)
>>>  	size_t s64;
>>>  
>>>  	void *p = memalign(PAGE_SIZE, s);
>>
>> This may also be a good time to stop using an obsolete call?
> 
> Sure, I can add another patch to change that to posix_memalign().

You can also consider aligned_alloc().

Reinette