Date:   Tue, 14 Feb 2023 11:20:53 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out
 MODULE_LICENSE in non-modules
Message-ID: <20230214172053.GA3044917@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <873578xnir.fsf@esperi.org.uk>
Precedence: bulk

On Tue, Feb 14, 2023 at 03:41:32PM +0000, Nick Alcock wrote:
> On 13 Feb 2023, Bjorn Helgaas spake thusly:
> > On Fri, Feb 10, 2023 at 04:47:42PM +0000, Nick Alcock wrote:

> >   - Please follow the subject line convention for each file.  They're
> >     mostly there after dropping "kbuild", but do capitalize the
> >     sentence that follows the prefix.  The prefix should always be
> >     "PCI/<driver-tag>: "

I misspoke about "PCI/<driver-tag>".  I use "PCI/<feature>" for things
like MSI, AER, ASPM, etc.  "PCI: <driver-tag>" is the usual pattern
for things specific to a driver, and it sounds like this is what
you've already done:

  $ git log --oneline drivers/pci/controller/pci-versatile.c
  6086987bdeb5 PCI: versatile: Remove redundant variable retval
  b64aa11eb2dd PCI: Set bridge map_irq and swizzle_irq to default functions
  669cbc708122 PCI: Move DT resource setup into devm_pci_alloc_host_bridge()
  d3bb94d06aae PCI: Drop unnecessary zeroing of bridge fields
  6a589900d050 PCI: Set default bridge parent device
  79cbde56f98b PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS
  3cf0eead9fb8 PCI: controller: Convert to devm_platform_ioremap_resource()
  a4b21b858b56 PCI: versatile: Use pci_host_probe() to register host
  331f63457165 PCI: of: Add inbound resource parsing to helpers
  2999dea8e94a PCI: versatile: Remove usage of PHYS_OFFSET
  f9f4fdaa3509 PCI: versatile: Use pci_parse_request_of_pci_ranges()
  0018b265adf7 PCI: versatile: Fix I/O space page leak

> ... If the rules for generating prefixes vary by subsystem this means
> I'll have to fight through God knows how many annoyed maintainers to get
> this incredibly trivial change in.)

I think your script generally does the right thing, and it's already
far more than most folks do, so thank you for that!

I normally do that sort of minimal fixup silently when applying
because there's no point in reposting when it's faster to make those
trivial edits myself.  In this case, removing MODULE_LICENSE instead
of commenting it out is just a little more than I like to do when
keeping your signed-off-by.

Bjorn