Message-ID: <d5f2c46c-cf68-3ec9-ec87-f6748ede1d1f@intel.com>
Date:   Tue, 14 Feb 2023 18:39:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net] ipv6: Add lwtunnel encap size of all siblings in
 nexthop calculation
Content-Language: en-US
To:     Lu Wei <luwei32@huawei.com>
References: <20230214092933.3817533-1-luwei32@huawei.com>
CC:     <davem@davemloft.net>, <dsahern@kernel.org>, <edumazet@google.com>,
        <kuba@kernel.org>, <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From:   Alexander Lobakin <alexandr.lobakin@intel.com>
In-Reply-To: <20230214092933.3817533-1-luwei32@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHdrWU03WllneFRsb29nb3JaNlkxeHYydCsxUkdnRndqdUpDNTJpdmx3Q1F6?=
 =?utf-8?B?aHNuT1dMYmEzanBQQytmRHJQTmxIalpBd0ZMZkZVUGYzaHoxNVFRNjE2b1hu?=
 =?utf-8?B?azRVZzBrMSs5a2JadFRyL3cwZ2VBMUlEVURad0dobURYZXlTaUlZbWI5UkNL?=
 =?utf-8?B?U3YwYmc2Zmhna0s5WDV2R0w4VWV1OFcrNTQyeFdsZUlIbjBMcXBwRU80dG9X?=
 =?utf-8?B?d1VzS0JqRlFxOVhGWG50bmNxM0NpMDd1RFZpUlJ2cmplaEhjTzBRSFpOVlZs?=
 =?utf-8?B?MndGUHBKYU5GUmlxaDJienBBektpM1pBcjZwamczeVpOVXd4Zms2b3kyQWhH?=
 =?utf-8?B?ZmxMcG5HM20zN2twNUVkQ3B3OUx5TGtMQnR2bmlKVFY4TjJtNXozdlh5cUw1?=
 =?utf-8?B?c20vWHdneG1kdnViaWRlT29aeGcvUjRLM2JUd3UxaGc1d3JIdHkra05WdktQ?=
 =?utf-8?B?RERrcVlyeEI3bDlVRURHNlpaOUg4SzI0VGx4REp1ZFBKbGsrNzZzRlpHK2xU?=
 =?utf-8?B?NHJ5ZWJQc2NqK1hnNmRNaU8rcW1LQnVMUTJJN2VkVHdmUTMvMnYrR1pDL2Yv?=
 =?utf-8?B?TFFndGdCSUFjKy9wbDI4Z2dZb24zTk05NDZrR0poQlRXN200MUsrU0pKU2Fu?=
 =?utf-8?B?em84S1VRSWJHakhoZ1l1aVVRWWhpL2orUGczbHlJNC92YXpDVUJjMWhwOHVN?=
 =?utf-8?B?WkhZZ1BoejVUUC9jTHVpL2MyUXc5ZHdkU2ZXbTliMEVSN3Zvb21nSCtCSXc2?=
 =?utf-8?B?MWtPUSs0U3pTWS9peXc4QXNoVGhjbmJaVDlBbWlhYzI0U3ZBU2V6RzNGQVNx?=
 =?utf-8?B?NzRWczJkTkdtNXFVcE9XbEVnbGFjbGJJWStwaE1BMld0cXB0b21LTHQxV2M2?=
 =?utf-8?B?c0U0YXdPNWlKTlFtVmhEYjRHQmQ0c1dmSU1UaDVOMi9TRSsxek1FT0VjcG03?=
 =?utf-8?B?VjFBVGdsb29MT3FHaHRNaE12K3ltVlR4S25iZU5tdzdZZjRMNjBLejNFK1E4?=
 =?utf-8?B?TGtpT0E4R1llTGZtZEl5S2VPNG1QNUNLZ3hjS2RLYnJDQ0JZNUxCR2srMUtx?=
 =?utf-8?B?M0xGK3FNc1NWRFgzdkVEMHR6UmxKNHhOZDJ5NnBDMFRYYzgyZmRhbEsyenRF?=
 =?utf-8?B?UEttTllsd0ZlazdQeEJZbGo0RlBrbHB5dWJpcDJ1VHNHNlFlQnpPZElwSG8z?=
 =?utf-8?B?T29ONDBPcmxJY1I1Nzl6Z3VPaHBNcW9UM081dDVqQUExVFZIRHhYWmZTMmdW?=
 =?utf-8?B?Z01QajlHQ20wbGVnRU9mMVdBYXJNREViOWVocjNyQ2xCdUZoRWZIVENmNXNk?=
 =?utf-8?B?Y2MwQzN5QWNFVSt1WnRNSTk0bVd3Ui84b0ZyKzZXd3lHM21UaStKYkI3OUMw?=
 =?utf-8?B?Ykp4dU9LeklhYWFHYXVsK1ZpYkp5ZG5GZVRBTTVDckcrS3h6Q0loODVubnVJ?=
 =?utf-8?B?elMwdnRhY2J0WjB0K2gxd2hPMnF0cHRBNStiVkFtSDNJUlBCZi80ZC9ibHBF?=
 =?utf-8?B?bEc0UHM5bW42Y1BhWm4yUXZReHQ1UUFpYkQ4SjlhVm1ralEwSTJKTDJZeTZr?=
 =?utf-8?B?M3FZYlo5WjZ1S1d3Z0RvcUhxcXkxR21yKzdHU1hlQWFEZkN6bUF0eXB6enZJ?=
 =?utf-8?B?T2JobVpTSXlzbTVxL0RmYjFwNXVielQ4WTUvTEZoS0ZiVkphaitOc0loeDNP?=
 =?utf-8?B?bk04NDVXM0doWWVQbGw5UGlWVmM0N3BtL1dUSmdPbkdPL0NQU0lGMldhNjdu?=
 =?utf-8?B?dU80ZC9hQlNYbitubEFiWjNXdHc3RU4vNEVFQnYrVVVWNi85UVg3VU9sQzE0?=
 =?utf-8?B?bUpwRERENlpmakJIbkc2aEY0V3hCcGw1cmhyanJSRUxYeEV1QncxTFJKUVhK?=
 =?utf-8?B?ejQvRzB1TmhiaGZxbUI4YW9ubHd1SXUvWnpZZ3VtMU1hQ0VNQ2c3WTRKc09S?=
 =?utf-8?B?V0JEWmNtN3ZsVGJWd2pubVFXVnpwNXA0SWRoaHBuczVPNzkxT2JTN1N3OTBh?=
 =?utf-8?B?MGhOUlo1QmgyUU0zdEd4ODdUeWNGOE8vaG5sMTg2WmdxRWlrSXp3UEM0cmtm?=
 =?utf-8?B?WXU0L3RBOFAyWnAwV3hVSVdrS1dKRVlLeHNTSEN6RThYUUhjOGZqOGdjVXZ4?=
 =?utf-8?B?SFM0Q010aHlsT25YOGFwSjlYeHJuV0VvM3I5SGVyZVlUSU1XMGg2c2dzWE1N?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b230db1-e1b4-4f68-ace0-08db0eb29b31
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:40:47.6248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DptosTy4PWyUqrb1bhW6ebgs25X7gpp1T+LXdi4UQ1Fb4OiBxRRfFYJ7Bejg1rU0Et/ApQwGfKFaXbFfFf5oQ4Pxhn3sem0A1F6fdgd8rSQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5601
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Lu Wei <luwei32@huawei.com>
Date: Tue, 14 Feb 2023 17:29:33 +0800

> In function rt6_nlmsg_size(), the length of nexthop is calculated
> by multipling the nexthop length of fib6_info and the number of
> siblings. However if the fib6_info has no lwtunnel but the siblings
> have lwtunnels, the nexthop length is less than it should be, and
> it will trigger a warning in inet6_rt_notify() as follows:

[...]

> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index e74e0361fd92..a6983a13dd20 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -5540,16 +5540,17 @@ static size_t rt6_nlmsg_size(struct fib6_info *f6i)
>  		nexthop_for_each_fib6_nh(f6i->nh, rt6_nh_nlmsg_size,
>  					 &nexthop_len);
>  	} else {
> +		struct fib6_info *sibling, *next_sibling;
>  		struct fib6_nh *nh = f6i->fib6_nh;
>  
>  		nexthop_len = 0;
>  		if (f6i->fib6_nsiblings) {
> -			nexthop_len = nla_total_size(0)	 /* RTA_MULTIPATH */
> -				    + NLA_ALIGN(sizeof(struct rtnexthop))
> -				    + nla_total_size(16) /* RTA_GATEWAY */
> -				    + lwtunnel_get_encap_size(nh->fib_nh_lws);
> +			rt6_nh_nlmsg_size(nh, &nexthop_len);
>  
> -			nexthop_len *= f6i->fib6_nsiblings;
> +			list_for_each_entry_safe(sibling, next_sibling,
> +						 &f6i->fib6_siblings, fib6_siblings) {
> +				rt6_nh_nlmsg_size(sibling->fib6_nh, &nexthop_len);
> +			}

Just a random nitpick that you shouldn't put braces {} around oneliners :D

>  		}
>  		nexthop_len += lwtunnel_get_encap_size(nh->fib_nh_lws);
>  	}
Thanks,
Olek