Message-ID: <45d1fdae-f6c0-ab19-f6a2-2499ead9289a@seco.com>
Date:   Tue, 14 Feb 2023 12:43:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH 1/1] PCI: layerscape: Set 64-bit DMA mask
Content-Language: en-US
To:     Frank Li <Frank.Li@nxp.com>, Minghuan Lian <minghuan.Lian@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linuxppc-dev@lists.ozlabs.org>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-pci@vger.kernel.org>,
        "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Cc:     imx@lists.linux.dev
References: <20230112193621.1513505-1-Frank.Li@nxp.com>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20230112193621.1513505-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1M2R0FVWnQvdkxNWm1kbEIxRU9IMGxRWFpuK21lUU5hMzZaeTROVjBFZXJr?=
 =?utf-8?B?QzBuSVNkTS8zNUJHdmJrS29Rdm5MRmhRQURKM1pzeCtDZEF3dTVJUm0vUlo2?=
 =?utf-8?B?dzFwOExzS25HcnFFODZZMGVPQWJudHJmcmIvcWlyODQzWDFmV1MrM2VSZ0Mw?=
 =?utf-8?B?OTdpMTAybXZ1QXlwb29IRkNqYTdYWmhMVXkrdGJQdmw0b3RSRmZFblJPSG9r?=
 =?utf-8?B?N09kRmRENlBPSkZPS280ZFkyMVpDVHJCSCtMclVKWk5iRXV4d2ZPOGRFTGZV?=
 =?utf-8?B?VDRMeTJodzFmRTA1TGRxZVhZeDVjRitPN2c3NzlWdUhjVDhJbXh6VUR0dGJJ?=
 =?utf-8?B?OC9iSEl3M0lnUGlxWG1ocnUvWXNrTzlQY0RkclBLaEZ1M1d2Tk16OUU2WG5s?=
 =?utf-8?B?TUdtV3RHa2wxSy9SVzdXZU9HTjBaSkt3YUwzNFI3elhIZWdHV1ZWVDBjZUtp?=
 =?utf-8?B?Zk9iUkdHYUUzZ2xmUi93d05zVmZFSEZBd0lzcGRtWW9OYVV6aWxSOXpUaFM0?=
 =?utf-8?B?bGpTWm1kNXh0b0x4L0kxdzgxREhSc01wZVphblQvY0FiSVBaQW1UYk5uS0Vv?=
 =?utf-8?B?SVBGaUlYb05zeit3VjY4OTIyNzRTVWdwZ04yNkdFZkgrMGZneWNRQ2FVSzBK?=
 =?utf-8?B?YXcrZVhuZ2NiSHgyVzBmZEEvNnV4aVVLTU5Fa2NoVHkxMGxiZFhCbGFYMHlI?=
 =?utf-8?B?TFExbXZROGJvNWZYeEU5b3I2SHo4dElJWDVuUnRFc1JnZm96cXdtRDdWTEEx?=
 =?utf-8?B?aUhHTFNNVG1STVc5WHBNcjhMMlZUS2NPQjNWd2FnRWhCd2NjRlFYNnFRQ01a?=
 =?utf-8?B?VFNUT1R6WlNieXI3SFhQcjgyelhPUStVaUUzTlZYOGw1azVBOCtxanNNV05G?=
 =?utf-8?B?VVBOdHNnY21CdnQxOVdxY204Y2pxSldwVWRJVDdkQjJHWTMzV0g4L3hFQ2E1?=
 =?utf-8?B?RzYrUjViYjl3UnlMcWM5YW9MODJ4ZnFDd0FwRFhwbXNKcFJaTEQyeC9idDZV?=
 =?utf-8?B?bFFNZUVmYjVSWXhYdTlaZTR4OHorbStuQkdydDJSRjdRdlBFV3FhQjJ6eUNC?=
 =?utf-8?B?MFB1akMzSmVqNU1yWExOaWpGZDlqR01SNHJ3TFFpc2RrRysxR2k3bVRlNzAy?=
 =?utf-8?B?OHlMN3N2S000THQzZ3dnek1SNmdMMVMyVXFkVzVzdStWVHBPOGRIcmIzSlE3?=
 =?utf-8?B?ZnhNa2xiMUtiaGxtNDRYemFiSGRtS3dOaklNSzZIL3EySzB6L3ZmbXdlS1c4?=
 =?utf-8?B?QVQ3WGxOcEtBY3NLaWJ6QkE4YWNrS0cwcDEyVzVvVnV5MHcrdUExano5QUJV?=
 =?utf-8?B?YVVHU094aERHcHB5bUd5Um9uYmtEYVZxTmZmSnBZU0w2b09xMFl4YjhQUlU4?=
 =?utf-8?B?N1J2V3lRd0lSTjJCRjlJTlEyS2FUa3VTVWREc2hHUTBQZjE4elhQZjVXVVVS?=
 =?utf-8?B?dGtodU5XVzllOXdXSjAyUkhXa1QrR1hBQUNqWFpiMzVleHpqUmVTVU5RWC9p?=
 =?utf-8?B?YVdUWkozNHdSMDlWRUh4Vzg3S1JvcUVWV0xKeWFkZ0FRb2pyOWFGOUprUTRz?=
 =?utf-8?B?SWVWRkFIeVk4bmU2YU1oTHdSV1BtRHdGVXdnVXpBZnZmbWtTd3kvNEpaZGd4?=
 =?utf-8?B?alJpdkVZaEppNzJKM0JBSTYzbU1ZdDN5M1MrdFo2K2J0ajhLSFVFeERoM1F3?=
 =?utf-8?B?SWtpWnBiTFpxbjE3NTJDdGlWYlZYamVlOWVjRDBYZmFveC9uL2QwcFpJL2lC?=
 =?utf-8?B?TUZwT3VuQTFpZlNpRGVFT0E4RGs1OGtRNnJDdjhPMytTamtDRUV4eEI4UUNQ?=
 =?utf-8?B?cTRXd1N3V3RsVndjNTZ0Z0JXVVM1dFhrdVhTWC9qYmswZnJndDR6NUs0WU43?=
 =?utf-8?B?MEhLMUFFejVyUnNZSUFCZG1QejlpS2xlenJPNWZadFJYUmVBZW1ya243c1A2?=
 =?utf-8?B?bnV6c0lVWDBHZHByWDI1NTJoeGxjUk16TVJQdkdiRGdkVWhPbjg1NVNjK1NB?=
 =?utf-8?B?dG4wS1RSUWk3bWR5VDJmTHA0ZHpoQ3ZTaDQwazZxY2FoMDh1OFRVeEFvM2Qw?=
 =?utf-8?B?VE5LNjNISkdybjIzY1BJVFh1V0dWY1Z1UjdRdU52N05SRHlUWFQza2swczlC?=
 =?utf-8?B?eXE2Rlo4R2pXaUUxeUppYWNoNkg4ekVDZTVFRXRTVVluVXpIR0ptWmx1UFo4?=
 =?utf-8?B?Wmc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fee584f1-e6a1-4ce0-c4c7-08db0eb2f11a
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:43:11.6493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S6z6e/i4BGBrJmY9iUgLVN+ANkChG6H/vdIWmmlf72xlx8c8kSYRJmpMi07SvBgfNa1TEQfyxVR8F1vCpuZGww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6452
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/12/23 14:36, Frank Li wrote:
> From: Guanhua Gao <guanhua.gao@nxp.com>
> 
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> 
> Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  drivers/pci/controller/dwc/pci-layerscape-ep.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index 1b884854c18e..c19e7ec58b05 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -261,6 +261,10 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
>  	pcie->max_width = (dw_pcie_readw_dbi(pci, PCIE_LINK_CAP) >>
>  			  MAX_LINK_W_SHIFT) & MAX_LINK_W_MASK;
>  
> +	/* set 64-bit DMA mask and coherent DMA mask */
> +	if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)))
> +		dev_warn(dev, "Failed to set 64-bit DMA mask.\n");

Isn't this mandatory? Why not dev_err_probe and return the error?

--Sean

>  	platform_set_drvdata(pdev, pcie);
>  
>  	ret = dw_pcie_ep_init(&pci->ep);