Date:   Tue, 14 Feb 2023 09:52:26 -0800
From:   Bjorn Andersson <andersson@kernel.org>
To:     Melody Olvera <quic_molvera@quicinc.com>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Robert Marko <robimarko@gmail.com>,
        Guru Das Srinagesh <quic_gurus@quicinc.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 3/9] dt-bindings: soc: qcom: aoss: Document
 power-domain-cells for aoss
Message-ID: <20230214175226.e3sstj6pk3naavbr@ripper>
References: <20230213185218.166520-1-quic_molvera@quicinc.com>
 <20230213185218.166520-4-quic_molvera@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230213185218.166520-4-quic_molvera@quicinc.com>
Precedence: bulk

On Mon, Feb 13, 2023 at 10:52:12AM -0800, Melody Olvera wrote:
> Document "#-power-domain-cells" field for aoss devices as required
> by power-controller bindings.
> 

99512191f4f1 ("soc: qcom: aoss: Drop power domain support") was merged
in v5.16, so I don't think this is correct. Please let me know if I'm
misunderstood your intent.

Thanks,
Bjorn

> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> index ab607efbb64c..bcfa8e2e6a04 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> @@ -60,6 +60,9 @@ properties:
>      description:
>        The single clock represents the QDSS clock.
>  
> +  "#power-domain-cells":
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -97,6 +100,7 @@ examples:
>        mboxes = <&apss_shared 0>;
>  
>        #clock-cells = <0>;
> +      #power-domain-cells = <1>;
>  
>        cx_cdev: cx {
>          #cooling-cells = <2>;
> -- 
> 2.25.1
>