Date:   Tue, 14 Feb 2023 13:57:29 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     Jean-Philippe Brucker <jean-philippe@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH v2 3/3] iommu: Remove ioasid infrastructure
Message-ID: <Y+vLiWS3+Rp+If6U@nvidia.com>
References: <20230214064414.1038058-1-jacob.jun.pan@linux.intel.com>
 <20230214064414.1038058-4-jacob.jun.pan@linux.intel.com>
 <Y+tVMRzRQbcc7Guz@myrica>
 <Y+uHSry/tpgGNr/b@nvidia.com>
 <20230214093107.323d7e76@jacob-builder>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230214093107.323d7e76@jacob-builder>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?htucNRW+rYCrU3UPb+nmAXE3MjQeqeXBy2qXey56QCqKA42lpB6egL/i7q1R?=
 =?us-ascii?Q?Uyw6/mC+mxrIRK8zJHBcpn4gG2QVicFfAbuCsPmMyIdEt1NbijT3/eT8BZKE?=
 =?us-ascii?Q?nyD48imhLsbfxiZI/x+FMDPh1bmmK/gppP271ltBuytnAdosCJf12TuY8tLK?=
 =?us-ascii?Q?NHwBAQg6Pk7fFbzgIwx2h8W+oo/xUDEMOYzBJeAGfhMbYJyZ3InNFGZX1lU0?=
 =?us-ascii?Q?FXNUmZ7241CVxYoTTfhraI1WwraLZA+fV8RRSyhIHix13VLm+EXjb/ALxgBQ?=
 =?us-ascii?Q?mfgikA4KUnLkdYaZWEN0jAO0st3yVOtfawbJjCQXli5VVXtDmKb7eYOtoLvh?=
 =?us-ascii?Q?2t0sRBqA1r/qij98lpKAnoGP/VMUKR2HD4CftsrMckue/YqhpA3mCSh6tc3+?=
 =?us-ascii?Q?XJIZZs+r7Yq+ATDnNHCatMMXc8fRDF++A4Ml1pYcSccN89pKtAeN7VYKCgn/?=
 =?us-ascii?Q?ohkbLCNumeHVN6dL6LzW8pJYkE+/Gett1ccGAfny+FwKl4WoIWDDX5B0wvID?=
 =?us-ascii?Q?0s0ckro3vhULMPs1wWaqROc2+TYXW2j1OBzaYk6xBsx2382wEi8KhJ5OBUvG?=
 =?us-ascii?Q?4c+S4JaigDNIh/vsPVLVnIPRyb+N46Grns7bNuQGPegS5nKvnT3+VujYEsWU?=
 =?us-ascii?Q?Cls1mJQy9ogrcxeieET+/aKaaoS+/r8lDxKlKd1p2irkuj6OSWux777r4R+a?=
 =?us-ascii?Q?HryjKY5O+/v0I4lx5uzKmnMIl5uJcFqu06qWRK1ypJqymXw01eiu1qHFipmP?=
 =?us-ascii?Q?c5vvt//+Rqv7t18PMb3oMJH7fI9nI9SpCcFD7eq1h9yjS4veFAzHA0LY1t7f?=
 =?us-ascii?Q?ywYAUBMqyyaL0Sti60iYunji6uAgmZx8r+sQ/P8IF43bd478lMwwWrlKlRH0?=
 =?us-ascii?Q?dVpo0CLitkkC1aX5ODR7Bi8EeUZSECwCjFb/ZTQ/CSq6TSay0D30tUhIfbyd?=
 =?us-ascii?Q?WvPKrfuIB/0bYGIFbvFcJxEpkV35pkL40qS2AdIYsT1TBoZoxm0C6BaI80+3?=
 =?us-ascii?Q?jZ/N1Gdz2LHsbHTgKcXi0ukI9ZX2jB+wO2EhZ972mD/epgYvfY5D3qP28+x9?=
 =?us-ascii?Q?e03v3cSEokSx2YZvlVxM08b9fATA0SMNXOgmi8p9kHiyf1FhcK4QuYAsQFGL?=
 =?us-ascii?Q?vForkwrkLaYQl6FSowY4wlsYpy7aa31ci5+OYRas5h8IIOhVjV9kJmblDdHm?=
 =?us-ascii?Q?liSzlcUwfcBkVnTNyQ/xpAI7VRLhtctcc2Vlb8gDa/sUEONSG+bgW+GBZGfN?=
 =?us-ascii?Q?Y/yV9xdMn7cCznVhW1KnjKoDVkO7/FWc/67ksLEwqpGnb06FzNMRhPjLsHRe?=
 =?us-ascii?Q?p07/hTbVw8h/T/08mECwKHBgojXwE9OeG+UZvKimGYqRJE8utY0yjCnwVixB?=
 =?us-ascii?Q?Mt6uvg9cT8oGPNb6cpwUBPwyaWoIIpxJNzGGoPO2u3XjhZxDec+7siIKKz0y?=
 =?us-ascii?Q?9/ycBAwN3C5pSGSK/A0bg0vpr5Va1+K8KQUyuM738J4zTsH7ovlPz+evlGHM?=
 =?us-ascii?Q?aCw4NenINTp9vU5Mxo6FWmy6zOWih8DLmx654W/7FhNldU4rdS1KEZY/ZZ+v?=
 =?us-ascii?Q?o+7wCF7XHlQ+A1tLlqlfS5MheY4fJ7A9EN0eRLT5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b91bc55f-485a-4675-0084-08db0eb4f109
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 17:57:30.5108
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iJ9HeMvUv9SFXudPN6KtbiukW+3+b09A1uLJ+WV23vvj5KJQezvIWi7uz1VH/ssD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6448
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 14, 2023 at 09:31:07AM -0800, Jacob Pan wrote:
> Hi Jason,
> 
> On Tue, 14 Feb 2023 09:06:18 -0400, Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > On Tue, Feb 14, 2023 at 09:32:33AM +0000, Jean-Philippe Brucker wrote:
> > > > diff --git a/include/uapi/linux/iommu.h b/include/uapi/linux/iommu.h
> > > > index 65d8b0234f69..a95f07f0c98c 100644
> > > > --- a/include/uapi/linux/iommu.h
> > > > +++ b/include/uapi/linux/iommu.h
> > > > @@ -157,5 +157,6 @@ struct iommu_page_response {
> > > >  	__u32	grpid;
> > > >  	__u32	code;
> > > >  };
> > > > +#define IOMMU_PASID_INVALID	(-1U)  
> > > 
> > > Why change UAPI?  
> > 
> > There is no uapi, this whole file needs to be deleted too
> > 
> ok. another clean up.
> 
> As I also replied to Jean, I ran into a circular #include problem if mm.h
> #include iommu.h, I guess I could also create another header, e.g.
> iommu_defs.h to avoid it. any other suggestions?

Given this header is not used, just delete things from it to resolve
the problem?

Jason