Message-ID: <c5e3cf7c-1a94-4929-5691-9ccb4c7a194b@kernel.org>
Date:   Tue, 14 Feb 2023 11:11:04 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.7.2
Subject: Re: [PATCH net] ipv6: Add lwtunnel encap size of all siblings in
 nexthop calculation
Content-Language: en-US
To:     Alexander Lobakin <alexandr.lobakin@intel.com>,
        Lu Wei <luwei32@huawei.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230214092933.3817533-1-luwei32@huawei.com>
 <d5f2c46c-cf68-3ec9-ec87-f6748ede1d1f@intel.com>
From:   David Ahern <dsahern@kernel.org>
In-Reply-To: <d5f2c46c-cf68-3ec9-ec87-f6748ede1d1f@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/14/23 10:39 AM, Alexander Lobakin wrote:
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index e74e0361fd92..a6983a13dd20 100644
>> --- a/net/ipv6/route.c
>> +++ b/net/ipv6/route.c
>> @@ -5540,16 +5540,17 @@ static size_t rt6_nlmsg_size(struct fib6_info *f6i)
>>  		nexthop_for_each_fib6_nh(f6i->nh, rt6_nh_nlmsg_size,
>>  					 &nexthop_len);
>>  	} else {
>> +		struct fib6_info *sibling, *next_sibling;
>>  		struct fib6_nh *nh = f6i->fib6_nh;
>>  
>>  		nexthop_len = 0;
>>  		if (f6i->fib6_nsiblings) {
>> -			nexthop_len = nla_total_size(0)	 /* RTA_MULTIPATH */
>> -				    + NLA_ALIGN(sizeof(struct rtnexthop))
>> -				    + nla_total_size(16) /* RTA_GATEWAY */
>> -				    + lwtunnel_get_encap_size(nh->fib_nh_lws);
>> +			rt6_nh_nlmsg_size(nh, &nexthop_len);
>>  
>> -			nexthop_len *= f6i->fib6_nsiblings;
>> +			list_for_each_entry_safe(sibling, next_sibling,
>> +						 &f6i->fib6_siblings, fib6_siblings) {
>> +				rt6_nh_nlmsg_size(sibling->fib6_nh, &nexthop_len);
>> +			}
> 
> Just a random nitpick that you shouldn't put braces {} around oneliners :D
> 

I believe there can be exceptions and braces make multiple lines like
that more readable.