Date:   Tue, 14 Feb 2023 21:01:00 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [REGRESSION] rtc: imx-sc: remove .read_alarm
Message-ID: <Y+vofPf0YVp5Ay65@mail.local>
References: <bbe470eaeeb17624444b37dbe35b0883193e475b.camel@toradex.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bbe470eaeeb17624444b37dbe35b0883193e475b.camel@toradex.com>
Precedence: bulk

Hello,

On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
> 
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
> 
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
> 
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
> 
> This seems like a regression or is this not supposed to work?

This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.

Regards

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com