Date:   Tue, 14 Feb 2023 21:06:29 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Frieder Schrempf <frieder@fris.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Marek Vasut <marex@denx.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 4/6] regulator: Add operation to let drivers select vsel
 register
Message-ID: <Y+v31bkMWxPEVqrT@sirena.org.uk>
References: <20230213155833.1644366-1-frieder@fris.de>
 <20230213155833.1644366-5-frieder@fris.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NaBXGsd+qhj6WDye"
Content-Disposition: inline
In-Reply-To: <20230213155833.1644366-5-frieder@fris.de>
Precedence: bulk


--NaBXGsd+qhj6WDye
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 13, 2023 at 04:58:22PM +0100, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>=20
> There are regulators that use multiple registers for storing the
> voltage. Add a get_reg_voltage_sel member to struct regulator_ops in
> order to let drivers register a function that returns the currently
> used register.
>=20
> The pca9450 driver will be a user of this as the LDO5 regulator of
> that chip uses two different control registers depending on the
> state of an external signal.

Aside from the build warnings the bots reported it's not clear to
me that it's better to do this than it is to just have these
drivers implement appropriate ops directly - there's probably
going to be cases when it's a different bitfield in the same
register, and by the time you've implemented the op so things
aren't completely data driven I'm not sure how much you win by
reusing the register read/write.

--NaBXGsd+qhj6WDye
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPr99QACgkQJNaLcl1U
h9Dm0Af/T9/6tAxXnRh5Wr5xXNCxbTqyF59h9AU3Zzc75ebXkVxeay8+pFeDJK1i
EF40vqbKO2ZOgtVa4A1YcZRH203yQYW2L9AgZR7eV58gkS9zK70go9jCKiZb2WQX
0+lISHovUIq9sV1tca1Qtgd/J4/kGaINJZN5l7JAHmzlodB5vFt9AuGXKZPz0+VU
lzZ9+t7RyzZY1LruiLuXovzLD5vOmRA961ZT7RGhkaZKdMiOgusq0/XjyXdIjieg
z3Xw2ZVycWGCenie3qxnIyIeyZRPE6kH6J5FTzkinMjxu3lQKsZqlWz9Ct0Q0wxY
dFDSvYzV6Ve11Q30hP1I8UD+1CKUsw==
=3jaZ
-----END PGP SIGNATURE-----

--NaBXGsd+qhj6WDye--