Message-ID: <7de3c5bf-8386-5d6e-bb64-2cf86a2bdede@amd.com>
Date:   Wed, 15 Feb 2023 02:54:59 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH V2 7/8] soundwire: amd: handle soundwire wake enable
 interrupt
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        vkoul@kernel.org
Cc:     amadeuszx.slawinski@linux.intel.com, Mario.Limonciello@amd.com,
        Sunil-kumar.Dommati@amd.com, Basavaraj.Hiregoudar@amd.com,
        Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        "moderated list:SOUNDWIRE SUBSYSTEM" <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230213094031.2231058-1-Vijendar.Mukunda@amd.com>
 <20230213094031.2231058-8-Vijendar.Mukunda@amd.com>
 <cd70a91c-231e-1bca-b0ac-4041cba0daad@linux.intel.com>
 <586a9f58-f660-1ac0-0506-91362b25f75d@amd.com>
 <e32e9508-9c91-b8ab-c862-b861aca8c02c@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <e32e9508-9c91-b8ab-c862-b861aca8c02c@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUhlNFE2RktXUW5USTRyWG1BNWpCM3BnZzZHMUtPZnM0WHU1NGprZU9PVU85?=
 =?utf-8?B?N3hxZnBIQ3duaXh6ZEtJYlBCOE80VXdPZ0xGeUdwMEdJU1FUU0dFRmcxazZt?=
 =?utf-8?B?WXRvelZIK0t2UVRsMGUwUzBKK2NMdmNvcS92a1ZiRk1xbUZpWDdYNjQvZVRy?=
 =?utf-8?B?ay8yZFpTOHFiWlpGT2JreENkcG9NRFdYOXRMOWphSTdZaGl2TFY5QVhBVUdw?=
 =?utf-8?B?ejQrUkhLM2U2d082U1NiSzU3b3NwR1VWUU0yTlFqRkZEbmhHekFpeHR0VU5Q?=
 =?utf-8?B?SVpBRW1UOGpuZFhob2dDREJVdzR3dGdrM0N3UXZuWXNKbVZjWnNYK0I2bmp4?=
 =?utf-8?B?b2dEcVltRnNKeHNXZ014cWxhMnhaK1k2Y2RuMEF4VjFmTGRYZ2ZOb2VIOWc2?=
 =?utf-8?B?aGpnNmh2Y0w4Y2tTQ2VoWFA1MFAwaUc3UTVXeHNlWlJaRkd1R1JaK0haTWVN?=
 =?utf-8?B?T2RTS2FxNU90eFZ0U2t0dFFnTEh6bmxTVkJqcWRWbXhGamlOUzQyY2lYS3Rk?=
 =?utf-8?B?akppTU5XNmlvV1NiWG95RHFIYlJXT3hGbXJPTUp6VFN0dVJ6ajFvMUR5NXBV?=
 =?utf-8?B?ak4rcTNRVkttWVZnYzdxRHNjYlFQd2JlYW1HS2wwRWpFS3lZaFR1SGZ0QTd5?=
 =?utf-8?B?aDhtQWp5N2NSRjZDQldIZ0Z1Q0lvWDdKN01WUGNCczZyRnZmMGhDU3JRMGV3?=
 =?utf-8?B?NmI5ZmluSG5GTkMyUStZRWJySVFrRlRtYXZVeHdsTmN2bE91SVdhcHpMa3M3?=
 =?utf-8?B?TVZadEFiRUJTVU5wRG5TdzVZTXN5Zk1RSU5hdTFKM1pOSGNDZkV1REJYM3RL?=
 =?utf-8?B?RXBHQ09PUWtjeTZJR0dWQ0xNUWJwYm84L0U1T2FaRmhWVXhWUGtRdEg4Zlkw?=
 =?utf-8?B?VXd0VzNGYXV1REE3SFpkZmEyZ1QyNzBtWXh0d2tQcTlqdjd0YTVQYUtUcGFJ?=
 =?utf-8?B?Zi9pODhIN21EVDd2K3lyOXgyZmJVd1d5M2gwalh0Z1FZTGFYbzRUQ0RtdnJH?=
 =?utf-8?B?UFMwa0lhczlmUm5RSk1BNS9QdWZGYllxR2dTRGNTbnk0dE9nYit6YXVlWGN6?=
 =?utf-8?B?aTczbGxYeWZDc2VJT1FtUFlKTG9aYUJHbFRVYmdmNmpETTRBSTE1SDgwbnV0?=
 =?utf-8?B?R1BxbjRqTWZLUFVhelBrc1M5ME9YWVNhcmlpcnlFOWFNK0lkM1NUaDl1VW9V?=
 =?utf-8?B?ZmpJRURzeEZaa3lUSUhTZWhhczAvL2I0NGg0aC9MNU9iMjFmQXBDcHZ2Ujd1?=
 =?utf-8?B?Z0NCMVBhNlVER1phZXpqbUc1bzdrSEpuSzZXVTVGRzdKWXBsblhYTnMxRUlG?=
 =?utf-8?B?azl4MXBWSGpDQkFPenc1bE54a2IxY3BYaGY4Zm82ajlNL2lrSTJGNGE3TUZB?=
 =?utf-8?B?VHU2MGxXUXBUek4xK2NrQTJqdkRETWVNSlhJM0ltOHRqekp5UlNZN3ZpWjJU?=
 =?utf-8?B?azRFa1AxMlppTmx4eU5yU0F2VlVSUGNSNnd5NzZFMG1TRVRmczlWK0EzT25U?=
 =?utf-8?B?cW1ydUpLVGhXVHk3ZStlMm9RSWtxTVNESDdKUjFHM2IzQUNRRHRQNW05UVJm?=
 =?utf-8?B?V2UwZWs4QTlxbnNrcklBa0x6R2o2NFB0N3N2QXRqWHhyMll5ekM1SWtwQ1ZV?=
 =?utf-8?B?RkRIaFIrRFh6TTNLeFZCbnVLbFJxMUx1bTBqSlBadG4yUHBSaDE2WjFMQVFZ?=
 =?utf-8?B?cTA1d2IvTWRxbUo0Q2JpT2lsencwTndobURIMjVyQ29tZWxkMlpqVDdHRVVt?=
 =?utf-8?B?MjVEQzZYNVdKaWMwanYxU0JYbW4rak9QUHRWNTlZUjlrcHZWdHhUOW5UcXds?=
 =?utf-8?B?R3hGZjlXZGN4T2FBTnhQQndDVXREODcrZU8vaU5wMmN2UkVUdmNjVVFCVHhI?=
 =?utf-8?B?Y3pEVi9sS2hUdXZtbncyRHVIWk45aWVyb2o3QXJoeXN3Y21DVE9uMFZ1RC9o?=
 =?utf-8?B?NmxjcXh5NHhYaUhHSE02OHIyL2Z1UEsxUFJRN3FjQUJUUUVEditFcFZ6dW5z?=
 =?utf-8?B?OVJSVElIZzcrY005eHBJTk1IV2Mrd2ZtRFZweWxXVENhM1BxU2I4bzFjQ0xQ?=
 =?utf-8?B?ZTZjMHJGbTdwRlhOanErM29wZGpJK01nY3ZhMG0wWGd5Rk04TGFsL0tkOG5z?=
 =?utf-8?Q?2fylir04A9rrwG5q8jmCfwnu9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bf3c6e8-9fe6-424b-1ef6-08db0ed185f4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 21:22:06.5596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MdRqow3QmK4wTlFzHaFASHMbAzwItNObxlSBvUCZwHXwhXpwM69rCjoelxo5E38RaADeu1xLcgzuurnmiSyszA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5758
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/02/23 19:05, Pierre-Louis Bossart wrote:
>
>>>>  static void amd_sdw_irq_thread(struct work_struct *work)
>>>>  {
>>>>  	struct amd_sdw_manager *amd_manager =
>>>> @@ -945,6 +952,9 @@ static void amd_sdw_irq_thread(struct work_struct *work)
>>>>  	status_change_0to7 = acp_reg_readl(amd_manager->mmio + ACP_SW_STATE_CHANGE_STATUS_0TO7);
>>>>  	dev_dbg(amd_manager->dev, "%s [SDW%d] SDW INT: 0to7=0x%x, 8to11=0x%x\n",
>>>>  		__func__, amd_manager->instance, status_change_0to7, status_change_8to11);
>>>> +	if (status_change_8to11 & AMD_SDW_WAKE_STAT_MASK)
>>>> +		return amd_sdw_process_wake_event(amd_manager);
>>>> +
>>> it's not clear what 8to11 might have to do with the wake enable?
>>>
>>> Can't you have a wake for devices 1..7?
>> It can wake any device from 1..11 .
>> SoundWire Wake interrupt status bit is part of 8to11 register.
> You probably want to explain what status_change_0to7 and
> status_change_8to11 actually control, it's not very intuitive for me to
> see device 1 interrupt being handled in status_change_8to11?
Peripheral device status interrupts on manager side will be read by reading
0to7 (for devices 1..7) and 8to11 (for devices 8 ..11) registers.
8to11 register will contain field for reading Soundwire wake enable status
for Soundwire manager instance.