Date:   Tue, 14 Feb 2023 21:26:05 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Claudiu Beznea <claudiu.beznea@microchip.com>, lgirdwood@gmail.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: soc-generic-dmaengine-pcm: add option to start
 DMA after DAI
Message-ID: <Y+v8bbr4cNSOA1SF@sirena.org.uk>
References: <20230214161435.1088246-1-claudiu.beznea@microchip.com>
 <20230214161435.1088246-2-claudiu.beznea@microchip.com>
 <b065e2bb-1f11-067a-b085-45d47626927e@metafoo.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="R54liaYzL9gFIZzm"
Content-Disposition: inline
In-Reply-To: <b065e2bb-1f11-067a-b085-45d47626927e@metafoo.de>
Precedence: bulk


--R54liaYzL9gFIZzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 14, 2023 at 10:14:28AM -0800, Lars-Peter Clausen wrote:
> On 2/14/23 08:14, Claudiu Beznea wrote:

> > @@ -450,6 +450,8 @@ int snd_dmaengine_pcm_register(struct device *dev,
> >   	else
> >   		driver = &dmaengine_pcm_component;
> > +	driver->start_dma_last = config->start_dma_last;

> This will break if you have multiple sound cards in the system.
> dmaengine_pcm_component must stay const.

Right, if we need to modify it we either need to select which of
multiple const structs to register or to take a copy and modify
that.  I've not looked at the actual changes yet.

--R54liaYzL9gFIZzm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPr/GwACgkQJNaLcl1U
h9DDgQgAhYXy5TF+7Mg2IjWNd041kJVc1YKqear/ET167ZstAJ9vPrvD2rhlh0R/
U+aSgJDd4qoFQ4WHBIW2U2xGAbHgjiXbiCfyxdCRChBtS+gKfKEOjxyKxNHh5ImM
1WJyZfgnvXg7Sb8wRTSaALBuDok7YreQAsTkqOSkYIxzH+LTcRYu0XXEaykGCY+E
kpqZUbeNlOhpzu0ljyWHl6zqkDY98+hVpn8kIaMbjTTx979/lR82pDe1CcyyaFXO
M9p3TdQNJnf49mHrQf77Zyk4/Jf4268r/9xjtT5OtMYGEY0xdiPrMZuX6KgDE+l9
2QEnZ6cey67U3HBu12P48htN0LhEmg==
=ALoi
-----END PGP SIGNATURE-----

--R54liaYzL9gFIZzm--