Message-ID: <a06eb4f4-70c7-0a3f-c22e-ff69b587e0c0@amd.com>
Date:   Wed, 15 Feb 2023 03:14:12 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH V2 6/8] soundwire: amd: add runtime pm ops for AMD
 soundwire manager driver
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        vkoul@kernel.org
Cc:     amadeuszx.slawinski@linux.intel.com, Mario.Limonciello@amd.com,
        Sunil-kumar.Dommati@amd.com, Basavaraj.Hiregoudar@amd.com,
        Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        "moderated list:SOUNDWIRE SUBSYSTEM" <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230213094031.2231058-1-Vijendar.Mukunda@amd.com>
 <20230213094031.2231058-7-Vijendar.Mukunda@amd.com>
 <383a8166-bc60-8557-e76b-f6287c967598@linux.intel.com>
 <65ec1f29-2ad2-acd6-feff-7d1d6f40ef8b@amd.com>
 <37fbb1d4-60f1-5cba-180a-ba51922fdca8@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <37fbb1d4-60f1-5cba-180a-ba51922fdca8@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UElWaGp3ZkNQMURyZ1IvQ3g0MXJJMnhsNWVIZW1uY1JvNitUaFlNaFZIRmVm?=
 =?utf-8?B?Rk9wVDZiZHg2K2MyNXR6eGVya08yM1o4Mk5Oc3BCLzFvRGNLUzlRSWVkb1hm?=
 =?utf-8?B?YU1ESEUwM1Y0SEV0OXNleVpmZ1ErMCs4NXdhK20ybHFCWnNicTEvTjdwNWZ6?=
 =?utf-8?B?bG50dlRyZ2JaeE9PVkJ5Q25XcEpBMXRWeHBtQ0gzdXd0VW9jWlpyM1p3Z0tu?=
 =?utf-8?B?VzlFQzVYY0JIMmdkL2dRcGJVN1BKNU5rNDNpdGJkVkE1aXpLYmtMVkxZZUdx?=
 =?utf-8?B?bVdpK2s5RmQ2U0lpTTE3dG52U1RlOXlzOHVCbG1vVFBtMDB3TDFSK3lkY3M4?=
 =?utf-8?B?RVkvOFUvUjdHTVRZNXpYVUpRV2dUWkluUWNIOXF3ZkZ5cnF5KzVJRmRSSDdV?=
 =?utf-8?B?YzMyV3VneGpvUjhucWpVdjA3UC9JKzVxd3lQWm8zR1p3TzEycUNQc1pZVUZ5?=
 =?utf-8?B?a3YvQ3AwS014RmpXWjYweU95RU1HclpMa21jMndiRUJxUEZ1aXpOL3V4c2cx?=
 =?utf-8?B?QWx0NEFJSEJyL08zamNoQ21aRXh2UGRoWWN0b0ZmaHBPRHFSOHpTR2l4azQ2?=
 =?utf-8?B?bm9CcW5kQjNsN0dQUUlHMlFraHBJSlV3eXMvYjVQTDVLSzVEQzI1TThma0hr?=
 =?utf-8?B?bFB0dkdpa0JsOVF6ZFlaNklGNWRnU3lJSkE4SWFzTTVjRCtVTXRqTFJreFps?=
 =?utf-8?B?b2UzeThEbmNldUNWVDBjUE9oVGdLaVJpMDhUM2IzbXAyL1p0SGhCTlo1VEdo?=
 =?utf-8?B?a1ZWMm1UbjczcS8yTVlkRVJCd1hJVStpazhJK3prQ3dIQ3ZhVUF1QjdZZ2F4?=
 =?utf-8?B?NllUeTdPTUF5cFhvWTRUMWJBWEl3SXV1YmtaWjNmTHM4OW1keUR5Z3hQcUlk?=
 =?utf-8?B?d1NCTTRCRFBTOFgzNVFkR244T1dZQVA4Y1dUZVpjYlg5V0oxZmNtSmUrZFZI?=
 =?utf-8?B?U0JZS0MvWnVYc3NtbUxMMUt3bE5kN2VqVm1kRjhxVi9VZUV1ZFVlb09mc3BW?=
 =?utf-8?B?VjN2MlZjUE9TQWdwM3FHSkFaMyt6bkxCUXN0bDJqWEVRVGZNQklkOXN0aVVk?=
 =?utf-8?B?N2NvVWxzbzNkYkIyTmwrZng5WXM3bGcvb2tjMkNHNWF6WHIyWjZSWlc2VVpw?=
 =?utf-8?B?M2czUWR4LzdoSi8wMnlmdTl1NFdUNlVjWmJ6anZpMTU1WVNKNWtUa1JZWW9V?=
 =?utf-8?B?T1c3NnBJNE5Jd0hnblZ0Zk85YjRxWi9nOFllMTlQN1NpUDdLNW50d1RtamRE?=
 =?utf-8?B?VTBlTzFaK1hHSVh0Z2pNeEg4VHA1Qlh3YklJTVNIZk9xYWdjQWtKUTY1YUZW?=
 =?utf-8?B?emdkcXp2QmdNSUhRa1A1b1k3WDBhd1ZMZTdJYTQ3RnlPNmx4VUg5c0RLUFho?=
 =?utf-8?B?ZnlLeXR0NWo5WmdmZGI2LzdWTXJjcFMzTkRRNWxraTIyUXdHNXBBa1RNUkQ5?=
 =?utf-8?B?WXhacmlwQW1OKzZaeXFRWWkzUG1nMk1GQWd2cE55NnpTMVpzWVVTdWJrRXhI?=
 =?utf-8?B?czdjak9URzdzQ1MrNWtjSnhiUVBwbmprWWlkcWlHMXpjbEswZWlBeWhWcDls?=
 =?utf-8?B?ZHhrTHB2aWRoRGhLVExJOWc4Nk5JdXNHMjNJdndZMnJWdEE0MXppbkJYYVdB?=
 =?utf-8?B?TU5lV2lpRjB6cGJrQkE4RG1hTzlzaGd0NHZLMjc5NEh2eTZUdDNDcEcrSUxs?=
 =?utf-8?B?Y3JFVWNuUld6M3lPNnhnME5RblQ5M3liVVk4TWNzbi9KVWRadHdPaCtLREEz?=
 =?utf-8?B?aC9qN2tsaWsvTHlld2I3Nm13RGJTTUxUenlrUHJYYVhCeXF5THpMSmZnQXJw?=
 =?utf-8?B?Tk9EUE1yRCtUdUg3SVNKeDNTaDZxQmhPd1JrbTR2bmtoR3o2SnZXR3hha3Vr?=
 =?utf-8?B?K2NEMW9aTGhNSHV2eVdkVnlweDlVUUhkNGFiNFp0WWEvSmU4RWRsY0RQZTc5?=
 =?utf-8?B?NitZblkwK21yYTV3dUZhSTlFUm9FK3J3Z2JFZUU0Nk15Qm9HdTVpREpKajlm?=
 =?utf-8?B?aFN2cFMyRERwbjZ4VkhYanlNVThJQk1mTk05M1lQaXFHbFBZS1NnbVlMVy9m?=
 =?utf-8?B?WGs0YStVZytXUDVMcnRKYzJtSExwZ3krTkt1VVZZUkk3dWNnUEdIVWdTY3Bk?=
 =?utf-8?Q?BeZupzR2SsR+YINRjvq6/to5K?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 575d7b8a-1949-46bd-cf3c-08db0ed434b5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 21:41:18.6837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NVevvHesFluYAyZQ8cJsmyt5TY1mLU4VrVqLEN3kgvjIIoPbNguf+vX1C8wfkTBclamRgG+sA4Fhxs7v1URE3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8199
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/02/23 19:03, Pierre-Louis Bossart wrote:
>
>>>> +/* AMD pm_runtime quirk definitions */
>>>> +
>>>> +/*
>>>> + * Force the clock to stop(ClockStopMode0) when suspend callback
>>>> + * is invoked.
>>>> + */
>>>> +#define AMD_SDW_CLK_STOP_MODE		1
>>>> +
>>>> +/*
>>>> + * Stop the bus when runtime suspend/system level suspend callback
>>>> + * is invoked. If set, a complete bus reset and re-enumeration will
>>>> + * be performed when the bus restarts.
>>>> + */
>>>> +#define AMD_SDW_POWER_OFF_MODE		2
>>> You need to clarify this mode, can you deal with device in-band wakes if
>>> the power is off?
>> On the Current platform, in-band wakes are not supported if the power is off.
> Humm, that's an important clarification.
>
> Does this mean your link0 will never use the POWER_OFF_MODE since it
> includes support for headset codecs and you want the ability to detect
> jacks status changes?
Yes. we will use CLK_STOP_MODE in runtime pm and system suspend
for Link0 when jack codec is connected over Link 0.
>
> Or is this more like CLK_STOP_MODE is used in runtime pm and POWER_OFF
> in system suspend?