Message-ID: <8d0b36c0-dfca-6d4b-076d-033f9ccda4c7@linux.microsoft.com>
Date:   Tue, 14 Feb 2023 14:17:52 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] x86/hyperv: Fix hv_get/set_register for nested bringup
To:     Wei Liu <wei.liu@kernel.org>
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, jinankjain@linux.microsoft.com,
        mikelley@microsoft.com, kys@microsoft.com,
        Tianyu.Lan@microsoft.com, haiyangz@microsoft.com,
        decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com
References: <1675980172-6851-1-git-send-email-nunodasneves@linux.microsoft.com>
 <Y+pJDbMu8WEPFnEm@liuwe-devbox-debian-v2>
Content-Language: en-US
From:   Nuno Das Neves <nunodasneves@linux.microsoft.com>
In-Reply-To: <Y+pJDbMu8WEPFnEm@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/13/2023 6:28 AM, Wei Liu wrote:
> A few comments on style.
> 
> On Thu, Feb 09, 2023 at 02:02:52PM -0800, Nuno Das Neves wrote:
>> hv_get_nested_reg only translates SINT0, resulting in the wrong sint
>> being registered by nested vmbus.
> 
> Please put a blank line between paragraphs.
> 

Ok

>> Fix the issue with new utility function hv_is_sint_reg.
>> While at it, improve clarity of hv_set_non_nested_register and hv_is_synic_reg.
>>
>> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
>> ---
>>  arch/x86/include/asm/mshyperv.h | 11 +++++++----
>>  arch/x86/kernel/cpu/mshyperv.c  |  8 ++++----
>>  2 files changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
>> index 9ae1a344536b..684c547c1cca 100644
>> --- a/arch/x86/include/asm/mshyperv.h
>> +++ b/arch/x86/include/asm/mshyperv.h
>> @@ -225,10 +225,13 @@ extern bool hv_isolation_type_snp(void);
>>  
>>  static inline bool hv_is_synic_reg(unsigned int reg)
>>  {
>> -	if ((reg >= HV_REGISTER_SCONTROL) &&
>> -	    (reg <= HV_REGISTER_SINT15))
>> -		return true;
>> -	return false;
>> +	return (reg >= HV_REGISTER_SCONTROL) &&
>> +	       (reg <= HV_REGISTER_SINT15);
>> +}
> 
> Please put a new line here.
> 

Ok

> I can fix these issues too if you don't end up sending a new version due
> to other issues.
> 
> Jinank, please take a look. The code looks sensible to me, but I would
> like you to have a look too.
> 

I'll wait for Jinank to take a look before posting another version...