Message-ID: <9b5972a2-63a9-6e2e-78aa-55ac112ef9ad@intel.com>
Date:   Tue, 14 Feb 2023 14:44:11 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.7.2
Subject: Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     <bhelgaas@google.com>, <nathan@kernel.org>,
        <ndesaulniers@google.com>, <trix@redhat.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <llvm@lists.linux.dev>, <tglx@linutronix.de>,
        <kevin.tian@intel.com>, <darwi@linutronix.de>
References: <20230214222400.GA3089902@bhelgaas>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230214222400.GA3089902@bhelgaas>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkVuN2FwaldSdDRuSkRIYWo2QUV0akhneXhOUkVvdXpIVFRuY2Y2Wk1HazRi?=
 =?utf-8?B?VkYyZDN0bURja1Y2RDRnZDRMaGpadVJDd0JuVk4wWWluV1l2SmtmQlFSbHZX?=
 =?utf-8?B?cEpCcVByY282Ly80OVNXSGxoOVphMVR0a1lnaWR4YXdPRGlySGpaWGdieEVC?=
 =?utf-8?B?eEhXMnFVUmRxcVN5WW5SUGNtbFVWOTltZ2daWi9xc2NsQTYvYllQdTV1ZG95?=
 =?utf-8?B?TXY0U2M4UnBtNU9KTHAwQjczV2d0RkxSNkxvNzhsZ1VlejFtemVRSUVPc2k5?=
 =?utf-8?B?MWQ2RWEwR0YxYllwclVKd09XTDQ2R21MenR0M2RkTktrZVo2c01QeU9yVUEr?=
 =?utf-8?B?endreGhrbVY1ZWhpR09TOHZlblV0WlFiNXBQNjR1SklCejJScTl1UngyUCtk?=
 =?utf-8?B?d2dlYUlHR0Fab0txMWZVOGxxMDlLK1N5RU1FVWZ4Zjk1RUJQL0ViS081c3A2?=
 =?utf-8?B?dHlUU25OdkdlWWk0S21NeWwwUDB2R1ZKT3dORXZCTzd4MGNKektZVDQ2M2hK?=
 =?utf-8?B?enN6bzR4cEcyNTYxZk1DbEpUbHozOHNUM3RjakYzK3NmaC8vZ0ZPbzVodUNB?=
 =?utf-8?B?em04OEpOTFpxUWZRbGF0U1lkK3lNMG91VGh6dVNpMktDQzl6ak9RTFdtY1Y0?=
 =?utf-8?B?eEdiTENFQ1o5MkxZWW5vZEVmY2ZIOWV0cEpIQVU5SE1zbklocnM5OTlnaDJ2?=
 =?utf-8?B?cWdiWFFCSHNuUEJmeG8vdVgvMlllNE5XeTl3VUNxU1dKbElXQnJlcW84RURv?=
 =?utf-8?B?cWZZc1lxK09zNXBZN2RuR0R4NDc3YlNjaWF2Y3hKb2EwSFdhV1NPYWNCOHdv?=
 =?utf-8?B?cjR2TUNqU290aGRacWR6YnZuSlFSeXFKSkkrL3YzaVQ5UXBNdjVVZjZrRG9r?=
 =?utf-8?B?SytzZU9kQXlOYzBlVUgvOFdTUG03T0tkVTJmTGkvSmQvY0Zra1UzRDluTjV0?=
 =?utf-8?B?QlVoUDRSYVYxVUFhNytQOUFxWnN5R2dscU9uaDFGWVFRZkJ6N1M0MVJvZkFk?=
 =?utf-8?B?a1pvR2ZJK01qTG4xL1NmUTJSS0NnN0FHaWxQeEUxRFR3Y3pjeTlxOUpzMWhp?=
 =?utf-8?B?T3BoTHpFT1ZGZlB4YmIvRnVVN2pGc0k2Nzlwek02VHhtZmlqQlIvcnFNcjZw?=
 =?utf-8?B?L3BTK0lIZHFEdnhvK1dJSjBGMnFWaTgwc0R5UDAyM01oWG9sSkkya0oramFp?=
 =?utf-8?B?YmFreUZNUWljSEhIL3Rzb0xwbFQ3QnozdVFaOWowSmtWWnBtRlU2K3I2bThN?=
 =?utf-8?B?NjdqcHVXalhEOWwyTWE2YVJzODFSbDRKMy9YMjJoSGc2cmJtRGZIQmpwUGlo?=
 =?utf-8?B?NksvRVdrMk5jSjJGMCtPL0pyMVh1c0NZZnVjUEVneWVwZVl1WlJ1Tk0vZ0Z0?=
 =?utf-8?B?SEpVdzJZTVhmUjJNWi9nUWFCaWpDTmpkRW8zQzNWbWtkUThvaGttbTFDWkJ2?=
 =?utf-8?B?bmtBdjRJMnd1eWlaajV3MFp3N3JWK2VPdXhGcWIrM0QvNEpCb1BOZVVEZ1Rj?=
 =?utf-8?B?amMzS1ZHVmZZODUzVmc4dDEzUzJySW85dXVNb0ZBOFdvbDNpMHQvQjN5YmtZ?=
 =?utf-8?B?eVpSRkx4WDMyNWZrZVJtRkNNQkVITlFQMmdFNTJoSUxOUXhaWDVzZUZBM0lW?=
 =?utf-8?B?dlhhbXViUkNmUlBoaXo1aGhpRW1Qcm1qL1BmUnUxMFJ0NHRucFhjZERRUThl?=
 =?utf-8?B?ckN5R3FkanNFM2lKenpUMEJ0eVg1ckllOWNabDdrdkVkZEtzWnhsRURzRjZV?=
 =?utf-8?B?dHVNU21JN1NLQy81eENMWnJ6L1hMMElSdTdpUTFUaFFiSEhrandPSERHTjdu?=
 =?utf-8?B?N3JocTdtRWtzdUVkOXp0aWZOTDhqSk1QY2k4MjJ2Q29TampNOXJIZFJ6YVF1?=
 =?utf-8?B?RzAyVHcrZ04zYndZaCtjN2kybjc1aE9Oc3kzeStDMjlVdGNQbzVhMzdHeGFj?=
 =?utf-8?B?azNGWDNsVEZOWDVUcWVPWWpMcHgrNXdrdHVHTjB0SCt2ays0ZTQwRFpuTFBQ?=
 =?utf-8?B?bGtYZzlpaWg0MzNiV1o0a0ZQY3lPc1NqbCttYmYxSS9nbkFrOXYxTmd1U2Ru?=
 =?utf-8?B?MUJ2NmN0TUxvcDUzckF0WjlDTm94QzhYZG1PYmlmdVhFNzVQc3c2UllpOGs0?=
 =?utf-8?B?MStPRVpjSENCNGtwT296ZVZKbkpHak02UG5XazFxMlFGQzY2L09Ha1JWcTMz?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8e39bda-7bdc-478f-6e09-08db0edcff95
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 22:44:14.8665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ATg5iVfsYGr7A1rMWk8UJZhGiNU5qbUsGrskmt80QUHEBtAZVXUcuOLslg5K7HlDAgsscgkENurWImXx5JvFvzlPR72//OyRhwpINsqT0EE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6350
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bjorn,

On 2/14/2023 2:24 PM, Bjorn Helgaas wrote:

> I think this should have a "Fixes:" tag to connect it with the commit
> that added pci_msix_alloc_irq_at() and pci_msix_free_irq().
> 

Thank you. I was not sure if a Fixes tag was needed since it does not
fix an existing issue but instead prevents a future issue.

> Looks like 34026364df8e ("PCI/MSI: Provide post-enable dynamic
> allocation interfaces for MSI-X").
> 

Correct.

> Thomas merged 34026364df8e, so it would be best if he took the fixup
> as well.

Thomas did pick this up in tip's irq/urgent branch. While doing so he
added the Fixes tag that you proposed and also improved the subject.

Thank you very much

Reinette