Date:   Tue, 14 Feb 2023 23:05:18 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc:     Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        jinankjain@linux.microsoft.com, mikelley@microsoft.com,
        kys@microsoft.com, Tianyu.Lan@microsoft.com,
        haiyangz@microsoft.com, decui@microsoft.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com
Subject: Re: [PATCH] x86/hyperv: Fix hv_get/set_register for nested bringup
Message-ID: <Y+wTrlz8nlk4h11/@liuwe-devbox-debian-v2>
References: <1675980172-6851-1-git-send-email-nunodasneves@linux.microsoft.com>
 <Y+pJDbMu8WEPFnEm@liuwe-devbox-debian-v2>
 <8d0b36c0-dfca-6d4b-076d-033f9ccda4c7@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8d0b36c0-dfca-6d4b-076d-033f9ccda4c7@linux.microsoft.com>
Precedence: bulk

On Tue, Feb 14, 2023 at 02:17:52PM -0800, Nuno Das Neves wrote:
> On 2/13/2023 6:28 AM, Wei Liu wrote:
> > A few comments on style.
> > 
> > On Thu, Feb 09, 2023 at 02:02:52PM -0800, Nuno Das Neves wrote:
> >> hv_get_nested_reg only translates SINT0, resulting in the wrong sint
> >> being registered by nested vmbus.
> > 
> > Please put a blank line between paragraphs.
> > 
> 
> Ok
> 
> >> Fix the issue with new utility function hv_is_sint_reg.
> >> While at it, improve clarity of hv_set_non_nested_register and hv_is_synic_reg.
> >>
> >> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> >> ---
> >>  arch/x86/include/asm/mshyperv.h | 11 +++++++----
> >>  arch/x86/kernel/cpu/mshyperv.c  |  8 ++++----
> >>  2 files changed, 11 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> >> index 9ae1a344536b..684c547c1cca 100644
> >> --- a/arch/x86/include/asm/mshyperv.h
> >> +++ b/arch/x86/include/asm/mshyperv.h
> >> @@ -225,10 +225,13 @@ extern bool hv_isolation_type_snp(void);
> >>  
> >>  static inline bool hv_is_synic_reg(unsigned int reg)
> >>  {
> >> -	if ((reg >= HV_REGISTER_SCONTROL) &&
> >> -	    (reg <= HV_REGISTER_SINT15))
> >> -		return true;
> >> -	return false;
> >> +	return (reg >= HV_REGISTER_SCONTROL) &&
> >> +	       (reg <= HV_REGISTER_SINT15);
> >> +}
> > 
> > Please put a new line here.
> > 
> 
> Ok
> 
> > I can fix these issues too if you don't end up sending a new version due
> > to other issues.
> > 
> > Jinank, please take a look. The code looks sensible to me, but I would
> > like you to have a look too.
> > 
> 
> I'll wait for Jinank to take a look before posting another version...
> 

If Jinank is happy with the change, I can just fix things up for you
before I commit this patch.

Wei.