IronPort-SDR: c5MNNm/LpaGIk5YNYAdVKUirvcPx5KyPcX+zqDznHZi3K60T6sS6blbuJZbQPOtyaH8gtM198h
 0YQXWMMdda0bErBs4PysmFq5S7X8Q/CrFvMH0EJbh/xMiLq4qC7O/GKyszsvuPSv3R0KMdAKpW
 R0kqoj712o7ZYzafcTxtUaWqrDhU/io+7eLqVez7rcg9gwNE/c8X5SnsKfLUunIowxrSpAaRSZ
 zi7nCvBrTaqznN011E9oiPrG0awPH2CFocdCif5RbzEvgs5Ipc6bcdEBgCZ4qaTOfmr9OMRxvA
 7jQ=
IronPort-SDR: IrdLYhsW1bXRxriRlZS3aZYVlTvZqGIUEGmDL9UIJC8r76yVGKaOQJYUrqraxHY+b1jPwBYKuQ
 ifBS+sr6A7w0bHEpMwOjiduv8W3iQZWZLgiPPwrHlY6HTtSXAUXdk7OAxUmw7PidkUhdCPanMu
 bps1uWz46iZmHaSAh/dIftSXzE3gRN1RdVSssLSrrBQnXwCYWl9cWuNXNaxdHLS+/ZWsJXadVV
 XoMH9NdSgArk9trmbYFQZSt7hzw3RBNebJCuIvm7z06TY1HQrJLzaGEFeN6ThV/xhrKbqX8Q+7
 A6Q=
WDCIronportException: Internal
Message-ID: <6ce57b8c-7f0c-f3d1-6938-c87fa4ab650d@opensource.wdc.com>
Date:   Wed, 15 Feb 2023 08:50:50 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 0/18] pata_parport: protocol drivers fixes and cleanups
To:     Ondrej Zary <linux@zary.sk>
Cc:     Christoph Hellwig <hch@lst.de>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Jens Axboe <axboe@kernel.dk>, Tim Waugh <tim@cyberelk.net>,
        linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230214230010.20318-1-linux@zary.sk>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230214230010.20318-1-linux@zary.sk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/15/23 07:59, Ondrej Zary wrote:
> This patch series fixes two bugs and cleans up pata_parport protocol drivers,
> making the code simpler with no changes in behavior (except logged messages).
> 
> Signed-off-by: Ondrej Zary <linux@zary.sk>

Sergey did send you some reviewed-by tags for some of the patches. But I
do not see any in this v2. Did you forget to add the tags to the reviewed
patches ? That is nice to do so that I do not have to keep track of
reviews across series versions...

> ---
> Changes in v2:
>  - added two bugfixes (first two patches)
>  - addressed Sergey's comments (mostly split patches)
> 
>  drivers/ata/pata_parport/aten.c                            |  45 ++++----------
>  drivers/ata/pata_parport/bpck.c                            |  86 ++++++++------------------
>  drivers/ata/pata_parport/bpck6.c                           | 107 ++++++++-------------------------
>  drivers/ata/pata_parport/comm.c                            |  52 +++++-----------
>  drivers/ata/pata_parport/dstr.c                            |  45 ++++----------
>  drivers/ata/pata_parport/epat.c                            |  48 ++++++---------
>  drivers/ata/pata_parport/epia.c                            |  55 +++++------------
>  drivers/ata/pata_parport/fit2.c                            |  37 ++++--------
>  drivers/ata/pata_parport/fit3.c                            |  39 ++++--------
>  drivers/ata/pata_parport/friq.c                            |  56 ++++++-----------
>  drivers/ata/pata_parport/frpw.c                            |  71 ++++++----------------
>  drivers/ata/pata_parport/kbic.c                            |  66 +++++++++-----------
>  drivers/ata/pata_parport/ktti.c                            |  38 ++++--------
>  drivers/ata/pata_parport/on20.c                            |  45 ++++----------
>  drivers/ata/pata_parport/on26.c                            |  52 ++++------------
>  drivers/ata/pata_parport/pata_parport.c                    |  31 +++++-----
>  {include/linux => drivers/ata/pata_parport}/pata_parport.h |  41 ++++---------
>  17 files changed, 271 insertions(+), 643 deletions(-)
> 
> 

-- 
Damien Le Moal
Western Digital Research