Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380DCC677F1 for ; Tue, 14 Feb 2023 23:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232647AbjBNX5e (ORCPT ); Tue, 14 Feb 2023 18:57:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbjBNX5W (ORCPT ); Tue, 14 Feb 2023 18:57:22 -0500 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2946D83F8 for ; Tue, 14 Feb 2023 15:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1676419041; x=1707955041; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kzhGYJXOf306NmlEn5opNfn1hoJ34kE37xo2DHXERFc=; b=KKS+BvwYq3LE4jrF1l6x3SFOcrF1ldJvBGmd/VfTILRYvIhlcNfIfaL1 jFDvnbvDcqAgTSLq3H+mJTyosa6Jgr8tHv9CkGH8lI26rOoMLJyu/+YqN b0xyUvxR//30RSivQy4s0pW0bGF5HQFXk9Ai86H23xt42iU0XDXrz4XHc 0N+kRTqmbCclw50naiAbegOze60VtnmL3A+2lWzDOZ8LXARj4vgcnAzZ2 SG2bKsgqbnZ/V0FfVPcIFqobouopAkXPrUH63NQa/Ao7TLGSriI2Yu38H NgvCqDcyMdv+Y8Z1kmkdydtWAqSQCPANEoD+/RbZuyscu4F1CnOEZbBmj A==; X-IronPort-AV: E=Sophos;i="5.97,298,1669046400"; d="scan'208";a="223111128" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Feb 2023 07:57:21 +0800 IronPort-SDR: dUpqRapfnkl0Dtjpkzb5ibs8kHLPtVgooaOWFHQ5XogcZ4QX8orrXpaA45RUS6nk17CqNgcTO3 Z2g8I5cxT0PGWxlYeJIGJADWM1/B61n4miHhzBpNSM3cDfmatDR762/MoaKikoZRuh4YMd9dWO X+NMQVDtJNQ/nlqDjlSqqF6YOObEh6XNN/NJm3R2VwPyLQ0xNMSh/OSzMU5mnBbFhTgBtadSRA SMVf+Em6w9NRCJGR2CZjP/p8CsDUPN0HGVUASRJQ7W3vafBplLm0jfjpylavtEHvMOGLiHWNqn uYo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 15:08:44 -0800 IronPort-SDR: iIrWsBN3a7VLy683GlBPXe5YCfqObOoP084wz8ZnmPlsf67u5aInHhwACYEuqDrrP0uoKcBDD3 gr98rPUZgvqIm9ITAUn4NUJhwI2qJtagxGbaxKqbGrY6loteWkFWp2RjMz0xOX/L5KttPCdn8e HlsZUAamYRFqjC9JG9xODXcyaxpRlMVSYclhvq7fgV+NYc+RmlqljDuOdVj0YHXJ3u9WB56N7r 8ybjBZIvoi18/QtuF9CCDQEU1xlz2xKudWC6XKWt2OOCVp/UmSAnnWqmd3uhA6jj41hIJHkZgC 3Cc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 15:57:22 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PGdRj1HxPz1RWxq for ; Tue, 14 Feb 2023 15:57:21 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1676419040; x=1679011041; bh=kzhGYJXOf306NmlEn5opNfn1hoJ34kE37xo 2DHXERFc=; b=qtkNz2Wpym57AeM1b+K40tUtO/VGjSmC/pa1V1esQDXbhLvdyNK KCxWZ30JUzdT2KyvLu/W4vsdZdU8LQZqmUsA+OsmmypSyNYILWQ+qHV5aRo3I8hk nsevRGb0wKA29ZVCKMO9SdPSd7yX77sEqAdQTQJTP5Y6etLUINbTCfzXs74T+5he nDk70r765uIM5/Wtorgc8G7qMvfSQVI1QfYPkAd6prG3s7FC6XnHLHP8nsEGHEDa 8p344hbSMQfLiezuVqdxOquyLD21qHSGp35EJj34jZsB7HBozt47ZybM1X9n7NHt F9QRJy9witvlnydLDUtHB1YEzkGAnnYc1Og== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bevNKrmn9YWA for ; Tue, 14 Feb 2023 15:57:20 -0800 (PST) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PGdRd292Tz1RvLy; Tue, 14 Feb 2023 15:57:17 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 08:57:16 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 2/9] PCI: rockchip: Write PCI Device ID to correct register Content-Language: en-US To: Rick Wertenbroek , alberto.dassatti@heig-vd.ch Cc: xxm@rock-chips.com, rick.wertenbroek@heig-vd.ch, stable@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Jani Nikula , Mikko Kovanen , Rodrigo Vivi , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20230214140858.1133292-1-rick.wertenbroek@gmail.com> <20230214140858.1133292-3-rick.wertenbroek@gmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230214140858.1133292-3-rick.wertenbroek@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/23 23:08, Rick Wertenbroek wrote: > Write PCI Device ID (DID) to the correct register. The Device ID was not > updated through the correct register. Device ID was written to a read-only > register and therefore did not work. The Device ID is now set through the > correct register. This is documented in the RK3399 TRM section 17.6.6.1.1 > > Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") > Cc: stable@vger.kernel.org > Signed-off-by: Rick Wertenbroek Reviewed-by: Damien Le Moal Tested-by: Damien Le Moal -- Damien Le Moal Western Digital Research