From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Thread-Topic: [PATCH 2/2] iommu/ioasid: Remove custom IOASID allocator
Thread-Index: AQHZPaM4X827KMb2AkC/Wtvslyhpl67NEuaAgAAlj4CAABH+gIAAItkAgAAafoCAAAb1gIAAAJAAgABvEpCAAI9BAIAAs59w
Date:   Wed, 15 Feb 2023 01:39:12 +0000
Message-ID: <BN9PR11MB5276695C57522C341CE1710B8CA39@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230210230206.3160144-1-jacob.jun.pan@linux.intel.com>
 <20230210230206.3160144-3-jacob.jun.pan@linux.intel.com>
 <Y+pjTR80bnl9rMK1@myrica> <20230213103455.02f3ac37@jacob-builder>
 <Y+qR5zC8ZOkVphgv@nvidia.com> <20230213134402.194ed7fd@jacob-builder>
 <Y+rFW80DUHvf3hQP@nvidia.com> <20230213154345.0f76eea1@jacob-builder>
 <Y+rLqg66BBPsfsRK@nvidia.com>
 <BN9PR11MB5276D28B4A4BF8DD3AF1A2828CA29@BN9PR11MB5276.namprd11.prod.outlook.com>
 <Y+uhAvXFq3YKcsuw@nvidia.com>
In-Reply-To: <Y+uhAvXFq3YKcsuw@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rIMUY1F2ve0BheyRGVDBf0FUCZcHx4Ev//ew0GTh85tnOkzDN4rSFy23bl5v?=
 =?us-ascii?Q?KvfhzZQzQ+jW+VQuaBZHvS76Y7xjV4oBrlNqqiXmtdL84KUcHzpcc/PdKyfr?=
 =?us-ascii?Q?JqVwF1QGd17b84etxPVz3eA/PrZkh0FnAzxZznExKy6X6txM814hEzK3hO+A?=
 =?us-ascii?Q?bOOeNeSwmtQMFtk7GbRBs/bfictb/KsRwMHJtJU2Z59fLFZ+uCYVQC48H4iZ?=
 =?us-ascii?Q?Luq4+OQrZebWOhXV05kPp+KWHDC9tZo8LiH9B7xXcJCIrDZJJyrEHgzA5baS?=
 =?us-ascii?Q?10xeg5enk9u9xcAka7JIHK6knoNnbUZfecumY6YTtqs+y8nVm6/9NOm4LWfx?=
 =?us-ascii?Q?xpthYYT8ZzWPG/TBMUumH5OiwAWZqiZ+0r2kUwl32HuTUFi1HDp/cIMQv2ik?=
 =?us-ascii?Q?4twvdVqYMsySIo9RVf+PXegXCClY9Hlnu/Vs7gJlR925NtWLb67UKKoON2r3?=
 =?us-ascii?Q?drbVcGLSVA55tpcmzVsRfwn+xIJbisyglnEC3mWEZGYdxx4OlpYMip18JpYH?=
 =?us-ascii?Q?ez918AfVUQmftWKGnEpM7lSpZL71GKMbbsShuRW3j5Sfyy7/LULKUy+NoE3w?=
 =?us-ascii?Q?WN6BUElNQdVM71z87IITwA8SWQU9HQskvqmJ+4Hh4dh5hK2ZRbNoo0X8HPw1?=
 =?us-ascii?Q?8mLopD6Xl/eQR0eVIBlAgd/cyzoAx5HSNF22EeCbY65VsjL//UwR/6OXThe3?=
 =?us-ascii?Q?g9ZBOb5/L9vig+im3LDkklfb7VJTV2Bvvmui6FLjH8QsUFKLHOmcgyf7DZ8+?=
 =?us-ascii?Q?R8AoCiFzz8PGyQJTOANe0oCE+ns66LuZTLIvthSb/b5I/6DuobEogDaYvzZC?=
 =?us-ascii?Q?jpTEi/O+KeTeZdrBZeDsko5mTxVUaCbSC9bZGIxctMbXgFzh/dCo+JlnZKlI?=
 =?us-ascii?Q?1H7u8UOBiWU2xTWQ7m/FNfGUbAfhCzBsvr5Jm0H+nsn7YNxhRwbueLElBh5y?=
 =?us-ascii?Q?LKk0ztZ7Dr+cSd4yZD52EQnjdXoJSPfM/iFQf7J05/EuNVHKcT54ngogziqg?=
 =?us-ascii?Q?WyKpDv4/uEtYiTh4bdolQIdF3BqA3VnY3lVyh5xNDOoJJjvn380fsV7qK6y5?=
 =?us-ascii?Q?9BHtUEUi2iglGRPVUvpjgpjVxxpO/MASb8T9iVBvONfQWLovVf8wjmBseTNn?=
 =?us-ascii?Q?yVuZV5geQEZQ2Ex8s+zvUwf/f0l2ALrjjZ8izAd9NOgROhO5KET0etxbZcsQ?=
 =?us-ascii?Q?ppD0RQdyYrVl6TJEE1FFRHMcPHiL0Rjsz7yM5vRgBVIv0kvo2DpZ6xDHA0DX?=
 =?us-ascii?Q?ckC0FXfp5FHMEjNDK9VGPOtJD4A2kOetjhFJhlDsDND6nZEKyVxGr/4gM6M3?=
 =?us-ascii?Q?MwORWL2DPOjvmFfnIrh8xRC/PoTUP+c+PaR/0tN/T/GBu7NhYjVK4WuxKlN6?=
 =?us-ascii?Q?PMi8FUDWjvgFj3jiW6XQCV8tHu0qAdYID0Gnu+zbmFQxJw1NcanCYIxViWLB?=
 =?us-ascii?Q?ESGshINAO9pRN2Mi0X223VMmiC0D3RIsegUQk3h/kuXUe+2ztNERPKgm12ny?=
 =?us-ascii?Q?GUGFQffUp/kmg21oEAO9nA0eSs8sYm9yRrTucykzdySq8sxKS/De/4MOLgVr?=
 =?us-ascii?Q?JQmHzxEMfscQoXFbC8J+m9PBZaFbMz+K39S0DvUP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 346d444a-2ed8-4824-9baa-08db0ef57113
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2023 01:39:12.9787
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dH6zkd8QNv/UmxlZ4ZXjpbuP9tm2t06eimVl2CU5N8ktfRORC6N9Jt/kzeMJV0O02A36o5KlBv1RVbAnm+PQxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7459
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Tuesday, February 14, 2023 10:56 PM
>=20
> On Tue, Feb 14, 2023 at 06:26:25AM +0000, Tian, Kevin wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > Sent: Tuesday, February 14, 2023 7:46 AM
> > >
> > > > > So if a cgroup comes it is just a matter of putting charges in th=
e
> > > > > right place which is auditable by looking at calls to attach pasi=
d
> > > > > functions.
> > > > shouldn't we charge cg during allocation? Or it might be too early =
for
> > > > iommufd so we have to wait  until attach?
> > >
> > > We need to sort this all out. I would expect that iommufd will have a=
n
> > > allocation API.
> > >
> >
> > yes.
> >
> > btw presumably iommu_global_pasid_ida should be move to iommu.c
> > since it will be used beyond sva.
>=20
> Yeah, maybe, I'd think about moving it when we get patches to use it
> more than SVA.
>=20

that also works.