Message-ID: <ca611ede-3797-b7b1-6261-80c7e8adde3f@infradead.org>
Date:   Tue, 14 Feb 2023 19:25:44 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2] fixed typos on selftests/bpf
Content-Language: en-US
To:     Taichi Nishimura <awkrail01@gmail.com>
Cc:     andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        davem@davemloft.net, deso@posteo.net, haoluo@google.com,
        hawk@kernel.org, joannelkoong@gmail.com, john.fastabend@gmail.com,
        jolsa@kernel.org, kpsingh@kernel.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        llvm@lists.linux.dev, martin.lau@linux.dev, mykolal@fb.com,
        nathan@kernel.org, ndesaulniers@google.com, netdev@vger.kernel.org,
        sdf@google.com, shuah@kernel.org, song@kernel.org, trix@redhat.com,
        yhs@fb.com, ytcoode@gmail.com
References: <f8f3e8df-f707-28f3-ab0f-eec21686c940@infradead.org>
 <20230215032122.417515-1-awkrail01@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230215032122.417515-1-awkrail01@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/14/23 19:21, Taichi Nishimura wrote:
> Hi Randy,
> 
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>

Looks good. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
>  tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>   *
>   *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>   *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant
>   * return value, and calling code works while still being "generic" to
>   * IPv4 and IPv6.
>   */

-- 
~Randy