Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D81C636CC for ; Wed, 15 Feb 2023 03:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbjBODpy (ORCPT ); Tue, 14 Feb 2023 22:45:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjBODpv (ORCPT ); Tue, 14 Feb 2023 22:45:51 -0500 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A2032311EB; Tue, 14 Feb 2023 19:45:43 -0800 (PST) X-MailGates: (flag:4,DYNAMIC,BADHELO,RELAY,NOHOST:PASS)(compute_score:DE LIVER,40,3) Received: from 192.168.10.46 by mg.richtek.com with MailGates ESMTP Server V5.0(23460:0:AUTH_RELAY) (envelope-from ); Wed, 15 Feb 2023 11:45:32 +0800 (CST) Received: from ex4.rt.l (192.168.10.47) by ex3.rt.l (192.168.10.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Wed, 15 Feb 2023 11:45:31 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex4.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.20 via Frontend Transport; Wed, 15 Feb 2023 11:45:31 +0800 Date: Wed, 15 Feb 2023 11:45:31 +0800 From: ChiYuan Huang To: Krzysztof Kozlowski CC: Sebastian Reichel , ChiaEn Wu , , , , , , Subject: Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name Message-ID: <20230215034531.GA7407@linuxcarl2.richtek.com> References: <20230213205321.xrhvrdqy5ksiagbv@mercury.elektranox.org> <75d37ae7-3632-a195-b12b-44e8a940be4a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <75d37ae7-3632-a195-b12b-44e8a940be4a@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Krzysztof/Sebastian: On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote: > On 13/02/2023 21:53, Sebastian Reichel wrote: > > Hi, > > > > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote: > >> Revise RT9467 compatible name from "richtek,rt9467-charger" to > >> "richtek,rt9467" > >> > >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger") > >> Signed-off-by: ChiaEn Wu > >> --- > > > > Is there a new version of this fixing the issues pointed out by Krzysztof? > > Also I think the filename and $id should be changed to richtek,rt9467.yaml > > in addition to the compatible change. > > Yes, indeed. > From the current discussion, there're things to be fixed. 1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'. 2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml' Anything else? like as changing source code filename from 'rt9467-charger.c' to only 'rt9467.c"? And we'll submit a new one to fix it in these two days. Thanks. > Best regards, > Krzysztof >