MIME-Version: 1.0
References: <Y+YVy7RaxnXokJ3l@ubun2204.myguest.virtualbox.org> <49a3244a-1416-12c4-9dfa-661cf5b5d569@amd.com>
In-Reply-To: <49a3244a-1416-12c4-9dfa-661cf5b5d569@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 14 Feb 2023 23:24:36 -0500
Message-ID: <CADnq5_M5JeSU4WwkbWM55HKPtaxsjkJ29JScdWq=OgHkBfNdEw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Remove duplicate/repeating expressions
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     Deepak R Varma <drv@mailo.com>, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Feb 10, 2023 at 2:37 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2/10/23 05:00, Deepak R Varma wrote:
> > Remove duplicate or repeating expressions in the if condition
> > evaluation. Issue identified using doubletest.cocci Coccinelle semantic
> > patch.
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c    | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> > index 4b8f5fa0f0ad..ae89760d887d 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> > @@ -2335,8 +2335,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> >
> >                       if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.ForcedOutputLinkBPP[k] != 0)
> >                               mode_lib->vba.DSCOnlyIfNecessaryWithBPP = true;
> > -                     if ((mode_lib->vba.DSCEnable[k] || mode_lib->vba.DSCEnable[k])
> > -                                     && mode_lib->vba.OutputFormat[k] == dm_n422
> > +                     if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.OutputFormat[k] == dm_n422
> >                                       && !mode_lib->vba.DSC422NativeSupport)
> >                               mode_lib->vba.DSC422NativeNotSupported = true;
> >
> > @@ -3639,7 +3638,6 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> >                       if (mode_lib->vba.SourcePixelFormat[k] != dm_444_64
> >                                       && mode_lib->vba.SourcePixelFormat[k] != dm_444_32
> >                                       && mode_lib->vba.SourcePixelFormat[k] != dm_444_16
> > -                                     && mode_lib->vba.SourcePixelFormat[k] != dm_444_16
> >                                       && mode_lib->vba.SourcePixelFormat[k] != dm_444_8
> >                                       && mode_lib->vba.SourcePixelFormat[k] != dm_rgbe) {
> >                               if (mode_lib->vba.ViewportWidthChroma[k] > mode_lib->vba.SurfaceWidthC[k]
>