Date:   Tue, 14 Feb 2023 20:25:08 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Zhao Liu <zhao1.liu@linux.intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthew Auld <matthew.auld@intel.com>,
        Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Nirmoy Das <nirmoy.das@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>,
        "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
        Zhenyu Wang <zhenyu.z.wang@intel.com>,
        Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with
 kmap_local_page()
Message-ID: <63ec5ea4d162d_18bf5929443@iweiny-mobl.notmuch>
References: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fw7SdPYFXXBLC0XRpLbbL8EiTk3XlkAu9m+Zz6mBoXzUhMQha8ijDfVbgvX/?=
 =?us-ascii?Q?4v/dg/vXFMoX9C59YCZW32xu8jcqxXo5HuBo0rhT2D1TVjcKOmIdJ9dXkd4P?=
 =?us-ascii?Q?o24OO18KqGJ+Bhtrsnj6WmuCweFtrsqKoIDdV+k2zFtOAuGl+EpFWIBufga2?=
 =?us-ascii?Q?6ehzcCgsxnccai0+aYHwds2DKgbS0Sl+wkOXSl03xHAZQv8+OtXfcUuV3xK5?=
 =?us-ascii?Q?pjKspMM2RMnFULdnTawTnIx/wciCn0uBUtg8JyWRXChGrN628eogth3LcDuH?=
 =?us-ascii?Q?eLVKGDJ3HpisswL8EyKHnTPRlIllYS+BcaBsARfNB3GCCM+GzmjQZdYWZvMT?=
 =?us-ascii?Q?QRmR+IamnDjcu8w9Rov9FPe6StSzBL+30jwQhb2esvtBmbBbBmdVyTh8myqc?=
 =?us-ascii?Q?WHKhOd1QUZ9DZ1NLf/zq3/94SO84yBgzR8t6/CGMpg2njc0IvFT9+eFpC0p5?=
 =?us-ascii?Q?zuyjXrsUSIOUxVGHFlTDUMzdL+9fS/lg3VzL+KlDjQq4bdn1bRn4sXEilyvt?=
 =?us-ascii?Q?hyoZ9vGJvsD+0NH85eu4EsYUafDmKOoZTnS05w0mVReVXN7/eJ7h/ClOM/kq?=
 =?us-ascii?Q?FDAG0whOdgjLglX4MceUCvnZDu0ag1x3ZJLFJW3GbDHz2vwNWCXs1sNu90hz?=
 =?us-ascii?Q?Vgc1V9VYgiJkKlQBOeLFcv3O9JL4aEdkZL5NJQBcN+ned31tzmThnj+5pPMG?=
 =?us-ascii?Q?IK1wkHnJcA+cMrGd/550s5JU3YUCf/n0trE3vBm6lhMmxkyz/TQ3lGfJ9yQV?=
 =?us-ascii?Q?eJXnIHIEczo2aX4nsjKKHnso09J/Yfewvgir1B6ErGK6NBPfV4L7BuMQSNuQ?=
 =?us-ascii?Q?+pZ4iNfmOSHL+58d+shmMXNYq1xD8IYIzo3ukJupFl4pCn+vUEvBl+VssKOI?=
 =?us-ascii?Q?V5HLfwuRSfF7bkrNBZWZodNcXWqadXRt5JiVPoJVydJXn/5XHs3X9eXSbNCm?=
 =?us-ascii?Q?ccUV0Kf8259q4EKw1hVXG+Y2XEXTBWConNAM6DEBH1hjcUFGm/hBXLFQGTPk?=
 =?us-ascii?Q?iGePcamH1vK6RiVhKy/mE+8C988FMAL6CbQpb2n50iiMrMyZTlEl5s971lnt?=
 =?us-ascii?Q?o22d1w093OJpwoPJrTQXRHtgPzTwSebpPaux4hyW8CS8zYD2taU9TCOusyU/?=
 =?us-ascii?Q?1ThqNQXodIP89f5SOfk7DNrEGYq9rQZS0e46XcevFc/Qm0HZsflPtTQxsGVD?=
 =?us-ascii?Q?qmpm+xAo43/pPAd3fO4IMtwqGeMjdR20L0ZR5T6uRTxxj8JM3/aNnaZvRwrh?=
 =?us-ascii?Q?PL77K8a3Bqg7JcjR6hwc49Ua5PybEyZitfHeuPz8ingFKFnLsl4LN9HuEnsN?=
 =?us-ascii?Q?miIpRwssWE+W5DqKcVAQehA2X5V+L9vlqc8k21wYFoaqjvYSRHiwmRER+r7H?=
 =?us-ascii?Q?shFtQ6BJ+K/cfIm6yOgp4cD6Kjzk8nPgIOob8C9VeLKAogJcS7s2ggXtUyCp?=
 =?us-ascii?Q?vXCxNHgLou56V8+WuisOHlTJRN/FPiFva0sDFjTWnDJGDWHLje7KzoZtz5iE?=
 =?us-ascii?Q?yCshaXJ6y5ejSrc41DVirYVxeP5Vwq9lqOaPnztFsqOx6+hmYbd1NpcKlJ+P?=
 =?us-ascii?Q?bUAjCaSkWTxsJR7oA/kcOseTvldcbQvtWFeoyNow?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbbb5879-34f2-4188-a19f-08db0f0ca19b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 04:25:13.1537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q3dHvuBDhL6tj3Nc/9JZtM0RsV4l80Jdb0HR5YLHLhxoYHnkQIGuWKxLXA3O69VSrd1HeXw19wHYbecQYrdGGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8231
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].

Zhao,

Was there ever a v2 of this series?  I'm not finding it on Lore.

Thanks,
Ira

> 
> In the following patches, we can convert the calls of kmap_atomic() /
> kunmap_atomic() to kmap_local_page() / kunmap_local(), which can
> instead do the mapping / unmapping regardless of the context.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> ---
> Zhao Liu (9):
>   drm/i915: Use kmap_local_page() in gem/i915_gem_object.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c
>   drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c
>   drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c
>   drm/i915: Use kmap_local_page() in i915_cmd_parser.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
> 
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c       | 10 +++++-----
>  drivers/gpu/drm/i915/gem/i915_gem_object.c           |  8 +++-----
>  drivers/gpu/drm/i915/gem/i915_gem_phys.c             |  8 ++++----
>  drivers/gpu/drm/i915/gem/i915_gem_shmem.c            |  6 ++++--
>  drivers/gpu/drm/i915/gem/selftests/huge_pages.c      |  6 +++---
>  .../gpu/drm/i915/gem/selftests/i915_gem_coherency.c  | 12 ++++--------
>  .../gpu/drm/i915/gem/selftests/i915_gem_context.c    |  8 ++++----
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c             |  5 +----
>  drivers/gpu/drm/i915/i915_cmd_parser.c               |  4 ++--
>  9 files changed, 30 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
>