Date:   Tue, 14 Feb 2023 20:42:33 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Tyler Hicks <code@tyhicks.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Christian Brauner <brauner@kernel.org>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Muchun Song" <muchun.song@linux.dev>, <ecryptfs@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] fs/ecryptfs: Replace kmap_atomic() with kmap_local_page()
Message-ID: <63ec62b9a1285_18bf5929449@iweiny-mobl.notmuch>
References: <20230103190259.30944-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230103190259.30944-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PobANa45yv4bcKt8ueycI4V8KeBIaOg77nHmGwX4NjfA8mPYJlPo73mJKxCo?=
 =?us-ascii?Q?Q7B7nCbCgGQzwePdXGqbfY6IU9zSwSBjFKziz3IXoQNCtKHCr8EiJN0J9Kiw?=
 =?us-ascii?Q?D4TfZ2GepDh4MkTFojR6T9e0/8yXA1GLmkS3v13TtFrdJYGs9y8CoRVFPurh?=
 =?us-ascii?Q?kJkEN+4U+pPhLUTBPXBcc6XKLzC/hKqawXC+0P8t0FGv8goAxM0+fCw2vPkV?=
 =?us-ascii?Q?QPI0RvcH/6Hzsj9+WJz2Bb4xS5KfuJ8Kj0EFk6YbNHVUCa7UjdC0iEOi08lJ?=
 =?us-ascii?Q?kzy0iMTkZBfWKqYVdOOyCXFttoxWFi05AmCXlbo+QwTfmO7SSotk9/E7chvw?=
 =?us-ascii?Q?cZFToXdUB66xLVjIU5dw0sgtbsIwbIoeiQB946KcJvzTpHJKfBNZNBq80vOA?=
 =?us-ascii?Q?YytovDqvtQH/+w+FjrN7UqHY/J0wbBiwCHUPaQGJaQ2/5qrxUnZ5ewOVwJIp?=
 =?us-ascii?Q?qodQ9gf6mOLVnHOFJblmLGXUJB8YApk7CqbpvWkbHbS/GrEeWpmGYFISIUOW?=
 =?us-ascii?Q?Pk4rJUl6E0fHdrGeBd15nEPBolfoewEvZMtv45mOazuNpoqu6IkesEyU2z4/?=
 =?us-ascii?Q?ge+6j7ywJ4GVSwxFdgwKpMn8TD2qslTNVGzRbeq5IZCGWnwbCfD/E+4nR9kS?=
 =?us-ascii?Q?w05R6JHc1IMSzbY/62lQm9WoJFFLNyOkz4JLmtY+qVguLe7zCGzT+7EJP1Jp?=
 =?us-ascii?Q?t9pWZDwtW0eraJFx6QXM16BoBFvFlbdTff1PvjxkUt5GVozaqZgDBbEozM7p?=
 =?us-ascii?Q?i9/VQ1Uz+9B0tj9b8cFLduEKQt2zueuAAVfuwIxXhTWcuG/X3BGRlhkzBYfV?=
 =?us-ascii?Q?nK20buDUNEAbA6Qib/594jLQKAyQ/HKtOo827t6Ktu7Ug0xOioo96a3uH7Wn?=
 =?us-ascii?Q?4bZAivs2d2EntljtbctHihWsWSHVfV7qQI5GKG+jvs4Ji0zqlJp9w7zadOEw?=
 =?us-ascii?Q?FFI9lYGYF8lUXuM4wuj+3UKjesnMjOzOcLvSaOq39ZS6K6IJD7P/Q0xuGbsy?=
 =?us-ascii?Q?jZAM2lki5X0vmdCZ3ydhibL89xpR1JYCOGZuLqhB+SR/QXmxPDguYJt7gU5D?=
 =?us-ascii?Q?LvEc1Rg6ntkyiDcBdlAXc6oM94FLuAFwFhUMXe0ah7hfIYyjPNjgKQwhVU/V?=
 =?us-ascii?Q?hDn9JiTuJBKlMlnxL90nRrUa8SXfxevSGPi4tBxliy/E1H+uvcXf/AFAsZCZ?=
 =?us-ascii?Q?p3mcMK2ZTaaJ0xrVDi2FYINNcYbMM2mutByI+UkxDAyUpInS14E0SBFnnTfK?=
 =?us-ascii?Q?ysI9iu250fSxkD7tQ7BrR2ZUwOrCcfQrwiyXz8v4EjytoEfTy1TycsGQVW0b?=
 =?us-ascii?Q?ayIXL8FDi6einOWPcuhOI6fW9oF51yJFZNNOdhM5atDgubdxFvtjkdU7QncA?=
 =?us-ascii?Q?3oBwXVfKwcYDiTuJjvd65ddNx4RPChdKIW9JuwL8nIrJi4rmeRljoVpa+sqD?=
 =?us-ascii?Q?YCFDOsRHeYDm8Cg85k6ObH3AFxJs+0XcNv0BbJmx27mxf/sIQtYsR7foC7oB?=
 =?us-ascii?Q?ftOdrdvyRDeM5p5S+lgH+eD1HWjhNo208ESiwA7P3yVr/NpZDPZLcArDK7sa?=
 =?us-ascii?Q?JE8cDVb8ZLz0e7+qBfCQvz9dDB7bYOfoNTqalgIA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4a23f79-c712-41d2-95d1-08db0f0f0fe8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 04:42:37.0914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uod4c1l5hUEKbKsSAmd0q6QGmL/cs7eRDnrOVAPLartqgp/O+hhQua4AAxFIK5p50Ss/Jyoc9Wogq3MGBhf0MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7841
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fabio M. De Francesco wrote:
> kmap_atomic() is deprecated in favor of kmap_local_page(). Therefore,
> replace kmap_atomic() with kmap_local_page() in ecryptfs_write().
> 
> kmap_atomic() is implemented like a kmap_local_page() which also disables
> page-faults and preemption (the latter only for !PREEMPT_RT kernels).
> 
> The code within the mapping/un-mapping in ecryptfs_write() does not
> depend on the above-mentioned side effects.
> 
> Therefore, a mere replacement of the old API with the new one is all that
> is required (i.e., there is no need to explicitly add any calls to
> pagefault_disable() and/or preempt_disable()).
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  fs/ecryptfs/read_write.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ecryptfs/read_write.c b/fs/ecryptfs/read_write.c
> index 5edf027c8359..3458f153a588 100644
> --- a/fs/ecryptfs/read_write.c
> +++ b/fs/ecryptfs/read_write.c
> @@ -140,7 +140,7 @@ int ecryptfs_write(struct inode *ecryptfs_inode, char *data, loff_t offset,
>  			       ecryptfs_page_idx, rc);
>  			goto out;
>  		}
> -		ecryptfs_page_virt = kmap_atomic(ecryptfs_page);
> +		ecryptfs_page_virt = kmap_local_page(ecryptfs_page);
>  
>  		/*
>  		 * pos: where we're now writing, offset: where the request was
> @@ -163,7 +163,7 @@ int ecryptfs_write(struct inode *ecryptfs_inode, char *data, loff_t offset,
>  			       (data + data_offset), num_bytes);
>  			data_offset += num_bytes;
>  		}
> -		kunmap_atomic(ecryptfs_page_virt);
> +		kunmap_local(ecryptfs_page_virt);
>  		flush_dcache_page(ecryptfs_page);
>  		SetPageUptodate(ecryptfs_page);
>  		unlock_page(ecryptfs_page);
> -- 
> 2.39.0
>