Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD72C636D4 for ; Wed, 15 Feb 2023 04:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229460AbjBOEog (ORCPT ); Tue, 14 Feb 2023 23:44:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbjBOEod (ORCPT ); Tue, 14 Feb 2023 23:44:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A53A5FE for ; Tue, 14 Feb 2023 20:44:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83BA661A1E for ; Wed, 15 Feb 2023 04:44:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B73B1C433D2; Wed, 15 Feb 2023 04:44:28 +0000 (UTC) Date: Tue, 14 Feb 2023 23:44:26 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: x86@kernel.org, Nadav Amit , Borislav Petkov , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH -tip v2] x86/kprobes: Remove unneeded casting from immediate value Message-ID: <20230214234426.2376ffd1@rorschach.local.home> In-Reply-To: <167641982421.1677831.18379341946856978545.stgit@mhiramat.roam.corp.google.com> References: <167641982421.1677831.18379341946856978545.stgit@mhiramat.roam.corp.google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2023 09:10:24 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Remove unneeded casting from immediate value assignments for relative > jump offset. Since the immediate values in the 'insn' data structure are > assigned from immediate bytes as a signed value to insn.immediate.value > by insn_field_set(). Thus, if we need to access that value as a signed > value (in this kprobe's case), we don't need to cast it. > This is a kind of clean up (should not change behavior) follows Nadav's > bugfix. > > Link: https://lore.kernel.org/all/20230208071708.4048-1-namit@vmware.com/ > > Signed-off-by: Masami Hiramatsu (Google) > --- > Changes in v2: > - Remove meaningless immediate size branches too. > Reviewed-by: Steven Rostedt (Google) -- Steve