Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3459C636D4 for ; Wed, 15 Feb 2023 05:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230422AbjBOFv0 (ORCPT ); Wed, 15 Feb 2023 00:51:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbjBOFvX (ORCPT ); Wed, 15 Feb 2023 00:51:23 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB7B2B0A1 for ; Tue, 14 Feb 2023 21:51:22 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 50CAD67373; Wed, 15 Feb 2023 06:51:19 +0100 (CET) Date: Wed, 15 Feb 2023 06:51:19 +0100 From: Christoph Hellwig To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Zhenyu Wang , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation Message-ID: <20230215055119.GA29717@lst.de> References: <20230215044533.4847-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215044533.4847-1-rdunlap@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2023 at 08:45:33PM -0800, Randy Dunlap wrote: > Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) > into a list of other symbols that do have a dependency (on DRM_I915) > breaks the driver menu presentation in 'make *config'. > > Relocate the DRM_I915_GVT symbol so that it does not cause this > problem. Looks good: Reviewed-by: Christoph Hellwig