Date:   Wed, 15 Feb 2023 11:33:28 +0530
From:   Vishal Chourasia <vishalc@linux.vnet.ibm.com>
To:     Phil Auld <pauld@redhat.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        mingo@redhat.com, peterz@infradead.org, ritesh.list@gmail.com,
        srikar@linux.vnet.ibm.com, sshegde@linux.ibm.com,
        vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH v2] sched/debug: Put sched/domains files under the
 verbose flag
Message-ID: <Y+x1sO2zclDex3UI@li-05afa54c-330e-11b2-a85c-e3f3aa0db1e9.ibm.com>
References: <20230119150758.880189-1-pauld@redhat.com>
 <20230120163330.1334128-1-pauld@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="r3ixgbmMDEDfIj5d"
Content-Disposition: inline
In-Reply-To: <20230120163330.1334128-1-pauld@redhat.com>
Precedence: bulk


--r3ixgbmMDEDfIj5d
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 20, 2023 at 11:33:30AM -0500, Phil Auld wrote:
> The debug files under sched/domains can take a long time to regenerate,
> especially when updates are done one at a time. Move these files under
> the sched verbose debug flag. Allow changes to verbose to trigger
> generation of the files. This lets a user batch the updates but still
> have the information available.  The detailed topology printk messages
> are also under verbose.
>=20
> Discussion that lead to this approach can be found in the link below.
>=20
> Simplified code to maintain use of debugfs bool routines suggested by
> Michael Ellerman <mpe@ellerman.id.au>.
>=20
> Signed-off-by: Phil Auld <pauld@redhat.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: Vishal Chourasia <vishalc@linux.vnet.ibm.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@li-05afa54c-330e-11b2-=
a85c-e3f3aa0db1e9.ibm.com/
> ---
>=20
>  v2: fix comment typo and use cpumask_empty()
>=20
>  kernel/sched/debug.c | 52 +++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 49 insertions(+), 3 deletions(-)

Thanks for the Patch.

Tested-by: Vishal Chourasia <vishalc@linux.vnet.ibm.com>

Base Tag       : v6.2-rc8 =20
Patch          : [V2] sched/debug: Put sched/domains files under the verbos=
e flag


# time ppc64_cpu --smt=3Doff   | When kernel is built =20
                             | with the patch, time to
real    17m54.246s           | smt=3Doff is 17m54s.   =20
user    0m0.013s             |
sys     0m4.661s             |

System Configuration:

Architecture    : ppc64le
CPUS            : 1600
Machine         : Power10
Thread per core : 8
Sockets         : 15

- debug files are not created for the case where kernel command line string
  lacks sched_verbose parameter.
- When sched_verbose is passed as kernel commandline parameter, kernel expo=
rts
  /sys/kernel/debug/sched/verbose file which controls creation of the debug
  files.
  + setting Y/N to this file enables/disables creation of debug files durin=
g CPU
    hotplug operation.

Below is the table listing time taken to perform smt=3Doff operation under
different settings.

+--------------------------+---------------+---------+------------+
| kernel                   | sched_verbose | verbose | time       |
+--------------------------+---------------+---------+------------+
| 6.2.0-rc8-patch-applied+ | YES           | N       | 16m58.196s |
| 6.2.0-rc8-patch-applied+ | YES           | Y       | 33m21.774s |
| 6.2.0-rc8-patch-applied+ | NO            | NA      | 17m54.246s |
| 6.2.0-rc8                | NO            | NA      | 30m11.344s |
+--------------------------+---------------+---------+------------+

-- vishal.c
--r3ixgbmMDEDfIj5d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEyetz6oh8pzQ87ZNz8y5vG2Pik+wFAmPsdbAACgkQ8y5vG2Pi
k+wg/wf/ReooXBhKK8NoBdjxvjIO2xJ9Epg3wrQl/GdFmvBJ9XGYx+VIcd0sBV0l
a880oc3xCkRxnOdDfNYQyqq5WjNdu9YeU4AmbXdOAvd3SJvstirlDFCTJNSaOn1F
KJOXZRkcrBP6Ykk3infiDpX6E/K8dBMXVCrfcRg6DHG2Y+aGJtiAUkYOoGz3OmuA
A7/j00bzn3iFbkmWyh1TMaT77qBIJgs6QM4Zl1mfGCIBiNoLCxHlElbeF7t0tjFC
Jk+E5LwDG2VWZpeC5qlKT6mpchVZTLDVByhEz0ChcQ7N685MH3EcmEkeKLTj1tPF
m1JESxkfHoUcUI1dso4+Xd1jTbzPKQ==
=uFXu
-----END PGP SIGNATURE-----

--r3ixgbmMDEDfIj5d--