Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758551AbXIFUt3 (ORCPT ); Thu, 6 Sep 2007 16:49:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756597AbXIFUtT (ORCPT ); Thu, 6 Sep 2007 16:49:19 -0400 Received: from 74-93-104-98-Washington.hfc.comcastbusiness.net ([74.93.104.98]:40783 "EHLO picasso.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755500AbXIFUtT (ORCPT ); Thu, 6 Sep 2007 16:49:19 -0400 Date: Thu, 06 Sep 2007 13:48:31 -0700 (PDT) Message-Id: <20070906.134831.39160997.davem@davemloft.net> To: mathieu.desnoyers@polymtl.ca Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, help@myri.com Subject: Re: 2.6.23-rc4-mm1 myri10ge module link error on x86_64 From: David Miller In-Reply-To: <20070906.134038.85411315.davem@davemloft.net> References: <20070831215822.26e1432b.akpm@linux-foundation.org> <20070906193751.GA4518@Krystal> <20070906.134038.85411315.davem@davemloft.net> X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 46 From: David Miller Date: Thu, 06 Sep 2007 13:40:38 -0700 (PDT) > From: Mathieu Desnoyers > Date: Thu, 6 Sep 2007 15:37:51 -0400 > > > I got a link error on myri10ge when building 2.6.23-rc4-mm1 on x86_64 : > > > > ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined! > > ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined! > > make[2]: *** [__modpost] Error 1 > > make[1]: *** [modules] Error 2 > > make: *** [_all] Error 2 > > myri10ge needs some LRO ifdeffery. Actually the fix is even simpler, missing select in Kconfig. I've checked the following fix for this into the net-2.6.24 tree. commit 9fd380e892e078b582920325357292c07eeeecc9 Author: David S. Miller Date: Thu Sep 6 21:44:36 2007 +0100 [MYRI10GE]: Need to select INET_LRO. Signed-off-by: David S. Miller diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index b92b7dc..7d1a84e 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2496,6 +2496,7 @@ config MYRI10GE depends on PCI select FW_LOADER select CRC32 + select INET_LRO ---help--- This driver supports Myricom Myri-10G Dual Protocol interface in Ethernet mode. If the eeprom on your board is not recent enough, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/