Date:   Wed, 15 Feb 2023 07:28:39 +0000
From:   Gary Guo <gary@garyguo.net>
To:     David Gow <davidgow@google.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        "=?UTF-8?B?QmrDtnJu?= Roy Baron" <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] rust: kernel: Mark rust_fmt_argument as extern "C"
Message-ID: <20230215072839.6cb94bbb.gary@garyguo.net>
In-Reply-To: <20230214224735.264894-1-davidgow@google.com>
References: <20230214224735.264894-1-davidgow@google.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oWlhfZpclnvF5DJQWDnRbBekD4miZXkwD1uSY7Caz9Prve9Jc8FKodKSgREi?=
 =?us-ascii?Q?Sd37aPDyKMcfMx208iGblQcyVQOBkniMFsUvfvGqskjnwdaXNra+CjQ0vTpz?=
 =?us-ascii?Q?4sNigKssKbJn0nt8XSPMsvNr3SnOa/zeNVRUMAYrcLI/afQs/foetSIKQ3D0?=
 =?us-ascii?Q?qlkKQGsswGJfFera0b1KTrkU7tdfRoK6UOknx5Y6GskY1AN6TOlfSvgEN7Ji?=
 =?us-ascii?Q?UbDKj4AjHY2tq7FpXpQ01svyi47m9R3o9XkGJdtKUvICUf8otJ/pcdhj/WEi?=
 =?us-ascii?Q?mTTW12Vb5/BQmNWpNg82/LpmYgFGjYxnjuqjQOUPQtQWYXrsKtDYv3gcV9cL?=
 =?us-ascii?Q?726rdJy6Q/meMJ1K6J9GdJh7Bva6HeXancnr/EUAZ1Tn1A5tV8GZ9AeyLavb?=
 =?us-ascii?Q?wMbuNHK6QcHQte8YfRcmRg0qlXnvxD/ueF+Zca/Xg2Icx4XXj+GyqhQ6UQdc?=
 =?us-ascii?Q?MUdl+c8D0sOyueY5twnyakU/gVEzvWDLqyaRRnPTnkDDSCUBamg6kc0g+8/p?=
 =?us-ascii?Q?nip9SaCdGmnMm/6WUUs1m8v21SLgqeMW1pBATZjWHm1UjiUgyHyxY32FA1pX?=
 =?us-ascii?Q?u78xvQxIX/gavieJPNMe3C27J2SMsqOc0B2SYjvfXMYIll3c2LxqEboVU+fP?=
 =?us-ascii?Q?8Bd3uxUDr7iTWoWIz7zlL8dwh6ijckOniUC04sl+i9LlMszWFOq7iEMuLWrZ?=
 =?us-ascii?Q?6kEhpPnUrxHc9UZpMtuvMNJaMnT71udtEx7QMkl9X/xmlla8AJO6hJF67Hc4?=
 =?us-ascii?Q?mndQiEfF11JTA/66x7y3Rz9/KTkxrRBRs9bhiSbyVr2tV41mDqegbtmn1vVO?=
 =?us-ascii?Q?gpw0nq1Pg94CkIY4IeHt+AyFMM2oXcgPcOKT0X98gmdFy9Izvoj0RfyoI31D?=
 =?us-ascii?Q?QPTEVap5CLfOdcZCCG2Eex3KgaY1qqAaC4KZ/hwusRAbp276Mkx1pCSg5ejd?=
 =?us-ascii?Q?8jV1XyFMSYrcKc7SVV2Y4Q3VTOiRS3zxAfAhAwewpSDrMHp4//lbxdanRdCF?=
 =?us-ascii?Q?RZElw178kpuETfZxX3ZXZKiGHYEvNRPsKoZ4JsWXV1oOf7MEICf8BBiwLMTK?=
 =?us-ascii?Q?1/HKGWBgzuZLFjuCU/X+pMSGl9hB1uyj2kfxWcl7+rJBKzA3wHNTny1PUKlB?=
 =?us-ascii?Q?JyNz+0/EZ9XHeQv5K0rgx7y8QuTG//TwGHtE/rubM1xKPd87F/HbNYrVpETx?=
 =?us-ascii?Q?nwtfMZbuN5efg1QXIAxftrcm0q+GNlE59Rxo9IeuipciBYuc3tPW0hcg1eLV?=
 =?us-ascii?Q?w+jXwL+JLjCoL/aSS8cxLighiUycmgwn5Jv+Sc+RY26RdXoIgP/FdLShthVg?=
 =?us-ascii?Q?DMjl5i+FaZEJlSj4awC2RHQa/R671mFfZVgjJhii+DioDTma8VSektFth0ho?=
 =?us-ascii?Q?w0M1LIY72a0RYbx5FBq3H6Ws20mcElgjX1CRmOrZvNnfEWJYFkuuINfK2VcP?=
 =?us-ascii?Q?MR0O3mO+8bAoknfUdFkUt+vzH6deO6q+pz8Kr3byjTcKAruxhgC7zHV/b3SZ?=
 =?us-ascii?Q?/3bP108/CGzkWUs1F1E4RGzwwvt1TFeUlm5SHR2UgOBJJDCpBO3A7rpT3vv+?=
 =?us-ascii?Q?xG6VHjsOTBAVujelXfWGrjJMT7fePIdEX/mk0quu?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ac27865-ddba-4b0e-0abe-08db0f26450f
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 07:28:44.6406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tc+czhxEacModekUPpjTfR1U83PUQH3zeAv8dVB+13L7967nqraDa1IjipMFOxBz2pMpv0hqbIyq/RVbcl3i+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5673
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 15 Feb 2023 06:47:35 +0800
David Gow <davidgow@google.com> wrote:

> The rust_fmt_argument function is called from printk() to handle the %pA
> format specifier.
> 
> Since it's called from C, we should mark it extern "C" to make sure it's
> ABI compatible.
> 
> Cc: stable@vger.kernel.org
> Fixes: 247b365dc8dc ("rust: add `kernel` crate")
> Signed-off-by: David Gow <davidgow@google.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> 
> See discussion in:
> https://github.com/Rust-for-Linux/linux/pull/967
> and
> https://github.com/Rust-for-Linux/linux/pull/966
> 
> ---
>  rust/kernel/print.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/print.rs b/rust/kernel/print.rs
> index 30103325696d..ec457f0952fe 100644
> --- a/rust/kernel/print.rs
> +++ b/rust/kernel/print.rs
> @@ -18,7 +18,7 @@ use crate::bindings;
>  
>  // Called from `vsprintf` with format specifier `%pA`.
>  #[no_mangle]
> -unsafe fn rust_fmt_argument(buf: *mut c_char, end: *mut c_char, ptr: *const c_void) -> *mut c_char {
> +unsafe extern "C" fn rust_fmt_argument(buf: *mut c_char, end: *mut c_char, ptr: *const c_void) -> *mut c_char {
>      use fmt::Write;
>      // SAFETY: The C contract guarantees that `buf` is valid if it's less than `end`.
>      let mut w = unsafe { RawFormatter::from_ptrs(buf.cast(), end.cast()) };