Message-ID: <e066920c-26a9-0f0e-3304-2b9940274d57@starfivetech.com>
Date:   Wed, 15 Feb 2023 15:46:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems
 number of resets and reset-names
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Richard Cochran <richardcochran@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Peter Geis <pgwipeout@gmail.com>
References: <20230118061701.30047-1-yanhong.wang@starfivetech.com>
 <20230118061701.30047-3-yanhong.wang@starfivetech.com>
 <15a87640-d8c7-d7aa-bdfb-608fa2e497cb@linaro.org>
 <c9ab22b5-3ffb-d034-b8b8-b056b82a96ce@starfivetech.com>
 <aa85caa3-6051-46ab-d927-8c552d5a718d@linaro.org>
From:   yanhong wang <yanhong.wang@starfivetech.com>
In-Reply-To: <aa85caa3-6051-46ab-d927-8c552d5a718d@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/2/7 15:59, Krzysztof Kozlowski wrote:
> On 07/02/2023 03:43, yanhong wang wrote:
>> 
>> 
>> On 2023/1/18 23:47, Krzysztof Kozlowski wrote:
>>> On 18/01/2023 07:16, Yanhong Wang wrote:
>>>> Some boards(such as StarFive VisionFive v2) require more than one value
>>>> which defined by resets property, so the original definition can not
>>>> meet the requirements. In order to adapt to different requirements,
>>>> adjust the maxitems number definition.
>>>>
>>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
>>>>  1 file changed, 3 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>>> index e26c3e76ebb7..baf2c5b9e92d 100644
>>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>>> @@ -133,12 +133,9 @@ properties:
>>>>          - ptp_ref
>>>>  
>>>>    resets:
>>>> -    maxItems: 1
>>>
>>> Also, this does not make sense on its own and messes constraints for all
>>> other users. So another no for entire patch.
>>>
>> 
>> Thanks. Change the properties of 'resets' and reset-names like this:
>> 
>>   resets:
>>     minItems: 1
>>     maxItems: 2
>> 
>>   reset-names:
>>     minItems: 1
>>     maxItems: 2
>> 
>> Is it right?  Do you have any other better suggestions?
> 
> Isn't this allowing two reset items for every variant of snps,dwmac?
> 

Sorry for not getting back to you faster.
After referring to the above modification, i used the command 'make DT_CHECKER_FLAGS=-m dt_binding_check'
to check all the bindings(including 'starfive,jh7110-dwmac.yaml'), no errors are reported,
and the errors reported by Rob Herring are gone.

> Best regards,
> Krzysztof
>