Message-ID: <41bc30ac7af4b0ce3ff608b604fb6ea762428680.camel@nxp.com>
Subject: Re: [PATCH v3 1/6] dt-bindings: lcdif: Add i.MX93 LCDIF support
From:   Liu Ying <victor.liu@nxp.com>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     marex@denx.de, stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com,
        krzysztof.kozlowski@linaro.org, LW@karo-electronics.de
Date:   Wed, 15 Feb 2023 15:49:56 +0800
In-Reply-To: <2551514.Lt9SDvczpP@steina-w>
References: <20230213085612.1026538-1-victor.liu@nxp.com>
         <20230213085612.1026538-2-victor.liu@nxp.com> <2551514.Lt9SDvczpP@steina-w>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlJMeEZnc2tWUjdKdUlYQ1NwQ25TaHplOEV6ak41SWQzS0ROVnRhV2RkY1cr?=
 =?utf-8?B?QzBaS2x6RzdNNlV3U1A4dUEySUtFTkR2RE1EcUZSWklNekRvRjc4dVJvVjJX?=
 =?utf-8?B?d3hPMG90NXlVNmg5a1BIbEljRFZBa1htaE5EbzBJdGx6ay8vZHhaV2NXWGV3?=
 =?utf-8?B?N3lOSFN1U2pnV1U2b3hNU0pDMzBpa3pMWm1FbE1CdTYzMGpKcG9meXYxTk9a?=
 =?utf-8?B?aDNPaWJpbkw1QnZzT05tUjJvenNVaW1WNGtnblBaMDNhNzZOUVNTaU5Dcm1n?=
 =?utf-8?B?a2pOTm8rYXYveUFtdEpSQXdvWVRaOEVuNFFKYWxyeFNKelRpaWxXcXV3bGpM?=
 =?utf-8?B?VW41V3p4TzFSUGdYdlVkSGV2R09tc1BITGZFMEFLeE04Y3ZNMlpXN216TlN1?=
 =?utf-8?B?SWVOVm5WRkR0eDdralVBUmsvUlpOVkhGWEFSeTdlUExua0JGUnR1cCtmZG5S?=
 =?utf-8?B?c21lMTNOTEp0Z0UrTmVKOGxRWXJKT1VKZnVDaFFKYlFiU0xTOElYOFU3bVdY?=
 =?utf-8?B?UDJ5bENXZWd0d21nTDUyR0RkQkZ3NXo0aElUeGc1ZTRJRjdkS293b01HWGZX?=
 =?utf-8?B?QVNCSmJjTXlPanB1eUNYNlFiYy91SlRxWHhtTjVmSWtST3poT2tjczFWYkta?=
 =?utf-8?B?WVRKcmJOLzBabHgyZDZ0WlB2QWNUTW9MREg5bFN4akhBdzZQbjhmdmZZdnhs?=
 =?utf-8?B?bVRJUnhLaGhxZFpnQklYalZvWWNmZHo3L291T0pWYnJENEtwYWZGQ3I3OXhj?=
 =?utf-8?B?UFczVldyZ0tWRU1HKzFqV25iSEV5NXQwdVV4SW5XSmw5QVdjQnYxRndRZzVl?=
 =?utf-8?B?S3kweUhqUzhsM041citpSFJZeDUrTlh1dEsyQm82Z0h6NStLSlZwbXp5TUtx?=
 =?utf-8?B?d3FaR3FLQ0Jhc0FGNkNaRHJKUWZyMTlDRlNmL2k0Q2piVlNZSi9BRDVvNnhZ?=
 =?utf-8?B?dHJaMk1yK3Q1cHJtMXk0SEZaK0o2aHRDUk9LNlozNDhYYlU5bm5QcEVCc21F?=
 =?utf-8?B?Tm5GdTJhcmJyaVp6NE5SbjBtOVdsOS84eTRwSnJFS1FmVjdvVndTM1VHcGFB?=
 =?utf-8?B?Rks4L0FhRENQaXZRT1Y1T1Q1eTV5VEI2Y0pEYUdWQmRqZHprSE14VzlzQkt0?=
 =?utf-8?B?UFp4WnNrVVZMNmZWQjJoZjg3MDZ1UGtVQkpYVExSbnFvM2hTak1lSVV6Q3Na?=
 =?utf-8?B?TFdaOE41Mm00aHBjRjZIRWxKeUIrVmRRSTBkS28ySnl0WElWZ2hPN0ZNcFJD?=
 =?utf-8?B?bW01SHdTclBYcVExRS9sWldjUTFlTU04aERlVFVIdGV0cDJsQjRNSlEzN2hw?=
 =?utf-8?B?SUFRQlMwbTBIcXAyTm8wYnM3MUMzb2VDZU9RQndRaDRCWGV6aWlSWVlRY1lO?=
 =?utf-8?B?NVNUa1I2TFc1U29NcHF0Ly85WjU0QzNvaEZnVGtuSkczdExHY0ZreTFmSGRo?=
 =?utf-8?B?UGY3dVlTa2pUODlQZDFLUHNUMlhDM3dFSXVJalRCbEEvRFRwd016cU5qb3dU?=
 =?utf-8?B?RTQyQkJPVVVxZ2puR2JCdkV0dVExSmQwbnpTSTdHWWY5amQzcjZpdzZEUzR3?=
 =?utf-8?B?elRjT21LSEhudVhqY2N0eXlKOTdwZm1nUm9Fc2pjckh4UE84WlJhY1RyUXNK?=
 =?utf-8?B?OERnL2N3REpXRXlDbk9CL1V2dDRqNy81ancvMFZhNm40UGlYc2pGMWg5d2VR?=
 =?utf-8?B?WkFoeW9hZi9JRlQ2QmRrVlRoY25MdzIxSElqV0k2aHdNdzhuWGRnbEJ2MTlL?=
 =?utf-8?B?bHBzMG5VTWpVWGE2cmJSdGNhd1RrMnlSYmJVVlFSNUg4RjJQcW5YaEpjT2Fu?=
 =?utf-8?B?OEhkSElPVm5ZRWFRRUhtWElHQnhOUnZ4TXRFeldDTmtTcFo4dU56WkFQM0tK?=
 =?utf-8?B?VU1DeXIwalptZk8reGIybE03bUkxU2gwRFRkRmJicWdwR21qeDZNbC81Nm9E?=
 =?utf-8?B?U25rVGdBQkRGWkY5M1dwNmZnTUlwdkk4amZKM3AwVXk0UHZKeEFweEFjcXRQ?=
 =?utf-8?B?cU0yOVJWU2J1cklsWWZnakhHY3VmQXk3aDF0M3g4NDlyNlhLVy9pRHBoUjBh?=
 =?utf-8?B?QWNlYUlRZUVPeTh2V29mSU1RT2gwb1A2a3psZHRVaVBMaS9BN1JvRFF0dlQ3?=
 =?utf-8?Q?+dpvTCLjTb80m+VvwIRrt8BCT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f3fa30d-3f45-4480-b6cf-08db0f294a72
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 07:50:22.7663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wrkvfM008B1aGUcZsqCpZALpztu7ZGqmycH6qJydIEUxaBI/Eo+Pbg/XI5IzBtURI+1AQok8kwW8Rktchm2TnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8177
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2023-02-15 at 08:26 +0100, Alexander Stein wrote:
> Hi Liu,

Hi Alexander,

> 
> thanks for the update.

Thanks for the review.

> 
> Am Montag, 13. Februar 2023, 09:56:07 CET schrieb Liu Ying:
> > There is one LCDIF embedded in i.MX93 SoC to connect with
> > MIPI DSI controller through LCDIF cross line pattern(controlled
> > by mediamix blk-ctrl) or connect with LVDS display bridge(LDB)
> > directly or connect with a parallel display through parallel
> > display format(also controlled by mediamix blk-ctrl).  i.MX93
> > LCDIF IP is essentially the same to i.MX8MP LCDIF IP.  Add device
> > tree binding for i.MX93 LCDIF.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Reviewed-by: Marek Vasut <marex@denx.de>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v2->v3:
> > * No change.
> > 
> > v1->v2:
> > * Add Krzysztof's A-b and Marek's R-b tags on patch 1/6.
> > 
> >  Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7
> > ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> > 75b4efd70ba8..fc11ab5fc465 100644
> > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> > @@ -21,6 +21,7 @@ properties:
> >            - fsl,imx28-lcdif
> >            - fsl,imx6sx-lcdif
> >            - fsl,imx8mp-lcdif
> > +          - fsl,imx93-lcdif
> >        - items:
> >            - enum:
> >                - fsl,imx6sl-lcdif
> > @@ -88,7 +89,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: fsl,imx8mp-lcdif
> > +            enum:
> > +              - fsl,imx8mp-lcdif
> > +              - fsl,imx93-lcdif
> >      then:
> >        properties:
> >          clocks:
> > @@ -107,6 +110,7 @@ allOf:
> >                enum:
> >                  - fsl,imx6sx-lcdif
> >                  - fsl,imx8mp-lcdif
> > +                - fsl,imx93-lcdif
> >      then:
> >        properties:
> >          clocks:
> > @@ -123,6 +127,7 @@ allOf:
> >                - fsl,imx8mm-lcdif
> >                - fsl,imx8mn-lcdif
> >                - fsl,imx8mp-lcdif
> > +              - fsl,imx93-lcdif
> >      then:
> >        required:
> >          - power-domains
> 
> I would have expected that fsl,imx93-lcdif supports up to 3 endpoints
> (MIPI 
> DSI, LVDS, and parallel) in a 'ports' subnode. But this binding only
> supports 
> a single 'port' sub-node. Also an example for this case might be very
> helpful.

The port node allows multiple endpoints(See graph.yaml[1]).  It's
enough to use the existing port node instead of using ports node.

For i.MX93 LCDIF, the port node will be something like this:
--------------------8<--------------------------
port {
        #address-cells = <1>;
        #size-cells = <0>;

        lcdif_to_pdfc: endpoint@0 {
                reg = <0>;
        };

        lcdif_to_ldb: endpoint@1 {
                reg = <1>;
        };

        lcdif_to_cross_line_pattern: endpoint@2 {
                reg = <2>;
        };
};
--------------------8<--------------------------

Looks like it's not necessary to add a specifc example for i.MX93
LCDIF.

[1] 
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/graph.yaml#L48

Regards,
Liu Ying