Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Subject: Re: [PATCH -tip v2] x86/kprobes: Remove unneeded casting from
 immediate value
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <167641982421.1677831.18379341946856978545.stgit@mhiramat.roam.corp.google.com>
Date:   Wed, 15 Feb 2023 10:07:33 +0200
Cc:     X86 ML <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <AEF3FED8-BF58-4B9E-B36E-662A09636A70@gmail.com>
References: <167641982421.1677831.18379341946856978545.stgit@mhiramat.roam.corp.google.com>
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Precedence: bulk


> On Feb 15, 2023, at 2:10 AM, Masami Hiramatsu (Google) =
<mhiramat@kernel.org> wrote:
>=20
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>=20
> Remove unneeded casting from immediate value assignments for relative
> jump offset. Since the immediate values in the 'insn' data structure =
are
> assigned from immediate bytes as a signed value to =
insn.immediate.value
> by insn_field_set(). Thus, if we need to access that value as a signed
> value (in this kprobe's case), we don't need to cast it.
> This is a kind of clean up (should not change behavior) follows =
Nadav's
> bugfix.
>=20
> Link: =
https://lore.kernel.org/all/20230208071708.4048-1-namit@vmware.com/
>=20
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks for incorporating my feedback.

Acked-by: Nadav Amit <namit@vmware.com>