From:   Javier Carrasco <javier.carrasco@wolfvision.net>
To:     linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Javier Carrasco <javier.carrasco@wolfvision.net>
Subject: [PATCH v2 2/2] rtc: pcf85363: add support for the quartz-load-femtofarads property
Date:   Wed, 15 Feb 2023 09:18:15 +0100
Message-Id: <20230215081815.3141776-3-javier.carrasco@wolfvision.net>
In-Reply-To: <20230215081815.3141776-1-javier.carrasco@wolfvision.net>
References: <20230215081815.3141776-1-javier.carrasco@wolfvision.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K+RZkDmfmQaf/8S8A6ZR7fP+yufzfePc7KWQ9vgrCKQncV5U88CbfTl5mRPT?=
 =?us-ascii?Q?PqQy98kR4Mu+ctOyDp4kmJSUhSPx7O27aVPk06kRB8CI74eQIt4p/usb+hTo?=
 =?us-ascii?Q?f0AH0iE6mWa2XtYo5mPzSo/yp/+/oE6YV3aMUOVzljBSYoODLTZ9hFfa0P7E?=
 =?us-ascii?Q?b6+PZ1oiB5X9IjLAANRD8TNtz3d13WwEk9+1d4kEl6anOWzJ3anY8gY1Q0jZ?=
 =?us-ascii?Q?BzuDOGXJx3aqJFZey0kRZbYq+Kzk3KVOZdzmsM6M14uwIYeYNoMH3WxjQsAj?=
 =?us-ascii?Q?0hhSrSIK9wF1oZnEt8zgL7hmVihhnaEkacKKIntgx44lzJm5udG+pSXRT6BA?=
 =?us-ascii?Q?GYQvid1IIpEOfo6lUHZ1d0Dwvjg5wHTAwZ1LVCfKizp9FwpWDe2E5DeKQWVD?=
 =?us-ascii?Q?WQgg2qVQKu1aILa8ljE9nMu+19erq8OfjKzdJLv7DkaHjOUX17CKty9aCWK0?=
 =?us-ascii?Q?eoI7xeoSRBiUqCfi48+19FmhbTkeOHfyPBrqIRipQW786l+IGclYMzr7P3+6?=
 =?us-ascii?Q?xpLpwm0z+SFTQ6kt3aYZjqiffS7mUMMx640OZIqnQmpQl07wx+GLMMCFmWHq?=
 =?us-ascii?Q?/MK88c3Ooo+x73BsHj5DC1vaTdwdqCwD37tJuxmnTWY+fnua7khQYhNfFm3X?=
 =?us-ascii?Q?cJANfJR82ShLf5keVZJjG9p7s26YlcwT4d+85FC19rxnrHVkETKp0+TRFPyR?=
 =?us-ascii?Q?/5/VnSYKyyxn2rlv42Kq9YSKLixL7gcnTOYkFKViY5B5h1iwCgmArhUbiApL?=
 =?us-ascii?Q?kIgLxHnSVWIsREQIIkV9+LyWREmt1BGr87L1i9Z+mghciLnpCw3fBTxnteQy?=
 =?us-ascii?Q?Yl73E4Ex/f5se1U927IesC8VToJKW8FZW1rovyCu+zoo1JT8fy32BS0LR4yy?=
 =?us-ascii?Q?ur3cMQlLVBRaFoKSz7V/zB7Rm1uEL+e4c0pHN14Vk3Vbpp+4421bzHlOFPom?=
 =?us-ascii?Q?TOa1GtfBMx+wqQVUU113Q7ypUFRnkVUJs+LPhpevylikRLbwbRuMisiNDpEu?=
 =?us-ascii?Q?Lq+Gp8zlyr3cm2fbqnzF/BcIyv0xVI7u+pTVrvEMEP5T3SbHxW61s0E6gBy/?=
 =?us-ascii?Q?Da20O1t3XmDi23dq33z9BHIGtLVYwvrYx1FR3lGDSehZUEAyFomTcvu8TQWl?=
 =?us-ascii?Q?ybG1oVO/6rIbGMBvxwnSo3s6hlzv5n5YrvKxBii/q244EFWHcX/fINqzp1y1?=
 =?us-ascii?Q?F2dvZ+PosWgwijLTHlpAW2ufCMHiLKBSGIbnT1jnr9cGcEW+ihjHg68C6zV6?=
 =?us-ascii?Q?G8pn/tFkle4J9avG8X/FHAQucYr1bUKOtJ4ehLwsmcAqF4Rh0ht21acRXHmm?=
 =?us-ascii?Q?b3HvLBtB+EYTxrzeN7Vd97G+n2Zo7gxny2rj0yZ+ltIx/rGodtLFtKordw1J?=
 =?us-ascii?Q?IIy0izfbsq9cVo4c9uZiw2CqmwS+6tZVG3Tb7LOErUK9Uh+740rqtv4QCv3b?=
 =?us-ascii?Q?axh74jMjYgvse7czD22r0+x8uBaHlywJFcfkcXBBDtubQ+9qEr1HVUqQ0byN?=
 =?us-ascii?Q?9GGv6p7NxkpM5J/8ZhelmJH2D/zpyfKLcgtaO5OJMX1Ysg8QkTzUJfPOeJ8q?=
 =?us-ascii?Q?eUz2wIdXhCAzkjC6O9fwP0BWwp/WSP/1N7/ehoQc4J0izlzUt18QlA0gmQh+?=
 =?us-ascii?Q?1TaNNoHqvJUCccbANqaZ2D0=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 73d8a279-971c-42a7-cfca-08db0f2d43ef
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 08:18:49.2198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1foFLZNwyK20Bf9iwf9S08gBfese+Okkh4SrWf8XSSgqk66sjLt1m8tL+S8NbeRYlnlRvz3/c0ZkOpabvi3ZBKxW6V1REC/DLWe6GBUmQeE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5706
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The quartz oscillator load capacitance of the PCF85263 and PCF85363 can
be adjusted to 6 pF, 7 pF (default) and 12.5 pF with the CL[1:0] bits in
the oscillator control register (address 25h).

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
v2:
  - simple assignment operator instead of |= for the "value" variable.

 drivers/rtc/rtc-pcf85363.c | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
index c05b722f0060..219fbca8c47f 100644
--- a/drivers/rtc/rtc-pcf85363.c
+++ b/drivers/rtc/rtc-pcf85363.c
@@ -101,6 +101,10 @@
 #define PIN_IO_INTA_OUT	2
 #define PIN_IO_INTA_HIZ	3
 
+#define OSC_CAP_SEL	GENMASK(1, 0)
+#define OSC_CAP_6000	0x01
+#define OSC_CAP_12500	0x02
+
 #define STOP_EN_STOP	BIT(0)
 
 #define RESET_CPR	0xa4
@@ -117,6 +121,32 @@ struct pcf85x63_config {
 	unsigned int num_nvram;
 };
 
+static int pcf85363_load_capacitance(struct pcf85363 *pcf85363, struct device_node *node)
+{
+	u32 load = 7000;
+	u8 value = 0;
+
+	of_property_read_u32(node, "quartz-load-femtofarads", &load);
+
+	switch (load) {
+	default:
+		dev_warn(&pcf85363->rtc->dev, "Unknown quartz-load-femtofarads value: %d. Assuming 7000",
+			 load);
+		fallthrough;
+	case 7000:
+		break;
+	case 6000:
+		value = OSC_CAP_6000;
+		break;
+	case 12500:
+		value = OSC_CAP_12500;
+		break;
+	}
+
+	return regmap_update_bits(pcf85363->regmap, CTRL_OSCILLATOR,
+				  OSC_CAP_SEL, value);
+}
+
 static int pcf85363_rtc_read_time(struct device *dev, struct rtc_time *tm)
 {
 	struct pcf85363 *pcf85363 = dev_get_drvdata(dev);
@@ -372,7 +402,7 @@ static int pcf85363_probe(struct i2c_client *client)
 			.reg_write = pcf85363_nvram_write,
 		},
 	};
-	int ret, i;
+	int ret, i, err;
 
 	if (data)
 		config = data;
@@ -394,6 +424,11 @@ static int pcf85363_probe(struct i2c_client *client)
 	if (IS_ERR(pcf85363->rtc))
 		return PTR_ERR(pcf85363->rtc);
 
+	err = pcf85363_load_capacitance(pcf85363, client->dev.of_node);
+	if (err < 0)
+		dev_warn(&client->dev, "failed to set xtal load capacitance: %d",
+			 err);
+
 	pcf85363->rtc->ops = &rtc_ops;
 	pcf85363->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
 	pcf85363->rtc->range_max = RTC_TIMESTAMP_END_2099;
-- 
2.37.2