Message-ID: <38afd44e-a93c-ecf5-7c5c-48c5a6bf3b46@nvidia.com>
Date:   Wed, 15 Feb 2023 16:26:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH net-next v1 1/3] vxlan: Expose helper vxlan_build_gbp_hdr
Content-Language: en-US
To:     Alexander Lobakin <alexandr.lobakin@intel.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        "eng.alaamohamedsoliman.am@gmail.com" 
        <eng.alaamohamedsoliman.am@gmail.com>,
        "bigeasy@linutronix.de" <bigeasy@linutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Roi Dayan <roid@nvidia.com>, Maor Dickman <maord@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
References: <20230214134137.225999-1-gavinl@nvidia.com>
 <20230214134137.225999-2-gavinl@nvidia.com>
 <a5a43d44-277a-1222-a700-ddade69d6243@intel.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <a5a43d44-277a-1222-a700-ddade69d6243@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WERTbldwNmtPNy9TU2RyRFZ4czcyeVVROFNHUVV3dE5GR2syUGxGTnNCMVJO?=
 =?utf-8?B?ZkhheTBhV0k4R3JONDREN25za29pM2NCK2ZldGhZZ1pnMitNZmxCMTBmQWtp?=
 =?utf-8?B?RUNyb1c1dUtvWFpUUjhmZ1NPamNPc2J0eXhQYkl1VUZUTnQrN2ZZS2RSOTJ6?=
 =?utf-8?B?ZkFveFl1OE5DK3IwT3QyUk5EaUNIL1gvZWMyb0R6U012Tnd1VExXUE1ZZHk5?=
 =?utf-8?B?RDlXb2VkRG1iaDhrR3FESzQ1MkplY0ZVSm9QUlJnVlJuaGxIblVwSkxNQXJr?=
 =?utf-8?B?QzNyVkxEbUFMMlZTc2pNNHdoYkU5L2xWa3Q2OUZDZ2FnMHhBNm1iWGZFb3NF?=
 =?utf-8?B?ZDZ5cVpkdjc0dktUMUVJRDRGaWR3ZTdTNUg3YUVzZVV4Rks5alkrRFpRNEtl?=
 =?utf-8?B?UXZLTVlCTmVNcktvTjQweWRQWHFGQmg1WWFGKzFnc3lqb09uY05IcFplaXhE?=
 =?utf-8?B?M0pzWDFiVTRCbmNrV3hlTEJHWGJnVnFwckVuRkU2SUowYjZwL3pHRzU1YlBC?=
 =?utf-8?B?dGtNNUdaOVdzSVdHZ3pYVGF6SVhLRmdnR01uOUhoVDlTNlJJMFNVWUQxWWZM?=
 =?utf-8?B?NHJOVENGK2JTMk1pNU9GbCtKUlM1eElYQXY4RFI3cGJRdUpjQWtUZ3dyUW5Y?=
 =?utf-8?B?Q3QyTFIwWGlJNlRwb2MydE40bnRhUnY0cDE2dXprYWNPbUFnUmowajZRSnBs?=
 =?utf-8?B?OGdpTXJrb1RneThvSDRRWFFnRm03ZHpPRjdlc1hIOXI3UEhGQjBmUHg3SHZH?=
 =?utf-8?B?N0NTWkUrNllEQzhMM05NcmZNVUVwU3lXSGNnV09EWnJZMzc0aHJQV01INlNo?=
 =?utf-8?B?QkFQUmxpanlmZ0pvRk56OGZKdzJ6NHR0d1E0UDJyUnlFcEVZd1JVTUlwUlEx?=
 =?utf-8?B?OTAzVmhhbjkwa1pxajhzbTZzY0J2bnZQUHlQSVdaTnR5ZDN2OTNYUDBxVnlq?=
 =?utf-8?B?ZHpwT2ZTVmZBdUVwWjVtNVp6aXNzcHNocFFXN0J1WmFFY2t5SkNCRk92bnl5?=
 =?utf-8?B?eERnSlhRU21VbVQwOFkyK2hPbnNFUmVzNEw5aE5kcStHcDZJTS9qMjlhVzJY?=
 =?utf-8?B?cG9IU1JiU3RlbXlDYlM1VEYwZ0VkeEVoM1Zud1RMMVFwV3V6cXlQSUxQSWZ4?=
 =?utf-8?B?SUllSkxHL25kcWg3VWJGSlZzektuYVU4UzlOTkF3S0pDbmxvc25JaG83aU4w?=
 =?utf-8?B?ejQ2RXltNDhkRC8yeXRUSzJBeERjVjJ1RUx4RmlYT2hZM1NsZytvZ3FESjdB?=
 =?utf-8?B?M1IzT3ZqdXpvMEM1QW9tNGYxMDl6cTAybG92VzJBYW9TTmxEMFMwZTZQMHdF?=
 =?utf-8?B?Q3JXQUdma3Q0L3V3Qm9SOWtFUWRUV3g1Qi9yTWtzem9qSFV1OUJhZmo5ZEpG?=
 =?utf-8?B?aFd0SzFJc1ZoUXJid0RCVEk1RmlFUU1WU3pYVWtlRk1EUWFTbTQzbXpVNzQ0?=
 =?utf-8?B?MEYxeUI3RmJwWDlnVGorQnhoMHpLdG9VQWgvMGFSSS9JdmpaWGkyTklGSjJ3?=
 =?utf-8?B?dUFRc0Q1cDJkVUQzTWR6YVlFM1B5VFBneHAxbXVhLzFzQXBER0FKMXdhQ1BF?=
 =?utf-8?B?c3JJZjhsSDVnY09BT2lUbDVhbklHUll0djM0cC9ZTWY0OWM3Ti85VzBzN3Zw?=
 =?utf-8?B?K2RGZ2RBM0Y0QmF5bnczc0d3MmgwUE02eTBWcTJWdVI5U0pvY2NnNkx6bC93?=
 =?utf-8?B?TFF1MXloT0VJOWcyc2oveHBxYmNybnVzcDl4YmhIWEVlbW9BZFdWTGVlZFhp?=
 =?utf-8?B?anhlWGdUQ1lXZU1YdElVNVJGdHBaQmoxTjNreVpQYjQwRkZDNnRldmtVQTBC?=
 =?utf-8?B?TU8wTkRlYitQZTlTV1Jha1ZKMGxFT1JiSkZnSmkxK0RKUTJqTEJyVUM4U3Y2?=
 =?utf-8?B?dHdjTUxYZVRWdTFJN2ZvU1BPelRYa1ppUVAveGdoNG96WGVxVTBtVjU2eWRx?=
 =?utf-8?B?aGkxUU9OWWwzU1FPNFkrUVFCWGNTOHp4MXFXM2xPbGpKa293V04zZjFhcHNl?=
 =?utf-8?B?VHZkUjV4NWUvNEc1L2hSUmd1VEZOL0N0SFFSRmJQZGNvT3ZwMzNEME9Sdi9X?=
 =?utf-8?B?SVlTbm5DRXBycHplb3VaYzVWd3R6ZDRUSCsvUFZIUnphWXFUOTNtS3ByQnE1?=
 =?utf-8?Q?YNAG98gQji95U1IY99GN15CZ5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62602de7-f40e-4395-b1bf-08db0f2e5de0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 08:26:42.4725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DsRAcgUOy4Tc4eFTLzA6Hy8AV+8NUhF+tzK3Zb6x/j9AIcryH7ITRZtvZcq3hrePl0eTf5zUJy5uf0KXyPZlAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5187
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/14/2023 10:56 PM, Alexander Lobakin wrote:
> External email: Use caution opening links or attachments
>
>
> From: Gavin Li <gavinl@nvidia.com>
> Date: Tue, 14 Feb 2023 15:41:35 +0200
>
>> vxlan_build_gbp_hdr will be used by other modules to build gbp option in
>> vxlan header according to gbp flags.
> (not sure if it's okay to write abbreviations with non-capital)
Don't sure either but most of the functions in vxlan (if not all) are 
declared in this way.
>
>> Change-Id: I10d8dd31d6048e1fcd08cd76ee3bcd3029053552
>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>> Reviewed-by: Roi Dayan <roid@nvidia.com>
>> Reviewed-by: Maor Dickman <maord@nvidia.com>
>> Acked-by: Saeed Mahameed <saeedm@nvidia.com>
> Besides the nit above:
>
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
>
>> ---
>>   drivers/net/vxlan/vxlan_core.c | 20 --------------------
>>   include/net/vxlan.h            | 20 ++++++++++++++++++++
>>   2 files changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
>> index b1b179effe2a..bd44467a5a39 100644
>> --- a/drivers/net/vxlan/vxlan_core.c
>> +++ b/drivers/net/vxlan/vxlan_core.c
>> @@ -2140,26 +2140,6 @@ static bool route_shortcircuit(struct net_device *dev, struct sk_buff *skb)
>>        return false;
>>   }
>>
>> -static void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
>> -                             struct vxlan_metadata *md)
>> -{
>> -     struct vxlanhdr_gbp *gbp;
>> -
>> -     if (!md->gbp)
>> -             return;
>> -
>> -     gbp = (struct vxlanhdr_gbp *)vxh;
>> -     vxh->vx_flags |= VXLAN_HF_GBP;
>> -
>> -     if (md->gbp & VXLAN_GBP_DONT_LEARN)
>> -             gbp->dont_learn = 1;
>> -
>> -     if (md->gbp & VXLAN_GBP_POLICY_APPLIED)
>> -             gbp->policy_applied = 1;
>> -
>> -     gbp->policy_id = htons(md->gbp & VXLAN_GBP_ID_MASK);
>> -}
>> -
>>   static int vxlan_build_gpe_hdr(struct vxlanhdr *vxh, u32 vxflags,
>>                               __be16 protocol)
>>   {
>> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
>> index bca5b01af247..08bc762a7e94 100644
>> --- a/include/net/vxlan.h
>> +++ b/include/net/vxlan.h
>> @@ -566,4 +566,24 @@ static inline bool vxlan_fdb_nh_path_select(struct nexthop *nh,
>>        return true;
>>   }
>>
>> +static inline void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
>> +                                    struct vxlan_metadata *md)
>> +{
>> +     struct vxlanhdr_gbp *gbp;
>> +
>> +     if (!md->gbp)
>> +             return;
>> +
>> +     gbp = (struct vxlanhdr_gbp *)vxh;
>> +     vxh->vx_flags |= VXLAN_HF_GBP;
>> +
>> +     if (md->gbp & VXLAN_GBP_DONT_LEARN)
>> +             gbp->dont_learn = 1;
>> +
>> +     if (md->gbp & VXLAN_GBP_POLICY_APPLIED)
>> +             gbp->policy_applied = 1;
>> +
>> +     gbp->policy_id = htons(md->gbp & VXLAN_GBP_ID_MASK);
>> +}
>> +
>>   #endif
> Thanks,
> Olek